Issue 773713 in chromium: Implement `import.meta.url`

20 views
Skip to first unread message

hirosh… via monorail

unread,
Dec 22, 2017, 7:08:44 PM12/22/17
to modul...@chromium.org
Updates:
Status: Fixed
Summary: Implement `import.meta.url`

Comment #11 on issue 773713 by hirosh...@chromium.org: Implement `import.meta.url`
https://bugs.chromium.org/p/chromium/issues/detail?id=773713#c11

import.meta might also contains import.meta.scriptElement.
However, the spec discussion related to introducing import.meta.scriptElement is still open (https://github.com/whatwg/html/issues/1013), so having separate crbug issues is better.

Changing this as Implement `import.meta.url` and closing as fixed.

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment.

bugdro… via monorail

unread,
Sep 30, 2018, 10:37:23 PM9/30/18
to modul...@chromium.org

Comment #12 on issue 773713 by bugd...@chromium.org: Implement `import.meta.url`
https://bugs.chromium.org/p/chromium/issues/detail?id=773713#c12

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/14d350d474272ad31b29d5b4897c9b1deba2ff52

commit 14d350d474272ad31b29d5b4897c9b1deba2ff52
Author: Kouhei Ueno <kou...@chromium.org>
Date: Mon Oct 01 02:36:27 2018

[ES6 modules] Enable dynamic import and import.meta by default without feature flags

Retire the flags now that it is very unlikely we'll revert them.

Bug: 711706, 773713
Change-Id: I854c5be068b42ef5fb58fe23f45ba1af107ece9a
Reviewed-on: https://chromium-review.googlesource.com/1250681
Commit-Queue: Kouhei Ueno <kou...@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhi...@chromium.org>
Reviewed-by: Kinuko Yasuda <kin...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595371}
[modify] https://crrev.com/14d350d474272ad31b29d5b4897c9b1deba2ff52/chrome/browser/about_flags.cc
[modify] https://crrev.com/14d350d474272ad31b29d5b4897c9b1deba2ff52/content/child/runtime_features.cc
[modify] https://crrev.com/14d350d474272ad31b29d5b4897c9b1deba2ff52/content/public/common/content_features.cc
[modify] https://crrev.com/14d350d474272ad31b29d5b4897c9b1deba2ff52/content/public/common/content_features.h
[modify] https://crrev.com/14d350d474272ad31b29d5b4897c9b1deba2ff52/content/renderer/render_process_impl.cc
[modify] https://crrev.com/14d350d474272ad31b29d5b4897c9b1deba2ff52/third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
[modify] https://crrev.com/14d350d474272ad31b29d5b4897c9b1deba2ff52/third_party/blink/renderer/platform/exported/web_runtime_features.cc
[modify] https://crrev.com/14d350d474272ad31b29d5b4897c9b1deba2ff52/third_party/blink/renderer/platform/runtime_enabled_features.json5

bugdro… via monorail

unread,
Oct 17, 2018, 12:52:17 AM10/17/18
to modul...@chromium.org

Comment #13 on issue 773713 by bugd...@chromium.org: Implement `import.meta.url`
https://bugs.chromium.org/p/chromium/issues/detail?id=773713#c13


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src.git/+/d3888464b0adb2e905a60d50041ab2639c47971b

commit d3888464b0adb2e905a60d50041ab2639c47971b
Author: Hiroki Nakagawa <nhi...@chromium.org>
Date: Wed Oct 17 04:51:24 2018

ES Modules: Remove unnecessary flags for ES Modules

This CL removes unnecessary flags and descriptions for import.meta and
dynamic import.

- import.meta was shipped in M64:
https://www.chromestatus.com/feature/5637509807603712
- dynamic import was shipped in M63:
https://www.chromestatus.com/feature/5684934484164608

Bonus: This change stops running duplicate virtual tests for import.meta.

Bug: 711706, 773713
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If4de7343f0c5d6b449e50804de6254eb9cc191d0
Reviewed-on: https://chromium-review.googlesource.com/c/1285493
Reviewed-by: Kent Tamura <tk...@chromium.org>
Reviewed-by: Kouhei Ueno <kou...@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhi...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600279}
[modify] https://crrev.com/d3888464b0adb2e905a60d50041ab2639c47971b/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/d3888464b0adb2e905a60d50041ab2639c47971b/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/d3888464b0adb2e905a60d50041ab2639c47971b/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
[modify] https://crrev.com/d3888464b0adb2e905a60d50041ab2639c47971b/third_party/WebKit/LayoutTests/VirtualTestSuites
[delete] https://crrev.com/2a94e36850459037c558613bc5292047567ccdf4/third_party/WebKit/LayoutTests/virtual/import-meta-url/external/wpt/html/semantics/scripting-1/the-script-element/module/import-meta/README.txt
[modify] https://crrev.com/d3888464b0adb2e905a60d50041ab2639c47971b/third_party/blink/public/platform/web_runtime_features.h
Reply all
Reply to author
Forward
0 new messages