Remove ScriptModule::Status()/ErrorCompletion() [chromium/src : master]
Hiroshige Hayashizaki (Gerrit)
PTAL.
This CL also removes test expectations using GetStatus(). Do the changes look safe?
Georg, this is a follow-up of https://chromium-review.googlesource.com/c/chromium/src/+/698467 to allow V8 code to remove GetStatus() and GetException().
Does this CL remove things sufficiently for that purpose?
To view, visit change 802465. To unsubscribe, or for help writing mail filters, visit settings.
Hiroki Nakagawa (Gerrit)
LGTM
Patch set 1:Code-Review +1
1 comment:
File third_party/WebKit/Source/core/dom/ScriptModuleResolverImplTest.cpp:
Patch Set #1, Line 81:
bool has_parse_error = false) {Who uses the 3rd argument? Looks like there are no changes in the callers of this function.
To view, visit change 802465. To unsubscribe, or for help writing mail filters, visit settings.
Kouhei Ueno (Gerrit)
To view, visit change 802465. To unsubscribe, or for help writing mail filters, visit settings.
Hiroshige Hayashizaki (Gerrit)
1 comment:
Patch Set #1, Line 81:
bool has_parse_error = false) {Who uses the 3rd argument? Looks like there are no changes in the callers of this function.
Nice point.
kouhei@, do you know any context? Are there any plan to add tests to use parse-error module scripts?(Perhaps I'll land this anyway and cleanup the code around this in a separate CL)
To view, visit change 802465. To unsubscribe, or for help writing mail filters, visit settings.
Hiroshige Hayashizaki (Gerrit)
Hiroshige Hayashizaki uploaded patch set #3 to this change.
Remove ScriptModule::Status()/ErrorCompletion()
They should be no longer used in Blink, as the spec update
https://github.com/whatwg/html/pull/2991
removes the references them from the HTML spec.
Bug: 763597
Change-Id: I515b12a36a8e6f97b72ef6695a05da2f89ecfa8e
---
M third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp
M third_party/WebKit/Source/bindings/core/v8/ScriptModule.h
M third_party/WebKit/Source/bindings/core/v8/ScriptModuleTest.cpp
M third_party/WebKit/Source/core/dom/ScriptModuleResolverImplTest.cpp
4 files changed, 4 insertions(+), 60 deletions(-)
To view, visit change 802465. To unsubscribe, or for help writing mail filters, visit settings.
Hiroshige Hayashizaki (Gerrit)
Patch set 3:Commit-Queue +2
Commit Bot (Gerrit)
CQ is trying the patch.
Note: The patchset sent to CQ was uploaded after this CL was approved.
"Edit commit message" https://chromium-review.googlesource.com/c/802465/3
Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/802465/3
Bot data: {"action": "start", "triggered_at": "2017-12-20T02:34:38.0Z", "cq_cfg_revision": "449ceedce2207329148e0a132f0c79a46cde3381", "revision": "32066c83f1aa609fe230f656a0549c679003c061"}
Commit Bot (Gerrit)
Commit Bot merged this change.
Remove ScriptModule::Status()/ErrorCompletion()
They should be no longer used in Blink, as the spec update
https://github.com/whatwg/html/pull/2991
removes the references them from the HTML spec.
Bug: 763597
Change-Id: I515b12a36a8e6f97b72ef6695a05da2f89ecfa8e
Reviewed-on: https://chromium-review.googlesource.com/802465
Commit-Queue: Hiroshige Hayashizaki <hiro...@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhi...@chromium.org>
Reviewed-by: Kouhei Ueno <kou...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525235}
---
M third_party/WebKit/Source/bindings/core/v8/ScriptModule.cpp
M third_party/WebKit/Source/bindings/core/v8/ScriptModule.h
M third_party/WebKit/Source/bindings/core/v8/ScriptModuleTest.cpp
M third_party/WebKit/Source/core/dom/ScriptModuleResolverImplTest.cpp
4 files changed, 4 insertions(+), 60 deletions(-)