Issue 754930 in chromium: Profiles don't include samples from inline modules

2 views
Skip to first unread message

ad… via monorail

unread,
Aug 11, 2017, 9:08:57 PM8/11/17
to modul...@chromium.org
Updates:
Cc: modul...@chromium.org ne...@chromium.org ad...@chromium.org
Owner: kozyatin...@chromium.org
Status: Assigned

Comment #1 on issue 754930 by ad...@chromium.org: Profiles don't include samples from inline modules
https://bugs.chromium.org/p/chromium/issues/detail?id=754930#c1

Alexey, can you take a look?

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment.

justinfa… via monorail

unread,
Aug 12, 2017, 2:13:51 AM8/12/17
to modul...@chromium.org

Comment #2 on issue 754930 by justin...@google.com: Profiles don't include samples from inline modules
https://bugs.chromium.org/p/chromium/issues/detail?id=754930#c2

Sorry, I got the association with inline modules wrong, the problem occurs still with external modules. The real issue is that samples aren't shown for code that executes in the first event loop for a script. Wrap the example in the jsbin in a setTimeout or microtask, and samples are visible.

n… via monorail

unread,
Aug 13, 2017, 8:55:25 AM8/13/17
to modul...@chromium.org
Updates:
Cc: ma...@chromium.org

Comment #3 on issue 754930 by ne...@chromium.org: Profiles don't include samples from inline modules
https://bugs.chromium.org/p/chromium/issues/detail?id=754930#c3

+marja who's started doing some modules benchmarking recently.

k… via monorail

unread,
Nov 15, 2017, 8:38:17 PM11/15/17
to modul...@chromium.org
Updates:
Mergedinto: 721888
Status: Duplicate

Comment #5 on issue 754930 by ko...@chromium.org: Profiles don't include samples from inline modules
https://bugs.chromium.org/p/chromium/issues/detail?id=754930#c5

I believe that @alph is about to fix this one.
Reply all
Reply to author
Forward
0 new messages