[import.meta.url] Implement import.meta.url behind flag (Blink-side) [chromium/src : master]
0 views
Skip to first unread message
Hiroshige Hayashizaki (Gerrit)
Oct 18, 2017, 8:13:35 PM10/18/17
to modul...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, dari...@chromium.org, kinuko...@chromium.org, mlamouri+wa...@chromium.org, Blink WPT Bot, John Abd-El-Malek, Kouhei Ueno, Commit Bot, chromium...@chromium.org, Rob Buis, Thiago Farina
Trying to add modul...@chromium.org
To view, visit change 726525. To unsubscribe, or for help writing mail filters, visit settings.
Hiroshige Hayashizaki (Gerrit)
Oct 18, 2017, 8:13:35 PM10/18/17
to modul...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, dari...@chromium.org, kinuko...@chromium.org, mlamouri+wa...@chromium.org, Kouhei Ueno
Hiroshige Hayashizaki has uploaded this change for review.
[import.meta.url] Implement import.meta.url behind flag (Blink-side)
This CL implements
https://html.spec.whatwg.org/#hostgetimportmetaproperties
as HostGetImportMetaProperties() in V8Initializer.cpp and Modulator,
and thus enables import.meta.url behind the flag added in
https://chromium-review.googlesource.com/c/chromium/src/+/727179.
This CL also adds a layout test, and sets up virtual test for that.
Bug: 773713
Change-Id: I1d28123f803095535ed9a0208587e1dd873376cb
---
M third_party/WebKit/LayoutTests/TestExpectations
M third_party/WebKit/LayoutTests/VirtualTestSuites
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/import-meta/import-meta-dependent.js
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/import-meta/import-meta-root.js
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/import-meta/import-meta-url.html
A third_party/WebKit/LayoutTests/virtual/import-meta-url/external/wpt/html/semantics/scripting-1/the-script-element/module/import-meta/README.txt
M third_party/WebKit/Source/bindings/core/v8/ScriptModule.h
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
M third_party/WebKit/Source/core/dom/BUILD.gn
M third_party/WebKit/Source/core/dom/Modulator.h
M third_party/WebKit/Source/core/dom/ModulatorImplBase.cpp
M third_party/WebKit/Source/core/dom/ModulatorImplBase.h
A third_party/WebKit/Source/core/dom/ModuleImportMeta.h
M third_party/WebKit/Source/core/testing/DummyModulator.cpp
M third_party/WebKit/Source/core/testing/DummyModulator.h
15 files changed, 127 insertions(+), 2 deletions(-)
Blink WPT Bot (Gerrit)
Oct 18, 2017, 8:13:36 PM10/18/17
to Hiroshige Hayashizaki, modul...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, dari...@chromium.org, kinuko...@chromium.org, mlamouri+wa...@chromium.org, John Abd-El-Malek, Kouhei Ueno, Commit Bot, chromium...@chromium.org, Rob Buis, Thiago Farina
Successfully updated WPT GitHub pull request with new revision "Rebase": https://github.com/w3c/web-platform-tests/pull/7888
Hiroshige Hayashizaki (Gerrit)
Oct 18, 2017, 8:21:57 PM10/18/17
to blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, modul...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, dari...@chromium.org, kinuko...@chromium.org, mlamouri+wa...@chromium.org, Domenic Denicola, Blink WPT Bot, John Abd-El-Malek, Kouhei Ueno, Commit Bot, chromium...@chromium.org, Rob Buis, Thiago Farina
+domenic@ for tests.
(I'll remove the workaround for Issue v8:6919 (the fix seems ready) and how-to-run comments soon before committing)
Blink WPT Bot (Gerrit)
Oct 18, 2017, 8:23:47 PM10/18/17
to Hiroshige Hayashizaki, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, modul...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, dari...@chromium.org, kinuko...@chromium.org, mlamouri+wa...@chromium.org, Domenic Denicola, John Abd-El-Malek, Kouhei Ueno, Commit Bot, chromium...@chromium.org, Rob Buis, Thiago Farina
Successfully updated WPT GitHub pull request with new revision "Rebase": https://github.com/w3c/web-platform-tests/pull/7888
To view, visit change 726525. To unsubscribe, or for help writing mail filters, visit settings.
Kouhei Ueno (Gerrit)
Oct 18, 2017, 9:14:58 PM10/18/17
to Hiroshige Hayashizaki, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, modul...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, dari...@chromium.org, kinuko...@chromium.org, mlamouri+wa...@chromium.org, Domenic Denicola, Blink WPT Bot, John Abd-El-Malek, Commit Bot, chromium...@chromium.org, Rob Buis, Thiago Farina
Patch set 10:Code-Review +1
Hiroshige Hayashizaki (Gerrit)
Oct 20, 2017, 8:03:38 PM10/20/17
to blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, modul...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, dari...@chromium.org, kinuko...@chromium.org, mlamouri+wa...@chromium.org, Kouhei Ueno, Domenic Denicola, Blink WPT Bot, John Abd-El-Malek, Commit Bot, chromium...@chromium.org, Rob Buis, Thiago Farina
Patch set 10:Commit-Queue +2
Hiroshige Hayashizaki (Gerrit)
Oct 20, 2017, 8:43:14 PM10/20/17
to blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, modul...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, dari...@chromium.org, kinuko...@chromium.org, mlamouri+wa...@chromium.org, Kouhei Ueno, Domenic Denicola, Blink WPT Bot, John Abd-El-Malek, Commit Bot, chromium...@chromium.org, Rob Buis, Thiago Farina
Hiroshige Hayashizaki removed a vote from this change.
Removed Commit-Queue+2 by Hiroshige Hayashizaki <hiro...@chromium.org>
To view, visit change 726525. To unsubscribe, or for help writing mail filters, visit settings.
Blink WPT Bot (Gerrit)
Oct 20, 2017, 8:57:20 PM10/20/17
to Hiroshige Hayashizaki, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, modul...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, dari...@chromium.org, kinuko...@chromium.org, mlamouri+wa...@chromium.org, Kouhei Ueno, Domenic Denicola, John Abd-El-Malek, Commit Bot, chromium...@chromium.org, Rob Buis, Thiago Farina
Successfully updated WPT GitHub pull request with new revision "Remove workaround from test": https://github.com/w3c/web-platform-tests/pull/7888
Hiroshige Hayashizaki (Gerrit)
Oct 23, 2017, 3:31:34 PM10/23/17
to blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, modul...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, dari...@chromium.org, kinuko...@chromium.org, mlamouri+wa...@chromium.org, Kouhei Ueno, Domenic Denicola, Blink WPT Bot, John Abd-El-Malek, Commit Bot, chromium...@chromium.org, Rob Buis, Thiago Farina
Patch set 11:Commit-Queue +2
Commit Bot (Gerrit)
Oct 23, 2017, 3:32:01 PM10/23/17
to Hiroshige Hayashizaki, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, modul...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, dari...@chromium.org, kinuko...@chromium.org, mlamouri+wa...@chromium.org, Kouhei Ueno, Domenic Denicola, Blink WPT Bot, John Abd-El-Malek, chromium...@chromium.org, Rob Buis, Thiago Farina
CQ is trying da patch.
Note: The patchset sent to CQ was uploaded after this CL was approved.
"Remove workaround from test" https://chromium-review.googlesource.com/c/726525/11
Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/726525/11
Bot data: {"action": "start", "triggered_at": "2017-10-23T19:31:31.0Z", "cq_cfg_revision": "573b6c39d3de239a70e8fa672647b63bf0bd1f89", "revision": "b96a9cee3ade8dfa65d829790d61510a35662627"}
Hiroshige Hayashizaki (Gerrit)
Oct 23, 2017, 3:33:33 PM10/23/17
to blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, modul...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, dari...@chromium.org, kinuko...@chromium.org, mlamouri+wa...@chromium.org, Kouhei Ueno, Domenic Denicola, Blink WPT Bot, John Abd-El-Malek, Commit Bot, chromium...@chromium.org, Rob Buis, Thiago Farina
Hiroshige Hayashizaki removed a vote from this change.
Removed Commit-Queue+2 by Hiroshige Hayashizaki <hiro...@chromium.org>
To view, visit change 726525. To unsubscribe, or for help writing mail filters, visit settings.
Hiroshige Hayashizaki (Gerrit)
Oct 23, 2017, 3:43:00 PM10/23/17
to blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, modul...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, dari...@chromium.org, kinuko...@chromium.org, mlamouri+wa...@chromium.org, Kouhei Ueno, Domenic Denicola, Blink WPT Bot, John Abd-El-Malek, Commit Bot, chromium...@chromium.org, Rob Buis, Thiago Farina
Patch set 12:Commit-Queue +2
Commit Bot (Gerrit)
Oct 23, 2017, 3:43:29 PM10/23/17
to Hiroshige Hayashizaki, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, modul...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, dari...@chromium.org, kinuko...@chromium.org, mlamouri+wa...@chromium.org, Kouhei Ueno, Domenic Denicola, Blink WPT Bot, John Abd-El-Malek, chromium...@chromium.org, Rob Buis, Thiago Farina
CQ is trying da patch.
Note: The patchset sent to CQ was uploaded after this CL was approved.
"Remove howtorun comments from the test" https://chromium-review.googlesource.com/c/726525/12
Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/726525/12
Bot data: {"action": "start", "triggered_at": "2017-10-23T19:42:57.0Z", "cq_cfg_revision": "573b6c39d3de239a70e8fa672647b63bf0bd1f89", "revision": "937f90f164f8e74fa3b6b3526edf21ff65133e52"}
Blink WPT Bot (Gerrit)
Oct 23, 2017, 3:45:33 PM10/23/17
to Hiroshige Hayashizaki, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, modul...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, dari...@chromium.org, kinuko...@chromium.org, mlamouri+wa...@chromium.org, Kouhei Ueno, Domenic Denicola, John Abd-El-Malek, Commit Bot, chromium...@chromium.org, Rob Buis, Thiago Farina
Successfully updated WPT GitHub pull request with new revision "Remove howtorun comments from the test": https://github.com/w3c/web-platform-tests/pull/7888
Commit Bot (Gerrit)
Oct 23, 2017, 5:00:36 PM10/23/17
to Hiroshige Hayashizaki, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, modul...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, dari...@chromium.org, kinuko...@chromium.org, mlamouri+wa...@chromium.org, Kouhei Ueno, Domenic Denicola, Blink WPT Bot, John Abd-El-Malek, chromium...@chromium.org, Rob Buis, Thiago Farina
Try jobs failed on following builders:
linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/571282)
Hiroshige Hayashizaki (Gerrit)
Oct 23, 2017, 7:27:21 PM10/23/17
to blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, modul...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, dari...@chromium.org, kinuko...@chromium.org, mlamouri+wa...@chromium.org, Kouhei Ueno, Domenic Denicola, Blink WPT Bot, John Abd-El-Malek, Commit Bot, chromium...@chromium.org, Rob Buis, Thiago Farina
Commit Bot (Gerrit)
Oct 23, 2017, 7:27:31 PM10/23/17
to Hiroshige Hayashizaki, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, modul...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, dari...@chromium.org, kinuko...@chromium.org, mlamouri+wa...@chromium.org, Kouhei Ueno, Domenic Denicola, Blink WPT Bot, John Abd-El-Malek, chromium...@chromium.org, Rob Buis, Thiago Farina
CQ is trying da patch.
Note: The patchset sent to CQ was uploaded after this CL was approved.
"Remove howtorun comments from the test" https://chromium-review.googlesource.com/c/726525/12
Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/726525/12
Bot data: {"action": "start", "triggered_at": "2017-10-23T23:27:18.0Z", "cq_cfg_revision": "573b6c39d3de239a70e8fa672647b63bf0bd1f89", "revision": "937f90f164f8e74fa3b6b3526edf21ff65133e52"}
To view, visit change 726525. To unsubscribe, or for help writing mail filters, visit settings.
Hiroshige Hayashizaki (Gerrit)
Oct 23, 2017, 7:28:26 PM10/23/17
to blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, modul...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, dari...@chromium.org, kinuko...@chromium.org, mlamouri+wa...@chromium.org, Kouhei Ueno, Domenic Denicola, Blink WPT Bot, John Abd-El-Malek, Commit Bot, chromium...@chromium.org, Rob Buis, Thiago Farina
Trying to land, as neis@'s v8-side fix has been just landed:
https://chromium-review.googlesource.com/c/chromium/src/+/734221
Commit Bot (Gerrit)
Oct 23, 2017, 9:23:46 PM10/23/17
to Hiroshige Hayashizaki, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, modul...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, dari...@chromium.org, kinuko...@chromium.org, mlamouri+wa...@chromium.org, Kouhei Ueno, Domenic Denicola, Blink WPT Bot, John Abd-El-Malek, chromium...@chromium.org, Rob Buis, Thiago Farina
Commit Bot merged this change.
Approvals:
Kouhei Ueno: Looks good to me
Hiroshige Hayashizaki: Commit
[import.meta.url] Implement import.meta.url behind flag (Blink-side)
This CL implements
https://html.spec.whatwg.org/#hostgetimportmetaproperties
as HostGetImportMetaProperties() in V8Initializer.cpp and Modulator,
and thus enables import.meta.url behind the flag added in
https://chromium-review.googlesource.com/c/chromium/src/+/727179.
This CL also adds a layout test, and sets up virtual test for that.
Bug: 773713
Change-Id: I1d28123f803095535ed9a0208587e1dd873376cb
Reviewed-on: https://chromium-review.googlesource.com/726525
Commit-Queue: Hiroshige Hayashizaki <hiro...@chromium.org>
Reviewed-by: Kouhei Ueno <kou...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510988}
---
M third_party/WebKit/LayoutTests/TestExpectations
M third_party/WebKit/LayoutTests/VirtualTestSuites
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/import-meta/import-meta-dependent.js
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/import-meta/import-meta-root.js
A third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/import-meta/import-meta-url.html
A third_party/WebKit/LayoutTests/virtual/import-meta-url/external/wpt/html/semantics/scripting-1/the-script-element/module/import-meta/README.txt
M third_party/WebKit/Source/bindings/core/v8/ScriptModule.h
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
M third_party/WebKit/Source/core/dom/BUILD.gn
M third_party/WebKit/Source/core/dom/Modulator.h
M third_party/WebKit/Source/core/dom/ModulatorImplBase.cpp
M third_party/WebKit/Source/core/dom/ModulatorImplBase.h
A third_party/WebKit/Source/core/dom/ModuleImportMeta.h
M third_party/WebKit/Source/core/testing/DummyModulator.cpp
M third_party/WebKit/Source/core/testing/DummyModulator.h
15 files changed, 120 insertions(+), 2 deletions(-)
Blink WPT Bot (Gerrit)
Oct 23, 2017, 9:42:09 PM10/23/17
to Hiroshige Hayashizaki, Commit Bot, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, modul...@chromium.org, asvitki...@chromium.org, blink-re...@chromium.org, dari...@chromium.org, kinuko...@chromium.org, mlamouri+wa...@chromium.org, Kouhei Ueno, Domenic Denicola, John Abd-El-Malek, chromium...@chromium.org, Rob Buis, Thiago Farina
The WPT PR for this CL has been merged upstream! https://github.com/w3c/web-platform-tests/pull/7888
Reply all
Reply to author
Forward
0 new messages