Issue 773713 in chromium: Implement `import.meta`

gsat… via monorail

unread,

Oct 11, 2017, 11:43:05 AM10/11/17

to modul...@chromium.org

Status: Available
Owner: ----
CC: kou...@chromium.org, kenji...@chromium.org, hirosh...@chromium.org, modul...@chromium.org
Components: Blink>HTML>Script

New issue 773713 by gsat...@chromium.org: Implement `import.meta`
https://bugs.chromium.org/p/chromium/issues/detail?id=773713

V8 changes have been implemented:
https://bugs.chromium.org/p/v8/issues/detail?id=6693

Spec:
https://github.com/tc39/proposal-import-meta/blob/master/HTML%20Integration.md

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment.

kou… via monorail

unread,

Oct 11, 2017, 7:25:22 PM10/11/17

to modul...@chromium.org

Updates:
Owner: hirosh...@chromium.org
Status: Assigned

Comment #2 on issue 773713 by kou...@chromium.org: Implement `import.meta`
https://bugs.chromium.org/p/chromium/issues/detail?id=773713#c2

hiroshige@ and/or kouhei@ will implement import.meta.url, aiming for Q4.

hirosh… via monorail

unread,

Oct 18, 2017, 1:40:18 PM10/18/17

to modul...@chromium.org

Updates:
Status: Started

Comment #3 on issue 773713 by hirosh...@chromium.org: Implement `import.meta`
https://bugs.chromium.org/p/chromium/issues/detail?id=773713#c3

(No comment was entered for this change.)

hirosh… via monorail

unread,

Oct 18, 2017, 7:45:43 PM10/18/17

to modul...@chromium.org

Updates:
Blockedon: v8:6919

Comment #4 on issue 773713 by hirosh...@chromium.org: Implement `import.meta`
https://bugs.chromium.org/p/chromium/issues/detail?id=773713#c4

bugdro… via monorail

unread,

Oct 20, 2017, 1:05:46 AM10/20/17

to modul...@chromium.org

bugdro… via monorail

unread,

Oct 20, 2017, 5:45:20 PM10/20/17

to modul...@chromium.org

Comment #6 on issue 773713 by bugd...@chromium.org: Implement `import.meta`
https://bugs.chromium.org/p/chromium/issues/detail?id=773713#c6

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/7791ce1e80331951c59688828e19d2e0105657b7

commit 7791ce1e80331951c59688828e19d2e0105657b7
Author: Hiroshige Hayashizaki <hiro...@chromium.org>
Date: Fri Oct 20 21:05:26 2017

Introduce ScriptModuleResolver::GetHostDefined()

Preparation for
https://chromium-review.googlesource.com/c/chromium/src/+/726525.

Bug: 773713
Change-Id: Ibef1af14982c05aee624064f504a6394d6154220
Reviewed-on: https://chromium-review.googlesource.com/727183
Commit-Queue: Hiroshige Hayashizaki <hiro...@chromium.org>
Reviewed-by: Kouhei Ueno <kou...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510559}
[modify] https://crrev.com/7791ce1e80331951c59688828e19d2e0105657b7/third_party/WebKit/Source/bindings/core/v8/ScriptModuleTest.cpp
[modify] https://crrev.com/7791ce1e80331951c59688828e19d2e0105657b7/third_party/WebKit/Source/core/dom/ModuleMapTest.cpp
[modify] https://crrev.com/7791ce1e80331951c59688828e19d2e0105657b7/third_party/WebKit/Source/core/dom/ScriptModuleResolver.h
[modify] https://crrev.com/7791ce1e80331951c59688828e19d2e0105657b7/third_party/WebKit/Source/core/dom/ScriptModuleResolverImpl.cpp
[modify] https://crrev.com/7791ce1e80331951c59688828e19d2e0105657b7/third_party/WebKit/Source/core/dom/ScriptModuleResolverImpl.h
[modify] https://crrev.com/7791ce1e80331951c59688828e19d2e0105657b7/third_party/WebKit/Source/core/testing/DummyModulator.cpp

bugdro… via monorail

unread,

Oct 23, 2017, 9:24:38 PM10/23/17

to modul...@chromium.org

Comment #7 on issue 773713 by bugd...@chromium.org: Implement `import.meta`
https://bugs.chromium.org/p/chromium/issues/detail?id=773713#c7

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/03ab3c4833605018d8bd5c2cd5efb94434450407

commit 03ab3c4833605018d8bd5c2cd5efb94434450407
Author: Hiroshige Hayashizaki <hiro...@chromium.org>
Date: Tue Oct 24 01:23:39 2017

[import.meta.url] Implement import.meta.url behind flag (Blink-side)

This CL implements
https://html.spec.whatwg.org/#hostgetimportmetaproperties
as HostGetImportMetaProperties() in V8Initializer.cpp and Modulator,
and thus enables import.meta.url behind the flag added in
https://chromium-review.googlesource.com/c/chromium/src/+/727179.

This CL also adds a layout test, and sets up virtual test for that.

Bug: 773713
Change-Id: I1d28123f803095535ed9a0208587e1dd873376cb
Reviewed-on: https://chromium-review.googlesource.com/726525

Commit-Queue: Hiroshige Hayashizaki <hiro...@chromium.org>
Reviewed-by: Kouhei Ueno <kou...@chromium.org>

bugdro… via monorail

unread,

Oct 26, 2017, 9:19:18 PM10/26/17

to modul...@chromium.org

Comment #8 on issue 773713 by bugd...@chromium.org: Implement `import.meta`
https://bugs.chromium.org/p/chromium/issues/detail?id=773713#c8

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/3031e55cb00232d14ecce2302345c97085f85fc9

commit 3031e55cb00232d14ecce2302345c97085f85fc9
Author: Hiroshige Hayashizaki <hiro...@chromium.org>
Date: Fri Oct 27 01:18:08 2017

[import.meta.url] Enable import.meta.url by default

Intent-to-ship thread w/ 3 lgtms:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/Hq3cVNto74c/x7tNhmZUBQAJ

Bug: 773713
Change-Id: Iba1d2e287264c27451af5a823891004882c95b41
Reviewed-on: https://chromium-review.googlesource.com/740089
Reviewed-by: Kinuko Yasuda <kin...@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiro...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512050}
[modify] https://crrev.com/3031e55cb00232d14ecce2302345c97085f85fc9/content/public/common/content_features.cc

bugdro… via monorail

unread,

Dec 22, 2017, 2:49:00 AM12/22/17

to modul...@chromium.org

Comment #9 on issue 773713 by bugd...@chromium.org: Implement `import.meta`
https://bugs.chromium.org/p/chromium/issues/detail?id=773713#c9

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/2ff0a9383fb2be7c694408a6e30cf5b3aade8292

commit 2ff0a9383fb2be7c694408a6e30cf5b3aade8292
Author: Kouhei Ueno <kou...@chromium.org>
Date: Fri Dec 22 07:48:42 2017

[ES6 modules] mark import.meta wpt as pass

import.meta has already shipped.

Bug: 773713
Change-Id: I031542ad09e1608eba768896a8198f8226bd5e38
Reviewed-on: https://chromium-review.googlesource.com/842562
Commit-Queue: Kouhei Ueno <kou...@chromium.org>
Commit-Queue: Kinuko Yasuda <kin...@chromium.org>
Reviewed-by: Kinuko Yasuda <kin...@chromium.org>
Reviewed-by: Yutaka Hirano <yhi...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525954}
[modify] https://crrev.com/2ff0a9383fb2be7c694408a6e30cf5b3aade8292/third_party/WebKit/LayoutTests/TestExpectations

phist… via monorail

unread,

Dec 22, 2017, 6:43:27 PM12/22/17

to modul...@chromium.org

Comment #10 on issue 773713 by phis...@gmail.com: Implement `import.meta`
https://bugs.chromium.org/p/chromium/issues/detail?id=773713#c10

Can this bug be marked as fixed?

Reply all

Reply to author

Forward