Issue 771486 in chromium: Blink should have corresponding class to spec "#concept-script-fetch-options"

kou… via monorail

unread,

Oct 4, 2017, 12:53:34 AM10/4/17

to modul...@chromium.org

Status: Assigned
Owner: kou...@chromium.org
CC: modul...@chromium.org
Components: Blink>HTML>Script

New issue 771486 by kou...@chromium.org: Blink should have corresponding class to spec "#concept-script-fetch-options"
https://bugs.chromium.org/p/chromium/issues/detail?id=771486

#concept-script-fetch-options was introduced in html spec commit:
https://github.com/whatwg/html/commit/9275d955dcd604e959cfcc672e0c234b1b8c00db

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment.

kou… via monorail

unread,

Oct 4, 2017, 12:54:26 AM10/4/17

to modul...@chromium.org

Issue 771486: Blink should have corresponding class to spec "#concept-script-fetch-options"
https://bugs.chromium.org/p/chromium/issues/detail?id=771486

This issue is now blocking issue 766139.
See https://bugs.chromium.org/p/chromium/issues/detail?id=766139

bugdro… via monorail

unread,

Oct 13, 2017, 3:02:50 AM10/13/17

to modul...@chromium.org

bugdro… via monorail

unread,

Oct 15, 2017, 8:01:16 PM10/15/17

to modul...@chromium.org

Comment #3 on issue 771486 by bugd...@chromium.org: Blink should have corresponding class to spec "#concept-script-fetch-options"
https://bugs.chromium.org/p/chromium/issues/detail?id=771486#c3

The following revision refers to this bug:

bugdro… via monorail

unread,

Oct 15, 2017, 11:50:02 PM10/15/17

to modul...@chromium.org

Comment #4 on issue 771486 by bugd...@chromium.org: Blink should have corresponding class to spec "#concept-script-fetch-options"
https://bugs.chromium.org/p/chromium/issues/detail?id=771486#c4

The following revision refers to this bug:

hirosh… via monorail

unread,

Oct 25, 2017, 2:10:29 PM10/25/17

to modul...@chromium.org

Issue 771486: Blink should have corresponding class to spec "#concept-script-fetch-options"
https://bugs.chromium.org/p/chromium/issues/detail?id=771486

This issue is now blocking issue 772100.
See https://bugs.chromium.org/p/chromium/issues/detail?id=772100

kou… via monorail

unread,

Oct 27, 2017, 2:30:27 AM10/27/17

to modul...@chromium.org

Updates:
Owner: hirosh...@chromium.org

Comment #6 on issue 771486 by kou...@chromium.org: Blink should have corresponding class to spec "#concept-script-fetch-options"
https://bugs.chromium.org/p/chromium/issues/detail?id=771486#c6

hiroshige is now driving this effort.

bugdro… via monorail

unread,

Oct 27, 2017, 2:01:09 PM10/27/17

to modul...@chromium.org

Comment #7 on issue 771486 by bugd...@chromium.org: Blink should have corresponding class to spec "#concept-script-fetch-options"
https://bugs.chromium.org/p/chromium/issues/detail?id=771486#c7

The following revision refers to this bug:

bugdro… via monorail

unread,

Oct 27, 2017, 5:01:01 PM10/27/17

to modul...@chromium.org

Comment #8 on issue 771486 by bugd...@chromium.org: Blink should have corresponding class to spec "#concept-script-fetch-options"
https://bugs.chromium.org/p/chromium/issues/detail?id=771486#c8

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/859a3de4c564c8a8f6a77704df510d325fe4d57e

commit 859a3de4c564c8a8f6a77704df510d325fe4d57e
Author: Hiroshige Hayashizaki <hiro...@chromium.org>
Date: Fri Oct 27 21:00:31 2017

Centralize ClassicPendingScript::CreateInline() call sites

This merges all ClassicPendingScript::CreateInline() call sites
into one in ScriptLoader::PrepareScript().
This
- reduces code duplication,
- makes PendingScript always created before the last step of
ScriptLoader::PrepareScript() and makes TakePrepareScript()
always called, and
- prepares for
https://chromium-review.googlesource.com/c/chromium/src/+/736876.

Behavior changes: This CL resets line numbering for nested writes
for classic inline scripts controlled by {HTML,XML}ParserScriptRunner.
Previously, the line numbering is reset only when the classic inline
script is executed inside PrepareScript().

Bug: 771486, 777612, 686281
Change-Id: Ibcaf9bcfa958bb302b1d7f5b7f17c501a7ac7027
Reviewed-on: https://chromium-review.googlesource.com/737055
Commit-Queue: Hiroshige Hayashizaki <hiro...@chromium.org>
Reviewed-by: Jeremy Roman <jbr...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512269}
[modify] https://crrev.com/859a3de4c564c8a8f6a77704df510d325fe4d57e/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
[modify] https://crrev.com/859a3de4c564c8a8f6a77704df510d325fe4d57e/third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp
[modify] https://crrev.com/859a3de4c564c8a8f6a77704df510d325fe4d57e/third_party/WebKit/Source/core/xml/parser/XMLParserScriptRunner.cpp

bugdro… via monorail

unread,

Oct 27, 2017, 5:06:33 PM10/27/17

to modul...@chromium.org

Comment #9 on issue 771486 by bugd...@chromium.org: Blink should have corresponding class to spec "#concept-script-fetch-options"
https://bugs.chromium.org/p/chromium/issues/detail?id=771486#c9

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/6b8a2c56c3d59789f2d956972324986842653dcc

commit 6b8a2c56c3d59789f2d956972324986842653dcc
Author: Hiroshige Hayashizaki <hiro...@chromium.org>
Date: Fri Oct 27 21:04:55 2017

Make ScriptFetchOptions members const

Bug: 771486
Change-Id: I95c48b91719adedb1e35c0d77186c20f249a93cc
Reviewed-on: https://chromium-review.googlesource.com/737522
Commit-Queue: Hiroshige Hayashizaki <hiro...@chromium.org>
Reviewed-by: Yutaka Hirano <yhi...@chromium.org>
Reviewed-by: Kouhei Ueno <kou...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512276}
[modify] https://crrev.com/6b8a2c56c3d59789f2d956972324986842653dcc/third_party/WebKit/Source/core/dom/ModuleMapTest.cpp
[modify] https://crrev.com/6b8a2c56c3d59789f2d956972324986842653dcc/third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoader.cpp
[modify] https://crrev.com/6b8a2c56c3d59789f2d956972324986842653dcc/third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoader.h
[modify] https://crrev.com/6b8a2c56c3d59789f2d956972324986842653dcc/third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoaderRegistry.cpp
[modify] https://crrev.com/6b8a2c56c3d59789f2d956972324986842653dcc/third_party/WebKit/Source/platform/loader/fetch/ScriptFetchOptions.h

bugdro… via monorail

unread,

Oct 30, 2017, 3:36:58 PM10/30/17

to modul...@chromium.org

Comment #10 on issue 771486 by bugd...@chromium.org: Blink should have corresponding class to spec "#concept-script-fetch-options"
https://bugs.chromium.org/p/chromium/issues/detail?id=771486#c10

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/54b14236c966a766c1ca29e754b975e14925f268

commit 54b14236c966a766c1ca29e754b975e14925f268
Author: Hiroshige Hayashizaki <hiro...@chromium.org>
Date: Mon Oct 30 19:32:35 2017

Make ScriptLoader::FetchClassicScript() to take ScriptFetchOptions

Bug: 771486
Change-Id: Ic9c98da7001ea320ee7bcd8ab7f92e90ce171b0a
Reviewed-on: https://chromium-review.googlesource.com/734318
Commit-Queue: Hiroshige Hayashizaki <hiro...@chromium.org>
Reviewed-by: Takeshi Yoshino <tyos...@chromium.org>
Reviewed-by: Kouhei Ueno <kou...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512577}
[modify] https://crrev.com/54b14236c966a766c1ca29e754b975e14925f268/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
[modify] https://crrev.com/54b14236c966a766c1ca29e754b975e14925f268/third_party/WebKit/Source/core/dom/ScriptLoader.h

bugdro… via monorail

unread,

Oct 30, 2017, 7:58:48 PM10/30/17

to modul...@chromium.org

Comment #11 on issue 771486 by bugd...@chromium.org: Blink should have corresponding class to spec "#concept-script-fetch-options"
https://bugs.chromium.org/p/chromium/issues/detail?id=771486#c11

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/3ed2ac1f367747a8139d0c57c8c1a3574916ee56

commit 3ed2ac1f367747a8139d0c57c8c1a3574916ee56
Author: Hiroshige Hayashizaki <hiro...@chromium.org>
Date: Mon Oct 30 23:57:09 2017

Plumb ScriptFetchOptions to ClassicPendingScript

This CL plumbs ScriptFetchOptions from ScriptLoader::PrepareScript()
to ClassicPendingScript::options_ to ClassicScript, instead of
reconstructing in ClassicPendingScript::GetSource().

Thus this CL removes ScriptLoader::nonce_.

Bug: 771486
Change-Id: I3b74da2e65176ae0c04068abba05413b675a28b0
Reviewed-on: https://chromium-review.googlesource.com/736876
Commit-Queue: Hiroshige Hayashizaki <hiro...@chromium.org>

Reviewed-by: Kouhei Ueno <kou...@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhi...@chromium.org>

Cr-Commit-Position: refs/heads/master@{#512680}
[modify] https://crrev.com/3ed2ac1f367747a8139d0c57c8c1a3574916ee56/third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp
[modify] https://crrev.com/3ed2ac1f367747a8139d0c57c8c1a3574916ee56/third_party/WebKit/Source/core/dom/ClassicPendingScript.h
[modify] https://crrev.com/3ed2ac1f367747a8139d0c57c8c1a3574916ee56/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
[modify] https://crrev.com/3ed2ac1f367747a8139d0c57c8c1a3574916ee56/third_party/WebKit/Source/core/dom/ScriptLoader.h

bugdro… via monorail

unread,

Oct 30, 2017, 8:15:15 PM10/30/17

to modul...@chromium.org

Comment #12 on issue 771486 by bugd...@chromium.org: Blink should have corresponding class to spec "#concept-script-fetch-options"
https://bugs.chromium.org/p/chromium/issues/detail?id=771486#c12

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/17090875f3106056a0d1cb897066ead3573c03f8

commit 17090875f3106056a0d1cb897066ead3573c03f8
Author: Hiroshige Hayashizaki <hiro...@chromium.org>
Date: Tue Oct 31 00:13:40 2017

Add IntegrityMetadataSet to ScriptFetchOptions

This CL
- introduces integrity-related members to ScriptFetchOptions,
- sets them in PrepareScript(), WorkletGlobalScope.cpp and
DynamicModuleResolver.cpp as specced, and
- uses them for classic scripts, in ClassicPendingScript::Fetch().

For module scripts, the integrity-related members are not used,
and are sometimes set incorrectly.
This will be fixed in a subsequent CL.

Bug: 771486, 772100
Change-Id: I0983bc6ad02b73472d67bf1b2ce169d2d71c5be3
Reviewed-on: https://chromium-review.googlesource.com/736721

Commit-Queue: Hiroshige Hayashizaki <hiro...@chromium.org>
Reviewed-by: Kouhei Ueno <kou...@chromium.org>

Reviewed-by: Yutaka Hirano <yhi...@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhi...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512685}
[modify] https://crrev.com/17090875f3106056a0d1cb897066ead3573c03f8/third_party/WebKit/Source/core/dom/ClassicPendingScript.cpp
[modify] https://crrev.com/17090875f3106056a0d1cb897066ead3573c03f8/third_party/WebKit/Source/core/dom/ClassicPendingScript.h
[modify] https://crrev.com/17090875f3106056a0d1cb897066ead3573c03f8/third_party/WebKit/Source/core/dom/DynamicModuleResolver.cpp
[modify] https://crrev.com/17090875f3106056a0d1cb897066ead3573c03f8/third_party/WebKit/Source/core/dom/ScriptLoader.cpp
[modify] https://crrev.com/17090875f3106056a0d1cb897066ead3573c03f8/third_party/WebKit/Source/core/dom/ScriptLoader.h
[modify] https://crrev.com/17090875f3106056a0d1cb897066ead3573c03f8/third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp
[modify] https://crrev.com/17090875f3106056a0d1cb897066ead3573c03f8/third_party/WebKit/Source/platform/loader/fetch/ScriptFetchOptions.h

bugdro… via monorail

unread,

Oct 30, 2017, 9:52:09 PM10/30/17

to modul...@chromium.org

Comment #13 on issue 771486 by bugd...@chromium.org: Blink should have corresponding class to spec "#concept-script-fetch-options"
https://bugs.chromium.org/p/chromium/issues/detail?id=771486#c13

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/214d16835a233ef1e01bcf54412803cc3593ce8e

commit 214d16835a233ef1e01bcf54412803cc3593ce8e
Author: Hiroshige Hayashizaki <hiro...@chromium.org>
Date: Tue Oct 31 01:50:26 2017

Support integrity attribute for module scripts

This CL enables subresource integrity check for module scripts, by
- Clearing ScriptFetchOptions' integrity for descendant module
scripts in ModuleTreeLinker.cpp, as specced,
- Setting FetchParameters' integrity according to ScriptFetchOptions
in ModuleScriptLoader::Fetch(), and
- Checking the integrity check result in WasModuleLoadSuccessful()
and reports console messages if any.
For this, SubresourceIntegrityHelper::GetConsoleMessages() is
introduced.

Bug: 771486, 772100
Change-Id: I3f01fd018dad625de9440fe4ab7e1d9ee7feb5ab
Reviewed-on: https://chromium-review.googlesource.com/738221

Commit-Queue: Hiroshige Hayashizaki <hiro...@chromium.org>
Reviewed-by: Kouhei Ueno <kou...@chromium.org>

Reviewed-by: Hiroki Nakagawa <nhi...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512705}
[delete] https://crrev.com/c7cb3e9057a8420d0f54db86dc581bc33b94e4c9/third_party/WebKit/LayoutTests/external/wpt/html/semantics/scripting-1/the-script-element/module/integrity-expected.txt
[modify] https://crrev.com/214d16835a233ef1e01bcf54412803cc3593ce8e/third_party/WebKit/Source/core/loader/SubresourceIntegrityHelper.cpp
[modify] https://crrev.com/214d16835a233ef1e01bcf54412803cc3593ce8e/third_party/WebKit/Source/core/loader/SubresourceIntegrityHelper.h
[modify] https://crrev.com/214d16835a233ef1e01bcf54412803cc3593ce8e/third_party/WebKit/Source/core/loader/modulescript/DocumentModuleScriptFetcher.cpp
[modify] https://crrev.com/214d16835a233ef1e01bcf54412803cc3593ce8e/third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoader.cpp
[modify] https://crrev.com/214d16835a233ef1e01bcf54412803cc3593ce8e/third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinker.cpp

bugdro… via monorail

unread,

Nov 13, 2017, 3:13:49 PM11/13/17

to modul...@chromium.org

Comment #14 on issue 771486 by bugd...@chromium.org: Blink should have corresponding class to spec "#concept-script-fetch-options"
https://bugs.chromium.org/p/chromium/issues/detail?id=771486#c14

The following revision refers to this bug:

bugdro… via monorail

unread,

Nov 13, 2017, 10:49:45 PM11/13/17

to modul...@chromium.org

Comment #15 on issue 771486 by bugd...@chromium.org: Blink should have corresponding class to spec "#concept-script-fetch-options"
https://bugs.chromium.org/p/chromium/issues/detail?id=771486#c15

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src.git/+/2f5801db1a731e5ec631ed70fdaf8ece125ed744

commit 2f5801db1a731e5ec631ed70fdaf8ece125ed744
Author: Kouhei Ueno <kou...@chromium.org>
Date: Tue Nov 14 03:48:55 2017

javascript url: Add spec ref for ScriptFetchOptions to use

Bug: 771486
Change-Id: I05c2772a10cc0591099e61915756f22f9c9ddeda
Reviewed-on: https://chromium-review.googlesource.com/765625
Commit-Queue: Kouhei Ueno <kou...@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhi...@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiro...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516180}
[modify] https://crrev.com/2f5801db1a731e5ec631ed70fdaf8ece125ed744/third_party/WebKit/Source/bindings/core/v8/ScriptController.cpp

hirosh… via monorail

unread,

Nov 29, 2017, 9:39:08 PM11/29/17

to modul...@chromium.org

Updates:
Status: Fixed

Comment #16 on issue 771486 by hirosh...@chromium.org: Blink should have corresponding class to spec "#concept-script-fetch-options"
https://bugs.chromium.org/p/chromium/issues/detail?id=771486#c16

(No comment was entered for this change.)

Reply all

Reply to author

Forward