Moving files from core/dom to core/script

[Takayoshi Kochi]

Hi loading team & module-dev

As a part of reorganizing core/dom files, we identified some of the files are more

related to script execution or ES6 modules rather than pure DOM implementation,

and we'd like to propose creating a "core/script" directory and move files there.

The merit of having the separate directory is a clear separation of responsibility

between dom and script execution, and the ownership of script related classes

will be clarified.

Current candidates for core/script are (.h/.cpp/Test.cpp suffixes omitted)

* Script related

- AncestorList

- ClassicPendingScript

- ClassicScript

- ExecutionContext

- FunctionStringCallback

- PendingScript

- Script

- ScriptedIdleTaskController

- ScriptElementBase

- ScriptLoader

- ScriptRunner

- TaskRunnerHelper

- TaskTypeTraits

* ES6 modules related

- DocumentModulatorImpl

- Modulator

- ModulatorImplBase

- ModuleMap

- ModulePendingScript

- ModuleScript

- ScriptModuleResolver

- ScriptModuleResolverImpl

- WorkletModulatorImpl

For more background about core/dom reorganization, see spreadsheet (esp. row 111-134).

Tentative all-in-one CL is https://chromium-review.googlesource.com/c/chromium/src/+/659739 .

Any feedback is welcome.

--

Takayoshi Kochi

[Hiroshige Hayashizaki]

Most of the files are the implementation for script elements and their associated JavaScript execution specced in the HTML spec, so the semantics of placing those files in a separate directory is clear.

Exceptions are:

- FunctionStringCallback

- ScriptedIdleTaskController

These are not related to the script elements.

- ExecutionContext

- TaskRunnerHelper

- TaskTypeTraits

These look related to more broader range of things, e.g. Blink's task posting and scheduling (not necessarily JavaScript-related).

+tzik@

--
You received this message because you are subscribed to the Google Groups "module-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to module-dev+unsubscribe@chromium.org.
To post to this group, send email to modul...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/module-dev/CADP2%3Dhoac_Fe22c3%2Bj3khB%3DXCT76%2BnVvZ4uXisR-Lr_pVCOXqw%40mail.gmail.com.

[Takayoshi Kochi]

Thanks Hiroshige-san for the comment!

> - FunctionStringCallback

Good catch, it seems to be related to datatransfer (drag & drop) and not relevant to script.

> ScriptIdleTaskController

Maybe ScriptedAnimationController either?

Some other files (IdleDeadline*, IdleRequestCallback.idl, IdleRequestOptions.idl) seem more

suitable to be in core/scheduler (or any more appropriate directory) together.

tzik@, do you have any idea where these files better fit? 

- ExecutionContext

- TaskRunnerHelper

- TaskTypeTraits

--
You received this message because you are subscribed to the Google Groups "loading-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to loading-dev+unsubscribe@chromium.org.
To post to this group, send email to loadi...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/loading-dev/CAOaYce7BHjqOoSVetwwEAo7-O6rcbfkZZottUdsGoA%3D5UDDu7A%40mail.gmail.com.

--

Takayoshi Kochi

[Takayoshi Kochi]

Discussed off-list with kouhei@ and hiroshige@.

They are okay with moving files from dom to script in general, but want to get it done later as they

are doing big changes.

Regarding files to be moved, the core/script directory should be only referred from

{HTML,SVG,XML}-Script and -Parser.  Files that are not related to those

script elements and parsers should be excluded in core/script dir.

Could you check the list below if I understand the intention correct?

* Script related

- AncestorList

- ClassicPendingScript

- ClassicScript

- ExecutionContext  -> Not move

- FunctionStringCallback -> Not move

- PendingScript

- Script

- ScriptedAnimationController -> Not move

- ScriptedIdleTaskController -> Not move

- ScriptElementBase

- ScriptLoader

- ScriptRunner

- TaskRunnerHelper -> Not move

- TaskTypeTraits -> Not move

* ES6 modules related

- DocumentModulatorImpl

- Modulator

- ModulatorImplBase

- ModuleMap

- ModulePendingScript

- ModuleScript

- ScriptModuleResolver

- ScriptModuleResolverImpl

- WorkletModulatorImpl

Once big changes are done (later this year?) let me check this back  - probably files are added/removed by then.

--

Takayoshi Kochi

[Hiroshige Hayashizaki]

> Regarding files to be moved, the core/script directory should be only referred from

> {HTML,SVG,XML}-Script and -Parser.  Files that are not related to those

> script elements and parsers should be excluded in core/script dir.

core/script corresponds to the Blink implementation for the following HTML spec sections (with some delegation to bindings/core/v8/):

• 4.2.1 The script element https://html.spec.whatwg.org/#the-script-element (e.g. ScriptLoader::PrepareScript())
  
• And possibly its interaction with parsers, like: 12.2.6.4.8 The "text" insertion mode https://html.spec.whatwg.org/#scriptEndTag
• A part of 8.1 Scripting https://html.spec.whatwg.org/#scripting
• A part of 8.1.3 Processing model https://html.spec.whatwg.org/#scripting-processing-model
• 8.1.3.1 Definitions https://html.spec.whatwg.org/#definitions-2
• 8.1.3.2 Fetching scripts https://html.spec.whatwg.org/#fetching-scripts
• 8.1.3.3 Creating scripts https://html.spec.whatwg.org/#creating-scripts
• 8.1.3.4 Calling scripts https://html.spec.whatwg.org/#calling-scripts
• 8.1.3.8 Integration with the JavaScript module system https://html.spec.whatwg.org/#integration-with-the-javascript-module-system

By doing this way, I hope core/script is referenced only from HTML/SVGScriptElement and parser-related classes.

The list above does NOT contain the following parts of 8.1 Scripting (and thus the corresponding files aren't moved):

• 8.1.3.5 Realms, settings objects, and global objects
  
• ExecutionContext
• 8.1.4 Event loops
• TaskRunnerHelper, TaskTraits, ...
• 8.1.5 Events

These are used from much broader range of spec/impl.

(How about HTMLParserScriptRunner.cpp?)

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/loading-dev/CADP2%3Dho_12V2J3NccykucVgryvDn0XmTAqNaUvYHwS-U6YtZyw%40mail.gmail.com.

[Takayoshi Kochi]

Thanks Hiroshige-san.

Probably by the time we do real move, files to be moved could be added or removed,

and needs recheck then.

Let's revisit this when we are ready to go.

--

Takayoshi Kochi

[Hiroshige Hayashizaki]

Drafting a doc (with my unfinalized thoughts)

https://docs.google.com/a/chromium.org/presentation/d/1H-1U9LmCghOmviw0nYE_SP_r49-bU42SkViBn539-vg/edit?usp=sharing

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/module-dev/CADP2%3Dho08Wwhu%3D5NMefwNabhGCp0RqXWoA%3D0PSasKtZAUoV1ug%40mail.gmail.com.

[Kouhei Ueno]

The slides are amazing. You should commit this as an official README once we have core/script.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/loading-dev/CAOaYce6kXButGYiLni352qRRKZj09YP1xk5VFrxiTeM2903UUw%40mail.gmail.com.

--

kouhei

[Takayoshi Kochi]

You can have core/script right now, and populate files later?

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/module-dev/CAPVAxLX%2BEvE82cpB2wpAf5sgdpnutZ7tUbkgND1FuQTLfy_yNg%40mail.gmail.com.

--

Takayoshi Kochi

[Hiroshige Hayashizaki]

I'm planning to send a PSA to blink-dev around next week and do the actual move mid December.

Kochi-san, did you create a script to prepare your initial CL?

If so, I'd like to use it to create a moving CL.

[Takayoshi Kochi]

Hiroshige-san, I didn't do the initial CL with script, but manually moved using git mv etc., and edited .gn files etc.

Please go ahead creating a new CL ;)

Thanks!

--

Takayoshi Kochi