Introduce ScriptModuleResolver::GetHostDefined() [chromium/src : master]

Hiroshige Hayashizaki (Gerrit)

unread,

Oct 18, 2017, 7:59:03 PM10/18/17

to modul...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, Kouhei Ueno, Commit Bot, chromium...@chromium.org, Rob Buis

PTAL.

View Change

To view, visit change 727183. To unsubscribe, or for help writing mail filters, visit settings.

Kouhei Ueno (Gerrit)

unread,

Oct 18, 2017, 9:07:24 PM10/18/17

to Hiroshige Hayashizaki, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, modul...@chromium.org, Commit Bot, chromium...@chromium.org, Rob Buis

Patch set 4:Code-Review +1

View Change

To view, visit change 727183. To unsubscribe, or for help writing mail filters, visit settings.

Hiroshige Hayashizaki (Gerrit)

unread,

Oct 19, 2017, 4:18:44 PM10/19/17

to blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, modul...@chromium.org, Kouhei Ueno, Commit Bot, chromium...@chromium.org, Rob Buis

Patch set 4:Commit-Queue +2

View Change

To view, visit change 727183. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Oct 19, 2017, 4:19:32 PM10/19/17

to Hiroshige Hayashizaki, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, modul...@chromium.org, Kouhei Ueno, chromium...@chromium.org, Rob Buis

CQ full run requires all CL dependencies to be submitted first. Please, re-trigger CQ full run after these CLs are submitted:
  https://chromium-review.googlesource.com/727179

View Change

To view, visit change 727183. To unsubscribe, or for help writing mail filters, visit settings.

Hiroshige Hayashizaki (Gerrit)

unread,

Oct 20, 2017, 12:03:47 PM10/20/17

to blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, modul...@chromium.org, Kouhei Ueno, Commit Bot, chromium...@chromium.org, Rob Buis

Patch set 4:Commit-Queue +2

View Change

To view, visit change 727183. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Oct 20, 2017, 1:04:33 PM10/20/17

to Hiroshige Hayashizaki, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, modul...@chromium.org, Kouhei Ueno, chromium...@chromium.org, Rob Buis

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/522621)

View Change

To view, visit change 727183. To unsubscribe, or for help writing mail filters, visit settings.

Hiroshige Hayashizaki (Gerrit)

unread,

Oct 20, 2017, 4:44:47 PM10/20/17

to blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, modul...@chromium.org, Kouhei Ueno, Commit Bot, chromium...@chromium.org, Rob Buis

Patch set 5:Commit-Queue +2

View Change

To view, visit change 727183. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Oct 20, 2017, 4:45:01 PM10/20/17

to Hiroshige Hayashizaki, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, modul...@chromium.org, Kouhei Ueno, chromium...@chromium.org, Rob Buis

CQ is trying da patch.

Note: The patchset sent to CQ was uploaded after this CL was approved.
"Rebase" https://chromium-review.googlesource.com/c/727183/5

Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/chromium-review.googlesource.com/727183/5

Bot data: {"action": "start", "triggered_at": "2017-10-20T20:44:43.0Z", "cq_cfg_revision": "fc2b2f04ed20d88113c10951036ca403891c435f", "revision": "4390480cff8f76b9c4cd03338c30ce8d7009f455"}

View Change

To view, visit change 727183. To unsubscribe, or for help writing mail filters, visit settings.

Commit Bot (Gerrit)

unread,

Oct 20, 2017, 5:05:34 PM10/20/17

to Hiroshige Hayashizaki, blink-revie...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dglazko...@chromium.org, eae+bli...@chromium.org, hiroshig...@chromium.org, kochi+...@chromium.org, kouhei...@chromium.org, modul...@chromium.org, Kouhei Ueno, chromium...@chromium.org, Rob Buis

Commit Bot merged this change.

View Change

Approvals:
  Kouhei Ueno: Looks good to me
  Hiroshige Hayashizaki: Commit

Introduce ScriptModuleResolver::GetHostDefined()

Preparation for
https://chromium-review.googlesource.com/c/chromium/src/+/726525.

Bug: 773713
Change-Id: Ibef1af14982c05aee624064f504a6394d6154220
Reviewed-on: https://chromium-review.googlesource.com/727183
Commit-Queue: Hiroshige Hayashizaki <hiro...@chromium.org>
Reviewed-by: Kouhei Ueno <kou...@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510559}
---
M third_party/WebKit/Source/bindings/core/v8/ScriptModuleTest.cpp
M third_party/WebKit/Source/core/dom/ModuleMapTest.cpp
M third_party/WebKit/Source/core/dom/ScriptModuleResolver.h
M third_party/WebKit/Source/core/dom/ScriptModuleResolverImpl.cpp
M third_party/WebKit/Source/core/dom/ScriptModuleResolverImpl.h
M third_party/WebKit/Source/core/testing/DummyModulator.cpp
6 files changed, 29 insertions(+), 4 deletions(-)

To view, visit change 727183. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward