Issue 1489862 in chromium: Flag expired : enable-audio-focus-enforcement is expired in M120

729 views
Skip to first unread message

chrome-branch-day via monorail

unread,
Oct 5, 2023, 3:39:38 PM10/5/23
to medi...@chromium.org

Comment #1 on issue 1489862 by chrome-b...@chops-service-accounts.iam.gserviceaccount.com: Flag expired : enable-audio-focus-enforcement is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1489862#c1

This flag has been marked as expiring in M120 or earlier. This bug has been opened for the Eng teams to clean up the references for the flag in the //chrome/browser/flag-metadata.json as well as references to that flag.

This is a friendly reminder to help get this clean up completed.

If you think this flag needs to be extended beyond this milestone, please follow these steps:
- If you see a flag listed as expiring that you want to keep, create a CL updating //chrome/browser/flag-metadata.json with an appropriate new expiration milestone.
- If you do this before the M120 branch you're all set; if you do it after the M120 branch you'll need to merge that CL to the M120 branch as well.

You can check the branch date for this milestone at https://chromiumdash.appspot.com/schedule

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

mfoltz via monorail

unread,
Oct 5, 2023, 3:45:13 PM10/5/23
to medi...@chromium.org
Updates:
Components: Blink>Media>Session
Owner: ste...@chromium.org
Status: Assigned

Comment #2 on issue 1489862 by mfo...@chromium.org: Flag expired : enable-audio-focus-enforcement is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1489862#c2

MediaSession => steimel@?

steimel via monorail

unread,
Oct 5, 2023, 3:46:17 PM10/5/23
to medi...@chromium.org
Updates:
Owner: libe...@google.com

Comment #3 on issue 1489862 by ste...@chromium.org: Flag expired : enable-audio-focus-enforcement is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1489862#c3

=> liberato@ who's been working on audio focus enforcement changes on CrOS

liberato via monorail

unread,
Oct 6, 2023, 12:11:45 AM10/6/23
to medi...@chromium.org
Updates:
Labels: Pri-1

Comment #4 on issue 1489862 by libe...@google.com: Flag expired : enable-audio-focus-enforcement is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1489862#c4

thanks -- definitely don't want this to expire yet.

mfoltz via monorail

unread,
Oct 16, 2023, 12:45:06 PM10/16/23
to medi...@chromium.org

Comment #5 on issue 1489862 by mfo...@chromium.org: Flag expired : enable-audio-focus-enforcement is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1489862#c5

It's already expired in M120, which is currently in dev channel; if you want to extend it, you need to send a CL to update flag-metadata.json.

Git Watcher via monorail

unread,
Oct 16, 2023, 1:33:14 PM10/16/23
to medi...@chromium.org

Comment #6 on issue 1489862 by Git Watcher: Flag expired : enable-audio-focus-enforcement is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1489862#c6

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/f72127b3d000de6a47040c4c7a121f8e4831d787

commit f72127b3d000de6a47040c4c7a121f8e4831d787
Author: Frank Liberato <libe...@chromium.org>
Date: Mon Oct 16 17:32:39 2023

Re-enable audio-focus-enforcement in about://flags

Change-Id: If98b39a36d7d0aed2b56a86df4120dfaaeee5c6a
Bug: 1489862
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4943892
Reviewed-by: Tommy Steimel <ste...@chromium.org>
Commit-Queue: Frank Liberato <libe...@chromium.org>
Commit-Queue: Tommy Steimel <ste...@chromium.org>
Auto-Submit: Frank Liberato <libe...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1210277}

[modify] https://crrev.com/f72127b3d000de6a47040c4c7a121f8e4831d787/chrome/browser/flag-metadata.json

liberato via monorail

unread,
Oct 16, 2023, 1:49:37 PM10/16/23
to medi...@chromium.org
Updates:
Status: Fixed

Comment #7 on issue 1489862 by libe...@google.com: Flag expired : enable-audio-focus-enforcement is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1489862#c7

(No comment was entered for this change.)
Reply all
Reply to author
Forward
0 new messages