disable failing ui.* tests [chromiumos/platform/tast-tests : main]

3 vistas
Ir al primer mensaje no leído

Derek Beckett (Gerrit)

no leída,
9 ago 2022, 6:19:30 p.m.9/8/22
para Seewai Fu,medi...@chromium.org,Becca Hughes

Attention is currently required from: Seewai Fu.

Derek Beckett would like Seewai Fu to review this change.

View Change

disable failing ui.* tests

Test is below minimum pass criteria.

BUG=b:241943746
TEST=cq

Change-Id: Ie61a425068a3c56142c7b4e669f2ef469736f593
---
M src/chromiumos/tast/local/bundles/cros/ui/play_pause_chrome.go
1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/src/chromiumos/tast/local/bundles/cros/ui/play_pause_chrome.go b/src/chromiumos/tast/local/bundles/cros/ui/play_pause_chrome.go
index d9aea74..5362901 100644
--- a/src/chromiumos/tast/local/bundles/cros/ui/play_pause_chrome.go
+++ b/src/chromiumos/tast/local/bundles/cros/ui/play_pause_chrome.go
@@ -21,7 +21,8 @@
LacrosStatus: testing.LacrosVariantNeeded,
Desc: "Checks the play/pause accelerator will play/pause Chrome",
Contacts: []string{"becca...@chromium.org", "medi...@chromium.org"},
- Attr: []string{"group:mainline", "informational"},
+ // Disabled due to <1% pass rate over 30 days. See b/241943746
+ //Attr: []string{"group:mainline", "informational"},
SoftwareDeps: []string{"chrome"},
Data: []string{
"media_session_60sec_test.ogg",

To view, visit change 3821420. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromiumos/platform/tast-tests
Gerrit-Branch: main
Gerrit-Change-Id: Ie61a425068a3c56142c7b4e669f2ef469736f593
Gerrit-Change-Number: 3821420
Gerrit-PatchSet: 1
Gerrit-Owner: Derek Beckett <dbec...@chromium.org>
Gerrit-Reviewer: Seewai Fu <seew...@google.com>
Gerrit-CC: Becca Hughes <becca...@chromium.org>
Gerrit-Attention: Seewai Fu <seew...@google.com>
Gerrit-MessageType: newchange

Seewai Fu (Gerrit)

no leída,
9 ago 2022, 8:35:35 p.m.9/8/22
para Derek Beckett,medi...@chromium.org,Becca Hughes

Attention is currently required from: Derek Beckett.

Patch set 1:Code-Review +2

View Change

1 comment:

  • Patchset:

    • Patch Set #1:

      LGTM. Since unit test was not run, no chump on this CL. Please make sure it went through the CQ procress.

To view, visit change 3821420. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromiumos/platform/tast-tests
Gerrit-Branch: main
Gerrit-Change-Id: Ie61a425068a3c56142c7b4e669f2ef469736f593
Gerrit-Change-Number: 3821420
Gerrit-PatchSet: 1
Gerrit-Owner: Derek Beckett <dbec...@chromium.org>
Gerrit-Reviewer: Seewai Fu <seew...@google.com>
Gerrit-CC: Becca Hughes <becca...@chromium.org>
Gerrit-Attention: Derek Beckett <dbec...@chromium.org>
Gerrit-Comment-Date: Wed, 10 Aug 2022 00:35:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Derek Beckett (Gerrit)

no leída,
11 ago 2022, 11:58:36 a.m.11/8/22
para medi...@chromium.org,Seewai Fu,Becca Hughes

Patch set 1:Verified +1Commit-Queue +2

View Change

    To view, visit change 3821420. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromiumos/platform/tast-tests
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie61a425068a3c56142c7b4e669f2ef469736f593
    Gerrit-Change-Number: 3821420
    Gerrit-PatchSet: 1
    Gerrit-Owner: Derek Beckett <dbec...@chromium.org>
    Gerrit-Reviewer: Derek Beckett <dbec...@chromium.org>
    Gerrit-Reviewer: Seewai Fu <seew...@google.com>
    Gerrit-CC: Becca Hughes <becca...@chromium.org>
    Gerrit-Comment-Date: Thu, 11 Aug 2022 15:58:30 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Derek Beckett (Gerrit)

    no leída,
    12 ago 2022, 1:06:23 p.m.12/8/22
    para medi...@chromium.org,Chromeos LUCI,Seewai Fu,Becca Hughes

    Attention is currently required from: Derek Beckett.

    Patch set 1:Commit-Queue +2

    View Change

      To view, visit change 3821420. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromiumos/platform/tast-tests
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie61a425068a3c56142c7b4e669f2ef469736f593
      Gerrit-Change-Number: 3821420
      Gerrit-PatchSet: 1
      Gerrit-Owner: Derek Beckett <dbec...@chromium.org>
      Gerrit-Reviewer: Derek Beckett <dbec...@chromium.org>
      Gerrit-Reviewer: Seewai Fu <seew...@google.com>
      Gerrit-CC: Becca Hughes <becca...@chromium.org>
      Gerrit-Attention: Derek Beckett <dbec...@chromium.org>
      Gerrit-Comment-Date: Fri, 12 Aug 2022 17:06:16 +0000

      Derek Beckett (Gerrit)

      no leída,
      15 ago 2022, 1:31:34 p.m.15/8/22
      para medi...@chromium.org,Chromeos LUCI,Seewai Fu,Becca Hughes

      Attention is currently required from: Derek Beckett.

      Patch set 1:Commit-Queue +2

      View Change

        To view, visit change 3821420. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromiumos/platform/tast-tests
        Gerrit-Branch: main
        Gerrit-Change-Id: Ie61a425068a3c56142c7b4e669f2ef469736f593
        Gerrit-Change-Number: 3821420
        Gerrit-PatchSet: 1
        Gerrit-Owner: Derek Beckett <dbec...@chromium.org>
        Gerrit-Reviewer: Derek Beckett <dbec...@chromium.org>
        Gerrit-Reviewer: Seewai Fu <seew...@google.com>
        Gerrit-CC: Becca Hughes <becca...@chromium.org>
        Gerrit-Attention: Derek Beckett <dbec...@chromium.org>
        Gerrit-Comment-Date: Mon, 15 Aug 2022 17:31:21 +0000

        Chromeos LUCI (Gerrit)

        no leída,
        15 ago 2022, 8:09:00 p.m.15/8/22
        para Derek Beckett,medi...@chromium.org,Seewai Fu,Becca Hughes

        Chromeos LUCI submitted this change.

        View Change


        Approvals: Seewai Fu: Looks good to me, approved Derek Beckett: Commit; Verified
        disable failing ui.* tests

        Test is below minimum pass criteria.

        BUG=b:241943746
        TEST=cq

        Change-Id: Ie61a425068a3c56142c7b4e669f2ef469736f593
        Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/3821420
        Reviewed-by: Seewai Fu <seew...@google.com>
        Tested-by: Derek Beckett <dbec...@chromium.org>
        Commit-Queue: Derek Beckett <dbec...@chromium.org>
        ---
        M src/chromiumos/tast/local/bundles/cros/ui/play_pause_chrome.go
        1 file changed, 20 insertions(+), 1 deletion(-)

        diff --git a/src/chromiumos/tast/local/bundles/cros/ui/play_pause_chrome.go b/src/chromiumos/tast/local/bundles/cros/ui/play_pause_chrome.go
        index d9aea74..5362901 100644
        --- a/src/chromiumos/tast/local/bundles/cros/ui/play_pause_chrome.go
        +++ b/src/chromiumos/tast/local/bundles/cros/ui/play_pause_chrome.go
        @@ -21,7 +21,8 @@
        LacrosStatus: testing.LacrosVariantNeeded,
        Desc: "Checks the play/pause accelerator will play/pause Chrome",
        Contacts: []string{"becca...@chromium.org", "medi...@chromium.org"},
        - Attr: []string{"group:mainline", "informational"},
        + // Disabled due to <1% pass rate over 30 days. See b/241943746
        + //Attr: []string{"group:mainline", "informational"},
        SoftwareDeps: []string{"chrome"},
        Data: []string{
        "media_session_60sec_test.ogg",

        To view, visit change 3821420. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromiumos/platform/tast-tests
        Gerrit-Branch: main
        Gerrit-Change-Id: Ie61a425068a3c56142c7b4e669f2ef469736f593
        Gerrit-Change-Number: 3821420
        Gerrit-PatchSet: 2
        Gerrit-Owner: Derek Beckett <dbec...@chromium.org>
        Gerrit-Reviewer: Derek Beckett <dbec...@chromium.org>
        Gerrit-Reviewer: Seewai Fu <seew...@google.com>
        Gerrit-CC: Becca Hughes <becca...@chromium.org>
        Gerrit-MessageType: merged
        Responder a todos
        Responder al autor
        Reenviar
        0 mensajes nuevos