Issue 1489855 in chromium: Flag expired : document-picture-in-picture-api is expired in M120

632 views
Skip to first unread message

chrome-branch-day via monorail

unread,
Oct 5, 2023, 3:39:06 PM10/5/23
to medi...@chromium.org

Comment #1 on issue 1489855 by chrome-b...@chops-service-accounts.iam.gserviceaccount.com: Flag expired : document-picture-in-picture-api is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1489855#c1

This flag has been marked as expiring in M120 or earlier. This bug has been opened for the Eng teams to clean up the references for the flag in the //chrome/browser/flag-metadata.json as well as references to that flag.

This is a friendly reminder to help get this clean up completed.

If you think this flag needs to be extended beyond this milestone, please follow these steps:
- If you see a flag listed as expiring that you want to keep, create a CL updating //chrome/browser/flag-metadata.json with an appropriate new expiration milestone.
- If you do this before the M120 branch you're all set; if you do it after the M120 branch you'll need to merge that CL to the M120 branch as well.

You can check the branch date for this milestone at https://chromiumdash.appspot.com/schedule

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

mfoltz via monorail

unread,
Oct 5, 2023, 3:42:57 PM10/5/23
to medi...@chromium.org
Updates:
Cc: libe...@chromium.org
Components: Blink>Media>PictureInPicture
Owner: ste...@chromium.org
Status: Assigned

Comment #2 on issue 1489855 by mfo...@chromium.org: Flag expired : document-picture-in-picture-api is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1489855#c2

=> steimel@ for PiP

chrome-branch-day via monorail

unread,
Oct 31, 2023, 2:16:37 PM10/31/23
to medi...@chromium.org

Comment #3 on issue 1489855 by chrome-b...@chops-service-accounts.iam.gserviceaccount.com: Flag expired : document-picture-in-picture-api is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1489855#c3

This flag has been marked as expiring in M121 or earlier. This bug has been opened for the Eng teams to clean up the references for the flag in the //chrome/browser/flag-metadata.json as well as references to that flag.


This is a friendly reminder to help get this clean up completed.

If you think this flag needs to be extended beyond this milestone, please follow these steps:
- If you see a flag listed as expiring that you want to keep, create a CL updating //chrome/browser/flag-metadata.json with an appropriate new expiration milestone.
- If you do this before the M121 branch you're all set; if you do it after the M121 branch you'll need to merge that CL to the M121 branch as well.


You can check the branch date for this milestone at https://chromiumdash.appspot.com/schedule

chrome-branch-day via monorail

unread,
Dec 5, 2023, 5:58:12 PM12/5/23
to medi...@chromium.org

Comment #4 on issue 1489855 by chrome-b...@chops-service-accounts.iam.gserviceaccount.com: Flag expired : document-picture-in-picture-api is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1489855#c4

This flag has been marked as expiring in M122 or earlier. This bug has been opened for the Eng teams to clean up the references for the flag in the //chrome/browser/flag-metadata.json as well as references to that flag.


This is a friendly reminder to help get this clean up completed.

If you think this flag needs to be extended beyond this milestone, please follow these steps:
- If you see a flag listed as expiring that you want to keep, create a CL updating //chrome/browser/flag-metadata.json with an appropriate new expiration milestone.
- If you do this before the M122 branch you're all set; if you do it after the M122 branch you'll need to merge that CL to the M122 branch as well.

chrome-branch-day via monorail

unread,
Jan 23, 2024, 3:16:45 PM1/23/24
to medi...@chromium.org

Comment #5 on issue 1489855 by chrome-b...@chops-service-accounts.iam.gserviceaccount.com: Flag expired : document-picture-in-picture-api is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1489855#c5

This flag has been marked as expiring in M123 or earlier. This bug has been opened for the Eng teams to clean up the references for the flag in the //chrome/browser/flag-metadata.json as well as references to that flag.


This is a friendly reminder to help get this clean up completed.

If you think this flag needs to be extended beyond this milestone, please follow these steps:
- If you see a flag listed as expiring that you want to keep, create a CL updating //chrome/browser/flag-metadata.json with an appropriate new expiration milestone.
- If you do this before the M123 branch you're all set; if you do it after the M123 branch you'll need to merge that CL to the M123 branch as well.

Git Watcher via monorail

unread,
Jan 24, 2024, 1:49:18 PM1/24/24
to medi...@chromium.org
Updates:
Status: Fixed

Comment #6 on issue 1489855 by Git Watcher: Flag expired : document-picture-in-picture-api is expired in M120
https://bugs.chromium.org/p/chromium/issues/detail?id=1489855#c6

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/835c8777167ac9437959f5a46381bdaeb86bb276

commit 835c8777167ac9437959f5a46381bdaeb86bb276
Author: mark a. foltz <mfo...@chromium.org>
Date: Wed Jan 24 18:48:09 2024

[Flags] Remove expired media flags and extend a couple of others.

Removed:
- hidpi-capture
- document-picture-in-picture-api
- enable-webrtc-pipewire-capturer
- hardware-media-key-handling

Extended:
- mac-loopback-audio-for-cast
- mac-loopback-audio-for-screenshare


Fixed: 1489855,1489964,1508582,1521024,1521029,1521030
Change-Id: I43ae2430a13148cf7553bb8436986474b7e23212
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5230326
Reviewed-by: Alexander Cooper <alco...@chromium.org>
Reviewed-by: Tommy Steimel <ste...@chromium.org>
Commit-Queue: Mark Foltz <mfo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1251551}

[modify] https://crrev.com/835c8777167ac9437959f5a46381bdaeb86bb276/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/835c8777167ac9437959f5a46381bdaeb86bb276/chrome/browser/about_flags.cc
[modify] https://crrev.com/835c8777167ac9437959f5a46381bdaeb86bb276/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/835c8777167ac9437959f5a46381bdaeb86bb276/chrome/browser/flag-metadata.json
Reply all
Reply to author
Forward
0 new messages