Issue 1508647 in chromium: Flag expired : zero-copy-tab-capture is expired in M122

0 views
Skip to first unread message

chrome-branch-day via monorail

unread,
Dec 5, 2023, 6:09:46 PM12/5/23
to media-ca...@chromium.org

Comment #1 on issue 1508647 by chrome-b...@chops-service-accounts.iam.gserviceaccount.com: Flag expired : zero-copy-tab-capture is expired in M122
https://bugs.chromium.org/p/chromium/issues/detail?id=1508647#c1

This flag has been marked as expiring in M122 or earlier. This bug has been opened for the Eng teams to clean up the references for the flag in the //chrome/browser/flag-metadata.json as well as references to that flag.

This is a friendly reminder to help get this clean up completed.

If you think this flag needs to be extended beyond this milestone, please follow these steps:
- If you see a flag listed as expiring that you want to keep, create a CL updating //chrome/browser/flag-metadata.json with an appropriate new expiration milestone.
- If you do this before the M122 branch you're all set; if you do it after the M122 branch you'll need to merge that CL to the M122 branch as well.

You can check the branch date for this milestone at https://chromiumdash.appspot.com/schedule

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

hbos via monorail

unread,
Dec 6, 2023, 2:58:17 AM12/6/23
to media-ca...@chromium.org
Updates:
Cc: hand...@google.com
Owner: il...@chromium.org
Status: Assigned

Comment #2 on issue 1508647 by hb...@chromium.org: Flag expired : zero-copy-tab-capture is expired in M122
https://bugs.chromium.org/p/chromium/issues/detail?id=1508647#c2

(No comment was entered for this change.)

hbos via monorail

unread,
Dec 6, 2023, 2:58:38 AM12/6/23
to media-ca...@chromium.org

Comment #3 on issue 1508647 by hb...@chromium.org: Flag expired : zero-copy-tab-capture is expired in M122
https://bugs.chromium.org/p/chromium/issues/detail?id=1508647#c3

Is this one yours, Ilya?

ilnik via monorail

unread,
Dec 6, 2023, 4:42:58 AM12/6/23
to media-ca...@chromium.org
Updates:
Components: Internals>Media>SurfaceCapture
Owner: jop...@chromium.org

Comment #4 on issue 1508647 by il...@chromium.org: Flag expired : zero-copy-tab-capture is expired in M122
https://bugs.chromium.org/p/chromium/issues/detail?id=1508647#c4

Nope. It sounds very similar but this one is about the tab capture, not the camera.

Jordan, do you own it? I think it would be nice to extend the flag. Recently I've seen it being used to debug some issues with HW encoder stalling on chromeOS.

mfoltz via monorail

unread,
Dec 6, 2023, 1:04:00 PM12/6/23
to media-ca...@chromium.org
Updates:
Owner: hi...@chromium.org

Comment #5 on issue 1508647 by mfo...@chromium.org: Flag expired : zero-copy-tab-capture is expired in M122
https://bugs.chromium.org/p/chromium/issues/detail?id=1508647#c5

hiroh@, I think you are rolling this out on ChromeOS? Should we keep the UI flag?

henrika via monorail

unread,
Dec 6, 2023, 1:10:14 PM12/6/23
to media-ca...@chromium.org
Updates:
Cc: hen...@chromium.org

Comment #6 on issue 1508647 by hen...@chromium.org: Flag expired : zero-copy-tab-capture is expired in M122
https://bugs.chromium.org/p/chromium/issues/detail?id=1508647#c6


(No comment was entered for this change.)

hiroh via monorail

unread,
Dec 6, 2023, 6:35:57 PM12/6/23
to media-ca...@chromium.org

Comment #7 on issue 1508647 by hi...@chromium.org: Flag expired : zero-copy-tab-capture is expired in M122
https://bugs.chromium.org/p/chromium/issues/detail?id=1508647#c7

Not yet, I am still working to enable it on ChromeOS.
https://b.corp.google.com/issues/267966835

I would like to keep the UI flag for a couple of milestones.

hiroh via monorail

unread,
Dec 7, 2023, 3:36:52 AM12/7/23
to media-ca...@chromium.org

Comment #8 on issue 1508647 by hi...@chromium.org: Flag expired : zero-copy-tab-capture is expired in M122
https://bugs.chromium.org/p/chromium/issues/detail?id=1508647#c8

Created CL. https://chromium-review.googlesource.com/c/chromium/src/+/5096018

Git Watcher via monorail

unread,
Dec 7, 2023, 1:00:37 PM12/7/23
to media-ca...@chromium.org

Comment #9 on issue 1508647 by Git Watcher: Flag expired : zero-copy-tab-capture is expired in M122
https://bugs.chromium.org/p/chromium/issues/detail?id=1508647#c9

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/c803c891055d3905dbefee944c00e4b28404692b

commit c803c891055d3905dbefee944c00e4b28404692b
Author: Hirokazu Honda <hi...@chromium.org>
Date: Thu Dec 07 17:59:11 2023

Extend zero-copy-tab-capture flag

Bug: 1508647
Test: None
Change-Id: Ia47b7f5f555d22aea67c8f07ec8f9f9b162e8f00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5096018
Reviewed-by: Piotr Bialecki <bia...@chromium.org>
Commit-Queue: Piotr Bialecki <bia...@chromium.org>
Auto-Submit: Hirokazu Honda <hi...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1234577}

[modify] https://crrev.com/c803c891055d3905dbefee944c00e4b28404692b/chrome/browser/flag-metadata.json

hiroh via monorail

unread,
Dec 7, 2023, 8:52:41 PM12/7/23
to media-ca...@chromium.org
Updates:
Status: Fixed

Comment #10 on issue 1508647 by hi...@chromium.org: Flag expired : zero-copy-tab-capture is expired in M122
https://bugs.chromium.org/p/chromium/issues/detail?id=1508647#c10


(No comment was entered for this change.)

Reply all
Reply to author
Forward
0 new messages