LSC: Migrate crbug/ links to Buganizer from Monorail

[Solomon Kinard]

Hi,

go/chrome-migrate-monorail-to-buganizer

This is my first time trying this. Requesting a global reviewer for an easy change that is not expected to have any side effects at all. i only updated //extensions and //chrome if the path contained "extension". It can easily be expanded to the entire codebase if you'd like. The current change would be split into 41 if split were used. However, global approval is requested to just merge one CL with only one reviewer for lower review cost. Here is the request.

Thanks.

[Nico Weber]

Mind posting a link to a doc that works outside google?

--
You received this message because you are subscribed to the Google Groups "lsc-review" group.
To unsubscribe from this group and stop receiving emails from it, send an email to lsc-review+...@chromium.org.
To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/lsc-review/CAA53GQkR3ogDqoT5UYCU-ae5SAELfeuOQ1tEzyysmmkMcTNSLQ%40mail.gmail.com.

[Solomon Kinard]

Sure thing. Here's the link.

[Nico Weber]

Thanks!

It could be worded better :) If I understand correctly, you just want to update the bug numbers (eg https://crbug.com/941160 -> https://crbug.com/41446487), not the host (eg NOT crbug.com/941160 -> b/41446487). That sounds good to me; in fact we had a bigger LSC for the same thing a bit under two years ago: go/crbug-todo-migration (looks like I didn't ask for a public doc back then). Here's an example CL from back then: https://chromium-review.googlesource.com/c/chromium/src/+/5465984 I can't access that doc right now; does it have a section on why it did TODOs only and not other bugs?

Please use something like "Migrate from crbug.com/<crbug ID> to crbug.com/<buganizer ID> in TODO comments" for the CLs (or use the format of the old CL). Maybe we can even use the old bug?

How many files is this in total?

[Alison Gale]

Here is the public link to the doc from my earlier migration: https://docs.google.com/document/d/1moEwYhXgUL-QzhC7K82QlQqffhyCBtUfB9EBi8B8IE4/edit?tab=t.0

I limited the scope of my change to just bugs in TODOs, so it looks like it should be mostly comments that still need updating. In the doc you linked, you mentioned the format "crrev.com/c/7508317". Is there a reason you prefer that over "crbug.com/7508317"? It would be helpful to keep everything consistent.

To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/lsc-review/CADZ1XiYR%2BC5htcwG_DU1uLBctXigGYRofOi-zBQzaVK8%3DgF2xg%40mail.gmail.com.

--

Alison Gale Senior Software Engineer Google Chrome

[Solomon Kinard]

Thanks. All comments have been addressed.

I limited the scope of my change to just bugs in TODOs, so it looks like it should be mostly comments that still need updating. In the doc you linked, you mentioned the format "crrev.com/c/7508317". Is there a reason you prefer that over "crbug.com/7508317"? It would be helpful to keep everything consistent.

Can you clarify? crrev.com/c/7508317 was the "Changelist" aka CL that housed every change, which has now been reduced to just a slice due to Gerrit upload timeouts. That heading in the template was what seemed like a reasonable place to put a candidate CL, which has now been moved to a new "Change IDs" section at the bottom, like your doc.

It could be worded better :) If I understand correctly, you just want to update the bug numbers (eg https://crbug.com/941160 -> https://crbug.com/41446487), not the host (eg NOT crbug.com/941160 -> b/41446487). That sounds good to me; in fact we had a bigger LSC for the same thing a bit under two years ago: go/crbug-todo-migration (looks like I didn't ask for a public doc back then). Here's an example CL from back then: https://chromium-review.googlesource.com/c/chromium/src/+/5465984 I can't access that doc right now; does it have a section on why it did TODOs only and not other bugs?

I'm not sure how there are any TODOs or comments left available for this most recent request. I saw a few and decided to tackle a large portion of them. It was going to be just for extensions, but since we're here, I went ahead and included more //chrome C++ header and implementation files too.

 

Please use something like "Migrate from crbug.com/<crbug ID> to crbug.com/<buganizer ID> in TODO comments" for the CLs (or use the format of the old CL).

Done. The subject is now: "Migrate comments from crbug.com/<crbug ID> to crbug.com/<buganizer ID>"

 

Maybe we can even use the old bug?

Done. 

How many files is this in total?

1063 files changed, 2160 insertions(+), 2114 deletions(-)

git cl split would make 176 CLs. For simplicity, only 5 were made instead.

[Alison Gale]

I didn't realize you were linking a CL that had the change rather than describing the change in the doc. Left some comments but this seems reasonable to me.

Alison