Joshua Hood (Gerrit)

unread,

Oct 29, 2025, 4:01:26 PM (8 days ago) Oct 29

to Christian Dullweber, Nico Weber, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, chromium...@chromium.org, Ryan Sultanem, asvitkine...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, csharris...@chromium.org, dullweb...@chromium.org, ipc-securi...@chromium.org, loading-rev...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, subresource-f...@chromium.org

Attention needed from Christian Dullweber, Nico Weber and mmenke

Joshua Hood added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Joshua Hood . resolved

Hi all, PTAL.

Open in Gerrit

Related details

Attention is currently required from:

Christian Dullweber
Nico Weber
mmenke

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

mmenke (Gerrit)

unread,

Oct 29, 2025, 4:05:49 PM (8 days ago) Oct 29

to Joshua Hood, Ken Buchanan, Christian Dullweber, Nico Weber, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, chromium...@chromium.org, Ryan Sultanem, asvitkine...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, csharris...@chromium.org, dullweb...@chromium.org, ipc-securi...@chromium.org, loading-rev...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, subresource-f...@chromium.org

Attention needed from Christian Dullweber, Joshua Hood, Ken Buchanan and Nico Weber

mmenke voted and added 3 comments

Votes added by mmenke

Code-Review

+1

3 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

mmenke . resolved

net/ and services/network LGTM, thanks for cleaning this up, though I remain sad about never shipping this.

File net/base/features.h

Line 306, Patchset 3 (Latest):

mmenke . unresolved

nit: Remove extra blank line

File net/base/features.cc

Line 227, Patchset 3 (Latest):

mmenke . unresolved

nit: Remove extra blank line

Open in Gerrit

Related details

Attention is currently required from:

Christian Dullweber
Joshua Hood
Ken Buchanan
Nico Weber

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ken Buchanan (Gerrit)

unread,

Oct 29, 2025, 4:09:07 PM (8 days ago) Oct 29

to Joshua Hood, Christian Dullweber, Nico Weber, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, chromium...@chromium.org, Ryan Sultanem, asvitkine...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, csharris...@chromium.org, dullweb...@chromium.org, ipc-securi...@chromium.org, loading-rev...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, subresource-f...@chromium.org

Attention needed from Christian Dullweber, Joshua Hood and Nico Weber

Ken Buchanan voted and added 1 comment

Votes added by Ken Buchanan

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Ken Buchanan . resolved

lgtm components/content_settings/core/common/content_settings_types.mojom

Open in Gerrit

Related details

Attention is currently required from:

Christian Dullweber
Joshua Hood
Nico Weber

satisfied_requirement

unsatisfied_requirement

open

diffy

Joshua Hood (Gerrit)

unread,

Oct 29, 2025, 4:29:42 PM (8 days ago) Oct 29

to Ken Buchanan, Christian Dullweber, Nico Weber, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, chromium...@chromium.org, Ryan Sultanem, asvitkine...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, csharris...@chromium.org, dullweb...@chromium.org, ipc-securi...@chromium.org, loading-rev...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, subresource-f...@chromium.org

Attention needed from Christian Dullweber, Ken Buchanan, Nico Weber and mmenke

Joshua Hood voted and added 2 comments

Votes added by Joshua Hood

Commit-Queue

+1

2 comments

File net/base/features.h

Line 306, Patchset 3:

mmenke . resolved

nit: Remove extra blank line

Joshua Hood

Done

File net/base/features.cc

Line 227, Patchset 3:

mmenke . resolved

nit: Remove extra blank line

Joshua Hood

Done

Open in Gerrit

Related details

Attention is currently required from:

Christian Dullweber
Ken Buchanan
Nico Weber
mmenke

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

mmenke (Gerrit)

unread,

Oct 29, 2025, 4:31:51 PM (8 days ago) Oct 29

to Joshua Hood, Ken Buchanan, Christian Dullweber, Nico Weber, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, chromium...@chromium.org, Ryan Sultanem, asvitkine...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, csharris...@chromium.org, dullweb...@chromium.org, ipc-securi...@chromium.org, loading-rev...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, subresource-f...@chromium.org

Attention needed from Christian Dullweber, Joshua Hood, Ken Buchanan and Nico Weber

mmenke voted and added 1 comment

Votes added by mmenke

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

mmenke . resolved

net/ and services/network still LGTM

Open in Gerrit

Related details

Attention is currently required from:

Christian Dullweber

Joshua Hood
Ken Buchanan
Nico Weber

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Christian Dullweber (Gerrit)

unread,

Oct 30, 2025, 5:27:12 AM (7 days ago) Oct 30

to Joshua Hood, Ken Buchanan, Nico Weber, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, chromium...@chromium.org, Ryan Sultanem, asvitkine...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, csharris...@chromium.org, dullweb...@chromium.org, ipc-securi...@chromium.org, loading-rev...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, subresource-f...@chromium.org

Attention needed from Joshua Hood, Ken Buchanan and Nico Weber

Christian Dullweber voted and added 1 comment

Votes added by Christian Dullweber

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Christian Dullweber . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:

Joshua Hood
Ken Buchanan
Nico Weber

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ken Buchanan (Gerrit)

unread,

Oct 31, 2025, 9:31:51 AM (6 days ago) Oct 31

to Joshua Hood, Christian Dullweber, Nico Weber, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, chromium...@chromium.org, Ryan Sultanem, asvitkine...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, csharris...@chromium.org, dullweb...@chromium.org, ipc-securi...@chromium.org, loading-rev...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, subresource-f...@chromium.org

Attention needed from Joshua Hood and Nico Weber

Ken Buchanan voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Joshua Hood
Nico Weber

satisfied_requirement

unsatisfied_requirement

open

diffy

Nico Weber (Gerrit)

unread,

Nov 3, 2025, 9:18:56 AM (3 days ago) Nov 3

to Joshua Hood, Nico Weber, Ken Buchanan, Christian Dullweber, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, chromium...@chromium.org, Ryan Sultanem, asvitkine...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, csharris...@chromium.org, dullweb...@chromium.org, ipc-securi...@chromium.org, loading-rev...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, subresource-f...@chromium.org

Attention needed from Joshua Hood

Nico Weber voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Joshua Hood

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Joshua Hood (Gerrit)

unread,

Nov 3, 2025, 9:58:45 AM (3 days ago) Nov 3

to Nico Weber, Ken Buchanan, Christian Dullweber, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, chromium...@chromium.org, Ryan Sultanem, asvitkine...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, csharris...@chromium.org, dullweb...@chromium.org, ipc-securi...@chromium.org, loading-rev...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, subresource-f...@chromium.org

Joshua Hood voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Joshua Hood (Gerrit)

unread,

Nov 3, 2025, 11:47:38 AM (3 days ago) Nov 3

to Nico Weber, Ken Buchanan, Christian Dullweber, Chromium LUCI CQ, Chromium Metrics Reviews, AyeAye, chromium...@chromium.org, Ryan Sultanem, asvitkine...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, csharris...@chromium.org, dullweb...@chromium.org, ipc-securi...@chromium.org, loading-rev...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, subresource-f...@chromium.org

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Nov 3, 2025, 12:20:55 PM (3 days ago) Nov 3

to Joshua Hood, Nico Weber, Ken Buchanan, Christian Dullweber, Chromium Metrics Reviews, AyeAye, chromium...@chromium.org, Ryan Sultanem, asvitkine...@chromium.org, bmcquad...@chromium.org, bnc+...@chromium.org, csharris...@chromium.org, dullweb...@chromium.org, ipc-securi...@chromium.org, loading-rev...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, subresource-f...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Delete the Third Party Cookie Deprecation Trial for embedded sites

The removal includes:
- Deleting the tpcd::trial::TpcdTrialService and its factory.
- Removing the TPCD_TRIAL content setting.
- Cleaning up related logic in CookieSettings and other components.
- Removing the kTpcdTrialSettings feature flag.
- Deleting the tpcd::trial::ValidityService.

Bug: 448445047

Change-Id: Id78eafaa62970a57a93392fdb6b2ae94a9e3ea54

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7096118

Reviewed-by: mmenke <mme...@chromium.org>

Commit-Queue: Joshua Hood <j...@chromium.org>

Reviewed-by: Christian Dullweber <dull...@chromium.org>

Reviewed-by: Nico Weber <tha...@chromium.org>

Reviewed-by: Ken Buchanan <ke...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1539399}

Files:

M chrome/android/javatests/src/org/chromium/chrome/browser/site_settings/WebsitePermissionsFetcherTest.java
M chrome/browser/BUILD.gn
M chrome/browser/content_settings/content_settings_default_provider_unittest.cc
M chrome/browser/content_settings/content_settings_pref_provider_unittest.cc
M chrome/browser/content_settings/host_content_settings_map_unittest.cc
M chrome/browser/controlled_frame/controlled_frame_permissions_unittest.cc
M chrome/browser/page_load_metrics/observers/third_party_cookie_deprecation_metrics_observer_browsertest.cc
M chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
M chrome/browser/profiles/profile_impl.cc
M chrome/browser/profiles/profile_keyed_service_browsertest.cc
M chrome/browser/resources/privacy_sandbox/internals/content_settings_groups.ts
M chrome/browser/subresource_filter/ad_heuristic_tpcd_browsertest.cc
M chrome/browser/subresource_filter/safe_browsing_child_navigation_throttle_unittest.cc
M chrome/browser/tpcd/metadata/manager_browsertest.cc
D chrome/browser/tpcd/support/tpcd_support_browsertest.cc
D chrome/browser/tpcd/support/tpcd_support_service.cc
D chrome/browser/tpcd/support/tpcd_support_service.h
D chrome/browser/tpcd/support/tpcd_support_service_factory.cc
D chrome/browser/tpcd/support/tpcd_support_service_factory.h
D chrome/browser/tpcd/support/validity_service.cc
D chrome/browser/tpcd/support/validity_service.h
D chrome/browser/tpcd/support/validity_service_browsertest.cc
M chrome/browser/ui/tab_helpers.cc
M chrome/browser/ui/webui/privacy_sandbox/privacy_sandbox_internals_handler_browsertest.cc
M chrome/browser/ui/webui/settings/site_settings_helper.cc
M chrome/test/BUILD.gn
M components/content_settings/core/browser/content_settings_default_provider.cc
M components/content_settings/core/browser/content_settings_pref_provider.cc
M components/content_settings/core/browser/content_settings_registry.cc
M components/content_settings/core/browser/content_settings_uma_util.cc
M components/content_settings/core/browser/cookie_settings_unittest.cc
M components/content_settings/core/common/content_settings_types.mojom
M components/content_settings/core/common/cookie_settings_base.cc
M components/content_settings/core/common/cookie_settings_base.h
M net/base/features.cc
M net/base/features.h
M services/network/cookie_settings_unittest.cc
M tools/metrics/histograms/enums.xml

Change size: XL

Delta: 38 files changed, 32 insertions(+), 2376 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by mmenke, +1 by Nico Weber, +1 by Christian Dullweber, +1 by Ken Buchanan

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Delete the Third Party Cookie Deprecation Trial for embedded sites [chromium/src : main]

Joshua Hood (Gerrit)

Joshua Hood added 1 comment

Related details

mmenke (Gerrit)

mmenke voted and added 3 comments

Votes added by mmenke

3 comments

Related details

Ken Buchanan (Gerrit)

Ken Buchanan voted and added 1 comment

Votes added by Ken Buchanan

1 comment

Related details

Joshua Hood (Gerrit)

Joshua Hood voted and added 2 comments

Votes added by Joshua Hood

2 comments

Related details

mmenke (Gerrit)

mmenke voted and added 1 comment

Votes added by mmenke

1 comment

Related details

Christian Dullweber (Gerrit)

Christian Dullweber voted and added 1 comment

Votes added by Christian Dullweber

1 comment

Related details

Ken Buchanan (Gerrit)

Ken Buchanan voted Code-Review+1

Related details

Nico Weber (Gerrit)

Nico Weber voted Code-Review+1

Related details

Joshua Hood (Gerrit)

Joshua Hood voted Commit-Queue+2

Related details

Joshua Hood (Gerrit)

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information