Fix unsafe buffer usage in literal_buffer_test.cc [chromium/src : main]
0 views
Skip to first unread message
Arthur Sonzogni (Gerrit)
Mar 11, 2026, 1:27:50 PM (yesterday) Mar 11
to Yoav Weiss (@Shopify), Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from Yoav Weiss (@Shopify)
Arthur Sonzogni voted and added 2 comments![]( "Open in Gerrit")
Votes added by Arthur Sonzogni
| Auto-Submit | +1 |
2 comments
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Arthur Sonzogni . resolved
Sounds like a pretty trivial patch. Yoav, could you please take a look?
File third_party/blink/renderer/core/html/parser/literal_buffer_test.cc
Line 54, Patchset 2 (Latest):
EXPECT_EQ(String(base::span(buf)), u"defabc");Arthur Sonzogni . resolved
Alternatively:
```
EXPECT_TRUE(base::ranges::equal(base::span(buf), base::span(u"defabc").first(6)));
```
(But this is a bit weird to use `first(6)` to avoid comparing against the last `\0` from the string literal.
Related details
Attention is currently required from:
- Yoav Weiss (@Shopify)
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yoav Weiss (@Shopify) (Gerrit)
Mar 11, 2026, 1:55:54 PM (yesterday) Mar 11
to Arthur Sonzogni, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from Arthur Sonzogni
Yoav Weiss (@Shopify) voted![]( "Open in Gerrit")
Attention is currently required from:
- Arthur Sonzogni
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Sonzogni (Gerrit)
Mar 11, 2026, 2:09:47 PM (yesterday) Mar 11
to Yoav Weiss (@Shopify), Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from Yoav Weiss (@Shopify)
Arthur Sonzogni voted![]( "Open in Gerrit")
Attention is currently required from:
- Yoav Weiss (@Shopify)
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 11, 2026, 4:06:26 PM (yesterday) Mar 11
to Arthur Sonzogni, Yoav Weiss (@Shopify), chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Fix unsafe buffer usage in literal_buffer_test.cc
Replaced an unsafe `memcmp` with a `String` comparison from a
`base::span` to fix an unsafe buffer error.
Initial patchset generated by headless gemini-cli using:
//agents/prompts/projects/spanification/run.py
Fixed: 457422945
Change-Id: I8d69d8ac1e4d569590ce568edb2f2078b3fafed4
Reviewed-by: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Auto-Submit: Arthur Sonzogni <arthurs...@chromium.org>
Commit-Queue: Arthur Sonzogni <arthurs...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1597940}
Files:
- M third_party/blink/renderer/core/html/parser/literal_buffer_test.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yoav Weiss (@Shopify)
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages