[HTML] Skip leading plus sign in meter element floating-point parsing [chromium/src : main]

[Joey Arhar (Gerrit)]

Attention needed from Kent Tamura and Mostafa Aboalkasim

Joey Arhar added 2 comments

Commit Message

Line 9, Patchset 6 (Latest):The HTML spec's algorithm for parsing a floating-point number" skips a

Joey Arhar . unresolved

Is there supposed to be another double-quote to match this one?

File third_party/blink/web_tests/external/wpt/html/semantics/forms/the-input-element/number.html

File-level comment, Patchset 6 (Latest):

Joey Arhar . unresolved

Will other browsers pass this test with the changes? It looks like they're already passing without this, so perhaps they wouldn't? https://wpt.fyi/results/html/semantics/forms/the-input-element/number.html

Open in Gerrit

Related details

Attention is currently required from:

• Kent Tamura
• Mostafa Aboalkasim

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I033aad1a261eead7d8aeac3f3344efa16da7712e

Gerrit-Change-Number: 7832192

Gerrit-PatchSet: 6

Gerrit-Owner: Mostafa Aboalkasim <mostafa.aboal...@gmail.com>

Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Mostafa Aboalkasim <mostafa.aboal...@gmail.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Mostafa Aboalkasim <mostafa.aboal...@gmail.com>

Gerrit-Attention: Kent Tamura <tk...@chromium.org>

Gerrit-Comment-Date: Tue, 12 May 2026 16:52:31 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Kent Tamura (Gerrit)]

Attention needed from Mostafa Aboalkasim

Kent Tamura added 1 comment

File third_party/blink/renderer/core/html/parser/html_parser_idioms.cc

Line 121, Patchset 5 (Parent): // http://www.whatwg.org/specs/web-apps/current-work/#floating-point-numbers

Kent Tamura . unresolved

So the URL should be updated to https://html.spec.whatwg.org/C/#rules-for-parsing-floating-point-number-values , right?

Mostafa Aboalkasim

I don't think we need to update it. The spec already mentions in the parsing algorithm that if a '+' appears before a number (e.g. "+100") [see point 8 here](https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#rules-for-parsing-floating-point-number-values), it should be skipped and the number should still be parsed. Firefox follows the same behavior as well:
https://searchfox.org/firefox-main/source/mozglue/misc/decimal/Decimal.h#234

Kent Tamura

http://www.whatwg.org/specs/web-apps/current-work/#floating-point-numbers doesn't say the leading `+` is acceptable, and https://html.spec.whatwg.org/C/#rules-for-parsing-floating-point-number-values says it's acceptable. The comment should point to https://html.spec.whatwg.org/C/#rules-for-parsing-floating-point-number-values, I think.

Open in Gerrit

Related details

Attention is currently required from:

• Mostafa Aboalkasim

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I033aad1a261eead7d8aeac3f3344efa16da7712e

Gerrit-Change-Number: 7832192

Gerrit-PatchSet: 7

Gerrit-Owner: Mostafa Aboalkasim <mostafa.aboal...@gmail.com>

Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Mostafa Aboalkasim <mostafa.aboal...@gmail.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Mostafa Aboalkasim <mostafa.aboal...@gmail.com>

Gerrit-Comment-Date: Tue, 12 May 2026 22:37:04 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Mostafa Aboalkasim <mostafa.aboal...@gmail.com>

Comment-In-Reply-To: Kent Tamura <tk...@chromium.org>

[Mostafa Aboalkasim (Gerrit)]

Attention needed from Joey Arhar, Kent Tamura and Mostafa Aboalkasim

Message from Mostafa Aboalkasim

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:

• Joey Arhar
• Kent Tamura
• Mostafa Aboalkasim

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I033aad1a261eead7d8aeac3f3344efa16da7712e

Gerrit-Change-Number: 7832192

Gerrit-PatchSet: 9

Gerrit-Owner: Mostafa Aboalkasim <mostafa.aboal...@gmail.com>

Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Mostafa Aboalkasim <mostafa.aboal...@gmail.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Joey Arhar <jar...@chromium.org>

Gerrit-Attention: Mostafa Aboalkasim <mostafa.aboal...@gmail.com>

Gerrit-Attention: Kent Tamura <tk...@chromium.org>

Gerrit-Comment-Date: Tue, 19 May 2026 14:17:21 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Mostafa Aboalkasim (Gerrit)]

Attention needed from Joey Arhar and Kent Tamura

Mostafa Aboalkasim added 3 comments

Commit Message

Line 9, Patchset 6:The HTML spec's algorithm for parsing a floating-point number" skips a

Joey Arhar . resolved

Is there supposed to be another double-quote to match this one?

Mostafa Aboalkasim

Done

File third_party/blink/renderer/core/html/parser/html_parser_idioms.cc

Line 121, Patchset 5 (Parent): // http://www.whatwg.org/specs/web-apps/current-work/#floating-point-numbers

Kent Tamura . resolved

So the URL should be updated to https://html.spec.whatwg.org/C/#rules-for-parsing-floating-point-number-values , right?

Mostafa Aboalkasim

I don't think we need to update it. The spec already mentions in the parsing algorithm that if a '+' appears before a number (e.g. "+100") [see point 8 here](https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#rules-for-parsing-floating-point-number-values), it should be skipped and the number should still be parsed. Firefox follows the same behavior as well:
https://searchfox.org/firefox-main/source/mozglue/misc/decimal/Decimal.h#234

Kent Tamura

http://www.whatwg.org/specs/web-apps/current-work/#floating-point-numbers doesn't say the leading `+` is acceptable, and https://html.spec.whatwg.org/C/#rules-for-parsing-floating-point-number-values says it's acceptable. The comment should point to https://html.spec.whatwg.org/C/#rules-for-parsing-floating-point-number-values, I think.

Mostafa Aboalkasim

Done

File third_party/blink/web_tests/external/wpt/html/semantics/forms/the-input-element/number.html

File-level comment, Patchset 6:

Joey Arhar . resolved

Will other browsers pass this test with the changes? It looks like they're already passing without this, so perhaps they wouldn't? https://wpt.fyi/results/html/semantics/forms/the-input-element/number.html

Mostafa Aboalkasim

Done

Open in Gerrit

Related details

Attention is currently required from:

• Joey Arhar
• Kent Tamura

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I033aad1a261eead7d8aeac3f3344efa16da7712e

Gerrit-Change-Number: 7832192

Gerrit-PatchSet: 12

Gerrit-Owner: Mostafa Aboalkasim <mostafa.aboal...@gmail.com>

Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Mostafa Aboalkasim <mostafa.aboal...@gmail.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Joey Arhar <jar...@chromium.org>

Gerrit-Attention: Kent Tamura <tk...@chromium.org>

Gerrit-Comment-Date: Tue, 19 May 2026 14:27:43 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Joey Arhar <jar...@chromium.org>

[Joey Arhar (Gerrit)]

Attention needed from Kent Tamura and Mostafa Aboalkasim

Joey Arhar voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Kent Tamura
• Mostafa Aboalkasim

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I033aad1a261eead7d8aeac3f3344efa16da7712e

Gerrit-Change-Number: 7832192

Gerrit-PatchSet: 13

Gerrit-Owner: Mostafa Aboalkasim <mostafa.aboal...@gmail.com>

Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Mostafa Aboalkasim <mostafa.aboal...@gmail.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Mostafa Aboalkasim <mostafa.aboal...@gmail.com>

Gerrit-Attention: Kent Tamura <tk...@chromium.org>

Gerrit-Comment-Date: Tue, 19 May 2026 17:54:52 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Kent Tamura (Gerrit)]

Attention needed from Mostafa Aboalkasim

Kent Tamura voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Mostafa Aboalkasim

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I033aad1a261eead7d8aeac3f3344efa16da7712e

Gerrit-Change-Number: 7832192

Gerrit-PatchSet: 13

Gerrit-Owner: Mostafa Aboalkasim <mostafa.aboal...@gmail.com>

Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Mostafa Aboalkasim <mostafa.aboal...@gmail.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Mostafa Aboalkasim <mostafa.aboal...@gmail.com>

Gerrit-Comment-Date: Wed, 20 May 2026 02:38:50 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes