Bundle custom user timings into existing throttled IPC [chromium/src : main]

0 views

Skip to first unread message

Takashi Toyoshima (Gerrit)

unread,

Feb 19, 2026, 3:45:46 AM (yesterday) Feb 19

to Shunya Shishido, Keita Suzuki, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, ipc-securi...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

Attention needed from Keita Suzuki and Shunya Shishido

Takashi Toyoshima voted and added 4 comments

Votes added by Takashi Toyoshima

Code-Review

4 comments

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Takashi Toyoshima . resolved

LGTM with nits

File components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc

Line 1106, Patchset 10 (Latest): feature_list.InitWithFeatures({},

Takashi Toyoshima . unresolved

nit: InitAndDisableFeature(features::kThrottleSendingCustomUserTimings) is more common for such a simple case?

Line 1122, Patchset 10 (Latest): base::test::ScopedFeatureList feature_list;

Takashi Toyoshima . unresolved

ditto; InitAndEnableFeature

Or, can we just make the existing test parameterized?

File components/page_load_metrics/renderer/page_timing_metrics_sender.cc

Line 368, Patchset 10 (Latest):

Takashi Toyoshima . unresolved

nit: We don't need to call clear()s for moved members?

Open in Gerrit

Related details

Attention is currently required from:

Keita Suzuki
Shunya Shishido

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages