Implement shadowrootslotassignment for declarative shadow roots [chromium/src : main]

0 views
Skip to first unread message

Felipe Erias (Gerrit)

unread,
Jun 8, 2026, 11:30:56 PM (3 days ago) Jun 8
to Mason Freed, David Baron, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, android-web...@chromium.org, ashleynewson+watch...@chromium.org, peter+watch...@chromium.org, ashleynewson+watch-...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from David Baron and Mason Freed

Felipe Erias added 1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Felipe Erias . resolved

Hello,

I've added you as reviewers following the comments on crbug.com/493315747 but if you're busy or there's somebody else who might be a better fit, just let me know and I'll reassign.

This CL implements the `shadowrootslotassignment` attribute, following a recent WHATWG issue:

This fixes several Interop WPT failures.

Thank you and best regards,
Felipe

Open in Gerrit

Related details

Attention is currently required from:
  • David Baron
  • Mason Freed
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ibbdc390ae3ce71a5a15c7fadc77b5aacb0e20ab9
Gerrit-Change-Number: 7893946
Gerrit-PatchSet: 5
Gerrit-Owner: Felipe Erias <felip...@igalia.com>
Gerrit-Reviewer: David Baron <dba...@chromium.org>
Gerrit-Reviewer: Felipe Erias <felip...@igalia.com>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-Attention: Mason Freed <mas...@chromium.org>
Gerrit-Attention: David Baron <dba...@chromium.org>
Gerrit-Comment-Date: Tue, 09 Jun 2026 03:30:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

David Baron (Gerrit)

unread,
Jun 9, 2026, 10:19:16 AM (2 days ago) Jun 9
to Felipe Erias, David Baron, Mason Freed, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, android-web...@chromium.org, ashleynewson+watch...@chromium.org, peter+watch...@chromium.org, ashleynewson+watch-...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from Felipe Erias and Mason Freed

David Baron voted and added 1 comment

Votes added by David Baron

Code-Review+1

1 comment

Patchset-level comments
David Baron . unresolved

I think this needs a feature flag in runtime_enabled_features.json5 and maybe also an intent, but otherwise this LGTM.

(Mason might have some more comments than I do, though.)

Open in Gerrit

Related details

Attention is currently required from:
  • Felipe Erias
  • Mason Freed
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibbdc390ae3ce71a5a15c7fadc77b5aacb0e20ab9
    Gerrit-Change-Number: 7893946
    Gerrit-PatchSet: 5
    Gerrit-Owner: Felipe Erias <felip...@igalia.com>
    Gerrit-Reviewer: David Baron <dba...@chromium.org>
    Gerrit-Reviewer: Felipe Erias <felip...@igalia.com>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-CC: Daniel Cheng <dch...@chromium.org>
    Gerrit-Attention: Mason Freed <mas...@chromium.org>
    Gerrit-Attention: Felipe Erias <felip...@igalia.com>
    Gerrit-Comment-Date: Tue, 09 Jun 2026 14:19:01 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Mason Freed (Gerrit)

    unread,
    Jun 9, 2026, 12:06:07 PM (2 days ago) Jun 9
    to Felipe Erias, David Baron, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, android-web...@chromium.org, ashleynewson+watch...@chromium.org, peter+watch...@chromium.org, ashleynewson+watch-...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
    Attention needed from Felipe Erias

    Mason Freed added 2 comments

    Patchset-level comments
    David Baron . unresolved

    I think this needs a feature flag in runtime_enabled_features.json5 and maybe also an intent, but otherwise this LGTM.

    (Mason might have some more comments than I do, though.)

    Mason Freed

    +1 to both of these. I'm on the fence between a full I2S and just a web-facing change PSA. I think this is small enough and non-breaking enough that a PSA is likely ok here.

    Mason Freed . unresolved

    This also looks good to me, but does need a runtime feature flag and a PSA. Please link the PSA in the commit description when you have it. And the feature flag can default to `"stable"` state, but should come with a comment above it linking to a bug, saying what it does, and including that it ships in M151 and can be removed in M153.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Felipe Erias
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibbdc390ae3ce71a5a15c7fadc77b5aacb0e20ab9
    Gerrit-Change-Number: 7893946
    Gerrit-PatchSet: 5
    Gerrit-Owner: Felipe Erias <felip...@igalia.com>
    Gerrit-Reviewer: David Baron <dba...@chromium.org>
    Gerrit-Reviewer: Felipe Erias <felip...@igalia.com>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-CC: Daniel Cheng <dch...@chromium.org>
    Gerrit-Attention: Felipe Erias <felip...@igalia.com>
    Gerrit-Comment-Date: Tue, 09 Jun 2026 16:05:45 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: David Baron <dba...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    David Baron (Gerrit)

    unread,
    Jun 10, 2026, 10:22:50 AM (yesterday) Jun 10
    to Felipe Erias, David Baron, Mason Freed, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, android-web...@chromium.org, ashleynewson+watch...@chromium.org, peter+watch...@chromium.org, ashleynewson+watch-...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
    Attention needed from Felipe Erias

    David Baron voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Felipe Erias
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibbdc390ae3ce71a5a15c7fadc77b5aacb0e20ab9
    Gerrit-Change-Number: 7893946
    Gerrit-PatchSet: 6
    Gerrit-Owner: Felipe Erias <felip...@igalia.com>
    Gerrit-Reviewer: David Baron <dba...@chromium.org>
    Gerrit-Reviewer: Felipe Erias <felip...@igalia.com>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-CC: Daniel Cheng <dch...@chromium.org>
    Gerrit-Attention: Felipe Erias <felip...@igalia.com>
    Gerrit-Comment-Date: Wed, 10 Jun 2026 14:22:36 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Felipe Erias (Gerrit)

    unread,
    Jun 10, 2026, 9:45:30 PM (yesterday) Jun 10
    to David Baron, Mason Freed, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, android-web...@chromium.org, ashleynewson+watch...@chromium.org, peter+watch...@chromium.org, ashleynewson+watch-...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
    Attention needed from Mason Freed

    Felipe Erias added 1 comment

    Patchset-level comments
    Mason Freed . unresolved

    This also looks good to me, but does need a runtime feature flag and a PSA. Please link the PSA in the commit description when you have it. And the feature flag can default to `"stable"` state, but should come with a comment above it linking to a bug, saying what it does, and including that it ships in M151 and can be removed in M153.

    Attention is currently required from:
    • Mason Freed
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibbdc390ae3ce71a5a15c7fadc77b5aacb0e20ab9
    Gerrit-Change-Number: 7893946
    Gerrit-PatchSet: 7
    Gerrit-Owner: Felipe Erias <felip...@igalia.com>
    Gerrit-Reviewer: David Baron <dba...@chromium.org>
    Gerrit-Reviewer: Felipe Erias <felip...@igalia.com>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-CC: Daniel Cheng <dch...@chromium.org>
    Gerrit-Attention: Mason Freed <mas...@chromium.org>
    Gerrit-Comment-Date: Thu, 11 Jun 2026 01:44:55 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Mason Freed <mas...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages