[bedrock] Remove remaining BrowserList::GetLastActive() calls from test code [chromium/src : main]

0 views
Skip to first unread message

Alex Carutasu (Gerrit)

unread,
Sep 11, 2025, 10:26:31 PM (7 days ago) Sep 11
to Tom Lukaszewicz, Chandranath Bhattacharyya, Kevin DiClemente, Rijubrata Bhaumik, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, chrome-gr...@chromium.org, devtools...@chromium.org, chfreme...@chromium.org, abigailbk...@google.com, bmcquad...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-setti...@google.com, csharris...@chromium.org, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gogerald+pa...@chromium.org, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, nektar...@chromium.org, npnavarro+p...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rouslan+...@chromium.org, rrsilva+wat...@google.com, sloboda...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, xiaohui...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Tom Lukaszewicz

Alex Carutasu voted and added 1 comment

Votes added by Alex Carutasu

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Alex Carutasu . resolved

Adding initial reviewers.

Open in Gerrit

Related details

Attention is currently required from:
  • Tom Lukaszewicz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I416ae4805575075ee508c6a8a1e457b584a36c8f
Gerrit-Change-Number: 6938998
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Carutasu <alca...@microsoft.com>
Gerrit-Reviewer: Alex Carutasu <alca...@microsoft.com>
Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Chandranath Bhattacharyya <chb...@microsoft.com>
Gerrit-CC: Kevin DiClemente <ked...@microsoft.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-Comment-Date: Fri, 12 Sep 2025 02:26:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Tom Lukaszewicz (Gerrit)

unread,
Sep 12, 2025, 1:59:28 AM (7 days ago) Sep 12
to Alex Carutasu, Hidehiko Abe, Chandranath Bhattacharyya, Kevin DiClemente, Rijubrata Bhaumik, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, chrome-gr...@chromium.org, devtools...@chromium.org, chfreme...@chromium.org, abigailbk...@google.com, bmcquad...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-setti...@google.com, csharris...@chromium.org, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gogerald+pa...@chromium.org, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, nektar...@chromium.org, npnavarro+p...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rouslan+...@chromium.org, rrsilva+wat...@google.com, sloboda...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, xiaohui...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Alex Carutasu and Hidehiko Abe

Tom Lukaszewicz voted and added 2 comments

Votes added by Tom Lukaszewicz

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Tom Lukaszewicz . resolved

lgtm!
Hidehiko could you ptal

File chrome/browser/ash/app_mode/kiosk_troubleshooting_tools_browsertest.cc
Line 259, Patchset 6 (Latest): EXPECT_FALSE(IsLastActiveBrowserResizable());
Tom Lukaszewicz . resolved

Nice catch

Open in Gerrit

Related details

Attention is currently required from:
  • Alex Carutasu
  • Hidehiko Abe
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I416ae4805575075ee508c6a8a1e457b584a36c8f
Gerrit-Change-Number: 6938998
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Carutasu <alca...@microsoft.com>
Gerrit-Reviewer: Alex Carutasu <alca...@microsoft.com>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Chandranath Bhattacharyya <chb...@microsoft.com>
Gerrit-CC: Kevin DiClemente <ked...@microsoft.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
Gerrit-Attention: Alex Carutasu <alca...@microsoft.com>
Gerrit-Comment-Date: Fri, 12 Sep 2025 05:59:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Hidehiko Abe (Gerrit)

unread,
Sep 12, 2025, 7:23:49 AM (7 days ago) Sep 12
to Alex Carutasu, Tom Lukaszewicz, Chandranath Bhattacharyya, Kevin DiClemente, Rijubrata Bhaumik, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, chrome-gr...@chromium.org, devtools...@chromium.org, chfreme...@chromium.org, abigailbk...@google.com, bmcquad...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-setti...@google.com, csharris...@chromium.org, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gogerald+pa...@chromium.org, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, nektar...@chromium.org, npnavarro+p...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rouslan+...@chromium.org, rrsilva+wat...@google.com, sloboda...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, xiaohui...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Alex Carutasu

Hidehiko Abe voted and added 2 comments

Votes added by Hidehiko Abe

Code-Review+1

2 comments

Patchset-level comments
Hidehiko Abe . resolved

LGTM.

File chrome/browser/ash/accessibility/DEPS
Line 41, Patchset 6 (Latest): "+chrome/browser/ui/browser_list.h",
Hidehiko Abe . unresolved

clarification: do we still need browser_list.h? Ditto for other DEPS updates.

Open in Gerrit

Related details

Attention is currently required from:
  • Alex Carutasu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I416ae4805575075ee508c6a8a1e457b584a36c8f
Gerrit-Change-Number: 6938998
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Carutasu <alca...@microsoft.com>
Gerrit-Reviewer: Alex Carutasu <alca...@microsoft.com>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Chandranath Bhattacharyya <chb...@microsoft.com>
Gerrit-CC: Kevin DiClemente <ked...@microsoft.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-Attention: Alex Carutasu <alca...@microsoft.com>
Gerrit-Comment-Date: Fri, 12 Sep 2025 11:23:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Alex Carutasu (Gerrit)

unread,
Sep 16, 2025, 5:07:21 AM (3 days ago) Sep 16
to Hidehiko Abe, Tom Lukaszewicz, Chandranath Bhattacharyya, Kevin DiClemente, Rijubrata Bhaumik, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, chrome-gr...@chromium.org, devtools...@chromium.org, chfreme...@chromium.org, abigailbk...@google.com, bmcquad...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-setti...@google.com, csharris...@chromium.org, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gogerald+pa...@chromium.org, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, nektar...@chromium.org, npnavarro+p...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rouslan+...@chromium.org, rrsilva+wat...@google.com, sloboda...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, xiaohui...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Hidehiko Abe and Tom Lukaszewicz

Alex Carutasu voted and added 1 comment

Votes added by Alex Carutasu

Commit-Queue+1

1 comment

File chrome/browser/ash/accessibility/DEPS
Line 41, Patchset 6: "+chrome/browser/ui/browser_list.h",
Hidehiko Abe . resolved

clarification: do we still need browser_list.h? Ditto for other DEPS updates.

Alex Carutasu

Thanks for the tip, I was able to remove browser_list.h from a couple of the DEPS files, including this one.

The rest still have BrowserList references in their folders though.

Open in Gerrit

Related details

Attention is currently required from:
  • Hidehiko Abe
  • Tom Lukaszewicz
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I416ae4805575075ee508c6a8a1e457b584a36c8f
    Gerrit-Change-Number: 6938998
    Gerrit-PatchSet: 8
    Gerrit-Owner: Alex Carutasu <alca...@microsoft.com>
    Gerrit-Reviewer: Alex Carutasu <alca...@microsoft.com>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Chandranath Bhattacharyya <chb...@microsoft.com>
    Gerrit-CC: Kevin DiClemente <ked...@microsoft.com>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Comment-Date: Tue, 16 Sep 2025 09:07:11 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Hidehiko Abe <hide...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Hidehiko Abe (Gerrit)

    unread,
    Sep 16, 2025, 6:59:25 AM (3 days ago) Sep 16
    to Alex Carutasu, Tom Lukaszewicz, Chandranath Bhattacharyya, Kevin DiClemente, Rijubrata Bhaumik, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, chrome-gr...@chromium.org, devtools...@chromium.org, chfreme...@chromium.org, abigailbk...@google.com, bmcquad...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-setti...@google.com, csharris...@chromium.org, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gogerald+pa...@chromium.org, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, nektar...@chromium.org, npnavarro+p...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rouslan+...@chromium.org, rrsilva+wat...@google.com, sloboda...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, xiaohui...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org
    Attention needed from Alex Carutasu and Tom Lukaszewicz

    Hidehiko Abe added 1 comment

    Patchset-level comments
    File-level comment, Patchset 8 (Latest):
    Hidehiko Abe . resolved

    could you fix bot failures?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alex Carutasu
    • Tom Lukaszewicz
    Gerrit-Attention: Alex Carutasu <alca...@microsoft.com>
    Gerrit-Comment-Date: Tue, 16 Sep 2025 10:58:57 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Alex Carutasu (Gerrit)

    unread,
    Sep 16, 2025, 1:43:22 PM (3 days ago) Sep 16
    to Hidehiko Abe, Tom Lukaszewicz, Chandranath Bhattacharyya, Kevin DiClemente, Rijubrata Bhaumik, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, chrome-gr...@chromium.org, devtools...@chromium.org, chfreme...@chromium.org, abigailbk...@google.com, bmcquad...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-setti...@google.com, csharris...@chromium.org, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gogerald+pa...@chromium.org, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, nektar...@chromium.org, npnavarro+p...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rouslan+...@chromium.org, rrsilva+wat...@google.com, sloboda...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, xiaohui...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org
    Attention needed from Hidehiko Abe and Tom Lukaszewicz

    Alex Carutasu voted and added 1 comment

    Votes added by Alex Carutasu

    Commit-Queue+1

    1 comment

    Patchset-level comments
    Hidehiko Abe . resolved

    could you fix bot failures?

    Alex Carutasu

    Fixed, there was a remaining unneeded browser_list.h include somewhere.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Hidehiko Abe
    • Tom Lukaszewicz
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I416ae4805575075ee508c6a8a1e457b584a36c8f
    Gerrit-Change-Number: 6938998
    Gerrit-PatchSet: 9
    Gerrit-Owner: Alex Carutasu <alca...@microsoft.com>
    Gerrit-Reviewer: Alex Carutasu <alca...@microsoft.com>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Chandranath Bhattacharyya <chb...@microsoft.com>
    Gerrit-CC: Kevin DiClemente <ked...@microsoft.com>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Comment-Date: Tue, 16 Sep 2025 17:43:08 +0000
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Tom Lukaszewicz (Gerrit)

    unread,
    Sep 16, 2025, 3:35:16 PM (3 days ago) Sep 16
    to Alex Carutasu, Hidehiko Abe, Chandranath Bhattacharyya, Kevin DiClemente, Rijubrata Bhaumik, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, chrome-gr...@chromium.org, devtools...@chromium.org, chfreme...@chromium.org, abigailbk...@google.com, bmcquad...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-setti...@google.com, csharris...@chromium.org, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gogerald+pa...@chromium.org, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, nektar...@chromium.org, npnavarro+p...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rouslan+...@chromium.org, rrsilva+wat...@google.com, sloboda...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, xiaohui...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org
    Attention needed from Alex Carutasu and Hidehiko Abe

    Tom Lukaszewicz voted and added 1 comment

    Votes added by Tom Lukaszewicz

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 9 (Latest):
    Tom Lukaszewicz . resolved

    still lgtm

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alex Carutasu
    • Hidehiko Abe
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I416ae4805575075ee508c6a8a1e457b584a36c8f
    Gerrit-Change-Number: 6938998
    Gerrit-PatchSet: 9
    Gerrit-Owner: Alex Carutasu <alca...@microsoft.com>
    Gerrit-Reviewer: Alex Carutasu <alca...@microsoft.com>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Chandranath Bhattacharyya <chb...@microsoft.com>
    Gerrit-CC: Kevin DiClemente <ked...@microsoft.com>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Attention: Alex Carutasu <alca...@microsoft.com>
    Gerrit-Attention: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Comment-Date: Tue, 16 Sep 2025 19:34:48 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Hidehiko Abe (Gerrit)

    unread,
    Sep 17, 2025, 6:05:09 AM (2 days ago) Sep 17
    to Alex Carutasu, Tom Lukaszewicz, Chandranath Bhattacharyya, Kevin DiClemente, Rijubrata Bhaumik, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, chrome-gr...@chromium.org, devtools...@chromium.org, chfreme...@chromium.org, abigailbk...@google.com, bmcquad...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-setti...@google.com, csharris...@chromium.org, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gogerald+pa...@chromium.org, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, nektar...@chromium.org, npnavarro+p...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rouslan+...@chromium.org, rrsilva+wat...@google.com, sloboda...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, xiaohui...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org
    Attention needed from Alex Carutasu

    Hidehiko Abe voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alex Carutasu
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I416ae4805575075ee508c6a8a1e457b584a36c8f
    Gerrit-Change-Number: 6938998
    Gerrit-PatchSet: 9
    Gerrit-Owner: Alex Carutasu <alca...@microsoft.com>
    Gerrit-Reviewer: Alex Carutasu <alca...@microsoft.com>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Chandranath Bhattacharyya <chb...@microsoft.com>
    Gerrit-CC: Kevin DiClemente <ked...@microsoft.com>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Attention: Alex Carutasu <alca...@microsoft.com>
    Gerrit-Comment-Date: Wed, 17 Sep 2025 10:04:36 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Alex Carutasu (Gerrit)

    unread,
    Sep 17, 2025, 6:25:32 AM (2 days ago) Sep 17
    to Hidehiko Abe, Tom Lukaszewicz, Chandranath Bhattacharyya, Kevin DiClemente, Rijubrata Bhaumik, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, chrome-gr...@chromium.org, devtools...@chromium.org, chfreme...@chromium.org, abigailbk...@google.com, bmcquad...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-setti...@google.com, csharris...@chromium.org, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gogerald+pa...@chromium.org, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, nektar...@chromium.org, npnavarro+p...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rouslan+...@chromium.org, rrsilva+wat...@google.com, sloboda...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, xiaohui...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org

    Alex Carutasu voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I416ae4805575075ee508c6a8a1e457b584a36c8f
    Gerrit-Change-Number: 6938998
    Gerrit-PatchSet: 9
    Gerrit-Owner: Alex Carutasu <alca...@microsoft.com>
    Gerrit-Reviewer: Alex Carutasu <alca...@microsoft.com>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Chandranath Bhattacharyya <chb...@microsoft.com>
    Gerrit-CC: Kevin DiClemente <ked...@microsoft.com>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-Comment-Date: Wed, 17 Sep 2025 10:25:18 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 17, 2025, 7:08:13 AM (2 days ago) Sep 17
    to Alex Carutasu, Hidehiko Abe, Tom Lukaszewicz, Chandranath Bhattacharyya, Kevin DiClemente, Rijubrata Bhaumik, AyeAye, Akihiro Ota, chromium...@chromium.org, (Julie)Jeongeun Kim, chrome-gr...@chromium.org, devtools...@chromium.org, chfreme...@chromium.org, abigailbk...@google.com, bmcquad...@chromium.org, chromeos-kio...@google.com, chromium-a...@chromium.org, croissant-...@chromium.org, cros-print...@google.com, cros-setti...@google.com, csharris...@chromium.org, derinel+wat...@google.com, dibyapal+wa...@chromium.org, dmblac...@google.com, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, gogerald+pa...@chromium.org, hirokisa...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, loyso...@chromium.org, mgiuca...@chromium.org, nektar...@chromium.org, npnavarro+p...@chromium.org, oshima...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, rginda...@chromium.org, rouslan+...@chromium.org, rrsilva+wat...@google.com, sloboda...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, webap...@microsoft.com, webauthn...@chromium.org, xiaohui...@chromium.org, yuzo+...@chromium.org, zelin+watch-we...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [bedrock] Remove remaining BrowserList::GetLastActive() calls from test code

    This CL migrates the remaining test code callsites of
    BrowserList::GetLastActive() to
    GetLastActiveBrowserWindowInterfaceWithAnyProfile().

    Notes:
    - Refactored related utilities where necessary and possible to use
    BrowserWindowInterface over Browser to support migrating the
    GetLastActive() callsites.

    - Used GetBrowserForMigrationOnly() in a few spots where refactoring the
    related code to use BrowserWindowInterface was non-trivial.

    - Added some GN and DEPS file exceptions to enable using
    browser_window_interface*.h includes.
    Bug: 431671448
    Change-Id: I416ae4805575075ee508c6a8a1e457b584a36c8f
    Reviewed-by: Tom Lukaszewicz <tl...@chromium.org>
    Commit-Queue: Alex Carutasu <alca...@microsoft.com>
    Reviewed-by: Hidehiko Abe <hide...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1516547}
    Files:
    • M chrome/browser/apps/app_service/media_access_browsertest.cc
    • M chrome/browser/ash/accessibility/DEPS
    • M chrome/browser/ash/accessibility/accessibility_extension_api_browsertest.cc
    • M chrome/browser/ash/accessibility/accessibility_feature_browsertest.cc
    • M chrome/browser/ash/app_mode/DEPS
    • M chrome/browser/ash/app_mode/kiosk_troubleshooting_tools_browsertest.cc
    • M chrome/browser/ash/app_mode/test/kiosk_browsertest.cc
    • M chrome/browser/ash/app_restore/full_restore_app_launch_handler_browsertest.cc
    • M chrome/browser/ash/child_accounts/time_limits/web_time_calculation_browsertest.cc
    • M chrome/browser/ash/file_manager/DEPS
    • M chrome/browser/ash/file_manager/file_manager_browsertest_base.cc
    • M chrome/browser/ash/printing/print_management/print_management_printer_settings_interactive_uitest.cc
    • M chrome/browser/chromeos/extensions/odfs_config_private/DEPS
    • M chrome/browser/chromeos/extensions/odfs_config_private/odfs_config_private_api_browsertest.cc
    • M chrome/browser/devtools/devtools_browsertest.cc
    • M chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc
    • M chrome/browser/extensions/extension_tab_util_browsertest.cc
    • M chrome/browser/media/media_engagement_browsertest.cc
    • M chrome/browser/new_tab_page/modules/new_tab_page_modules_interactive_uitest.cc
    • M chrome/browser/page_load_metrics/observers/ash_session_restore_page_load_metrics_observer_browsertest.cc
    • M chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
    • M chrome/browser/performance_manager/policies/page_discarding_helper_browsertest.cc
    • M chrome/browser/resource_coordinator/tab_manager_browsertest.cc
    • M chrome/browser/sessions/session_restore_interactive_uitest.cc
    • M chrome/browser/sessions/session_restore_observer_browsertest.cc
    • M chrome/browser/shortcuts/shortcut_launch_browsertest.cc
    • M chrome/browser/ui/ash/gemini_app/DEPS
    • M chrome/browser/ui/ash/gemini_app/gemini_app_interactive_uitest.cc
    • M chrome/browser/ui/browser_list_browsertest.cc
    • M chrome/browser/ui/fullscreen_keyboard_browsertest_base.cc
    • M chrome/browser/ui/fullscreen_keyboard_browsertest_base.h
    • M chrome/browser/ui/keyboard_lock_interactive_browsertest.cc
    • M chrome/browser/ui/webui/ash/settings/pages/printing/integration_tests/DEPS
    • M chrome/browser/ui/webui/ash/settings/pages/printing/integration_tests/printer_settings_integration_test.cc
    • M chrome/browser/web_applications/chromeos_web_app_experiments_browsertest.cc
    • M chrome/browser/webauthn/webauthn_focus_interactive_uitest.cc
    • M chrome/test/BUILD.gn
    Change size: L
    Delta: 37 files changed, 308 insertions(+), 246 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Tom Lukaszewicz, +1 by Hidehiko Abe
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I416ae4805575075ee508c6a8a1e457b584a36c8f
    Gerrit-Change-Number: 6938998
    Gerrit-PatchSet: 10
    Gerrit-Owner: Alex Carutasu <alca...@microsoft.com>
    Gerrit-Reviewer: Alex Carutasu <alca...@microsoft.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
    Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Chandranath Bhattacharyya <chb...@microsoft.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages