Remove deprecated RenderFrameObserver methods and fully transition to callbacks. [chromium/src : main]

0 views
Skip to first unread message

Shunya Shishido (Gerrit)

unread,
Jul 29, 2026, 8:33:15 PM (2 days ago) Jul 29
to Dave Tapuska, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, navigation...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, creis...@chromium.org, speed-metrics...@chromium.org, loading-rev...@chromium.org, alexmo...@chromium.org, bmcquad...@chromium.org
Attention needed from Dave Tapuska

Shunya Shishido added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Shunya Shishido . resolved

Thanks for working on this! But we have a plan to run the holdback study, so currently we can't remove this.

Open in Gerrit

Related details

Attention is currently required from:
  • Dave Tapuska
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1022d87bc2c6594e7e703eaa6d4bdf57581a5b1f
Gerrit-Change-Number: 8165488
Gerrit-PatchSet: 1
Gerrit-Owner: Dave Tapuska <dtap...@chromium.org>
Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>
Gerrit-Comment-Date: Thu, 30 Jul 2026 00:32:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Dave Tapuska (Gerrit)

unread,
Jul 29, 2026, 9:52:53 PM (2 days ago) Jul 29
to Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Shunya Shishido, navigation...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, creis...@chromium.org, speed-metrics...@chromium.org, loading-rev...@chromium.org, alexmo...@chromium.org, bmcquad...@chromium.org
Attention needed from Shunya Shishido

Dave Tapuska added 1 comment

Patchset-level comments
Shunya Shishido . unresolved

Thanks for working on this! But we have a plan to run the holdback study, so currently we can't remove this.

Dave Tapuska

This has been enabled in stable for over 6 months now. I think the timeline for a holdback study really has passed. What is the motivation for the holdback study?

Open in Gerrit

Related details

Attention is currently required from:
  • Shunya Shishido
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1022d87bc2c6594e7e703eaa6d4bdf57581a5b1f
    Gerrit-Change-Number: 8165488
    Gerrit-PatchSet: 1
    Gerrit-Owner: Dave Tapuska <dtap...@chromium.org>
    Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
    Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
    Gerrit-Attention: Shunya Shishido <sisid...@chromium.org>
    Gerrit-Comment-Date: Thu, 30 Jul 2026 01:52:42 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Shunya Shishido <sisid...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Shunya Shishido (Gerrit)

    unread,
    12:56 AM (5 hours ago) 12:56 AM
    to Dave Tapuska, Kouhei Ueno, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, navigation...@chromium.org, csharris...@chromium.org, speed-metr...@chromium.org, creis...@chromium.org, speed-metrics...@chromium.org, loading-rev...@chromium.org, alexmo...@chromium.org, bmcquad...@chromium.org
    Attention needed from Dave Tapuska and Kouhei Ueno

    Shunya Shishido added 1 comment

    Patchset-level comments
    Shunya Shishido . unresolved

    Thanks for working on this! But we have a plan to run the holdback study, so currently we can't remove this.

    Dave Tapuska

    This has been enabled in stable for over 6 months now. I think the timeline for a holdback study really has passed. What is the motivation for the holdback study?

    Shunya Shishido

    That's correct. But we plan to conduct an aggregated holdback study in around Q4 to measure year-long impact within the team.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dave Tapuska
    • Kouhei Ueno
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1022d87bc2c6594e7e703eaa6d4bdf57581a5b1f
    Gerrit-Change-Number: 8165488
    Gerrit-PatchSet: 1
    Gerrit-Owner: Dave Tapuska <dtap...@chromium.org>
    Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
    Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
    Gerrit-Attention: Kouhei Ueno <kou...@chromium.org>
    Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>
    Gerrit-Comment-Date: Fri, 31 Jul 2026 04:56:40 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Shunya Shishido <sisid...@chromium.org>
    Comment-In-Reply-To: Dave Tapuska <dtap...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages