remove old local network request UKM stats [chromium/src : main]

0 views
Skip to first unread message

Hubert Chao (Gerrit)

unread,
Jan 29, 2026, 4:43:54 PM (yesterday) Jan 29
to Luca Invernizzi, Sun Yueru, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Luca Invernizzi and Sun Yueru

Hubert Chao added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Hubert Chao . resolved

@inver...@google.com general approval as metric owner

@yr...@chromium.org: tools/metrics/ukm/ukm.xml

Open in Gerrit

Related details

Attention is currently required from:
  • Luca Invernizzi
  • Sun Yueru
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iec504002581a618a81a306d38c399dccbfea3344
Gerrit-Change-Number: 7525572
Gerrit-PatchSet: 2
Gerrit-Owner: Hubert Chao <hc...@chromium.org>
Gerrit-Reviewer: Hubert Chao <hc...@chromium.org>
Gerrit-Reviewer: Luca Invernizzi <inver...@google.com>
Gerrit-Reviewer: Sun Yueru <yr...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Luca Invernizzi <inver...@google.com>
Gerrit-Attention: Sun Yueru <yr...@chromium.org>
Gerrit-Comment-Date: Thu, 29 Jan 2026 21:43:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Hubert Chao (Gerrit)

unread,
Jan 29, 2026, 4:45:22 PM (yesterday) Jan 29
to Minoru Chikamune, Luca Invernizzi, Sun Yueru, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Luca Invernizzi, Minoru Chikamune and Sun Yueru

Hubert Chao added 1 comment

Patchset-level comments
Hubert Chao . resolved

@chik...@chromium.org: chrome/browser/page_load_metrics/*

Open in Gerrit

Related details

Attention is currently required from:
  • Luca Invernizzi
  • Minoru Chikamune
  • Sun Yueru
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iec504002581a618a81a306d38c399dccbfea3344
Gerrit-Change-Number: 7525572
Gerrit-PatchSet: 2
Gerrit-Owner: Hubert Chao <hc...@chromium.org>
Gerrit-Reviewer: Hubert Chao <hc...@chromium.org>
Gerrit-Reviewer: Luca Invernizzi <inver...@google.com>
Gerrit-Reviewer: Minoru Chikamune <chik...@chromium.org>
Gerrit-Reviewer: Sun Yueru <yr...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Minoru Chikamune <chik...@chromium.org>
Gerrit-Attention: Luca Invernizzi <inver...@google.com>
Gerrit-Attention: Sun Yueru <yr...@chromium.org>
Gerrit-Comment-Date: Thu, 29 Jan 2026 21:45:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Minoru Chikamune (Gerrit)

unread,
Jan 29, 2026, 7:24:57 PM (yesterday) Jan 29
to Hubert Chao, Minoru Chikamune, Luca Invernizzi, Sun Yueru, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Hubert Chao, Luca Invernizzi and Sun Yueru

Minoru Chikamune voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Hubert Chao
  • Luca Invernizzi
  • Sun Yueru
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iec504002581a618a81a306d38c399dccbfea3344
    Gerrit-Change-Number: 7525572
    Gerrit-PatchSet: 3
    Gerrit-Owner: Hubert Chao <hc...@chromium.org>
    Gerrit-Reviewer: Hubert Chao <hc...@chromium.org>
    Gerrit-Reviewer: Luca Invernizzi <inver...@google.com>
    Gerrit-Reviewer: Minoru Chikamune <chik...@chromium.org>
    Gerrit-Reviewer: Sun Yueru <yr...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Luca Invernizzi <inver...@google.com>
    Gerrit-Attention: Sun Yueru <yr...@chromium.org>
    Gerrit-Attention: Hubert Chao <hc...@chromium.org>
    Gerrit-Comment-Date: Fri, 30 Jan 2026 00:24:22 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Luca Invernizzi (Gerrit)

    unread,
    3:15 AM (21 hours ago) 3:15 AM
    to Hubert Chao, Minoru Chikamune, Sun Yueru, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
    Attention needed from Hubert Chao and Sun Yueru

    Luca Invernizzi added 1 comment

    Patchset-level comments
    File-level comment, Patchset 3 (Latest):
    Luca Invernizzi . resolved

    LGTM

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Hubert Chao
    • Sun Yueru
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iec504002581a618a81a306d38c399dccbfea3344
    Gerrit-Change-Number: 7525572
    Gerrit-PatchSet: 3
    Gerrit-Owner: Hubert Chao <hc...@chromium.org>
    Gerrit-Reviewer: Hubert Chao <hc...@chromium.org>
    Gerrit-Reviewer: Luca Invernizzi <inver...@google.com>
    Gerrit-Reviewer: Minoru Chikamune <chik...@chromium.org>
    Gerrit-Reviewer: Sun Yueru <yr...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Sun Yueru <yr...@chromium.org>
    Gerrit-Attention: Hubert Chao <hc...@chromium.org>
    Gerrit-Comment-Date: Fri, 30 Jan 2026 08:15:19 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Sun Yueru (Gerrit)

    unread,
    3:34 PM (8 hours ago) 3:34 PM
    to Hubert Chao, Minoru Chikamune, Luca Invernizzi, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
    Attention needed from Hubert Chao

    Sun Yueru voted and added 1 comment

    Votes added by Sun Yueru

    Code-Review+1

    1 comment

    Patchset-level comments
    Sun Yueru . resolved

    Thanks for cleaning up unused UKMs!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Hubert Chao
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iec504002581a618a81a306d38c399dccbfea3344
    Gerrit-Change-Number: 7525572
    Gerrit-PatchSet: 3
    Gerrit-Owner: Hubert Chao <hc...@chromium.org>
    Gerrit-Reviewer: Hubert Chao <hc...@chromium.org>
    Gerrit-Reviewer: Luca Invernizzi <inver...@google.com>
    Gerrit-Reviewer: Minoru Chikamune <chik...@chromium.org>
    Gerrit-Reviewer: Sun Yueru <yr...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Hubert Chao <hc...@chromium.org>
    Gerrit-Comment-Date: Fri, 30 Jan 2026 20:34:17 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Hubert Chao (Gerrit)

    unread,
    4:02 PM (8 hours ago) 4:02 PM
    to Sun Yueru, Minoru Chikamune, Luca Invernizzi, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

    Hubert Chao voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iec504002581a618a81a306d38c399dccbfea3344
    Gerrit-Change-Number: 7525572
    Gerrit-PatchSet: 3
    Gerrit-Owner: Hubert Chao <hc...@chromium.org>
    Gerrit-Reviewer: Hubert Chao <hc...@chromium.org>
    Gerrit-Reviewer: Luca Invernizzi <inver...@google.com>
    Gerrit-Reviewer: Minoru Chikamune <chik...@chromium.org>
    Gerrit-Reviewer: Sun Yueru <yr...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Comment-Date: Fri, 30 Jan 2026 21:01:59 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    5:11 PM (7 hours ago) 5:11 PM
    to Hubert Chao, Sun Yueru, Minoru Chikamune, Luca Invernizzi, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    remove old local network request UKM stats

    found these as part of my Local Network Access (LNA) work, but they
    don't match what we'd need for LNA stats, and they are unused as far as
    I can tell.

    Chatted w/ metric owner, invernizzi@ said its safe to remove.
    Change-Id: Iec504002581a618a81a306d38c399dccbfea3344
    Reviewed-by: Minoru Chikamune <chik...@chromium.org>
    Reviewed-by: Sun Yueru <yr...@chromium.org>
    Commit-Queue: Hubert Chao <hc...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1577543}
    Files:
    • M chrome/browser/BUILD.gn
    • D chrome/browser/page_load_metrics/observers/local_network_requests_page_load_metrics_observer.cc
    • D chrome/browser/page_load_metrics/observers/local_network_requests_page_load_metrics_observer.h
    • D chrome/browser/page_load_metrics/observers/local_network_requests_page_load_metrics_observer_unittest.cc
    • M chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
    • M chrome/test/BUILD.gn
    • M tools/metrics/ukm/ukm.xml
    Change size: XL
    Delta: 7 files changed, 0 insertions(+), 1147 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Minoru Chikamune, +1 by Sun Yueru
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iec504002581a618a81a306d38c399dccbfea3344
    Gerrit-Change-Number: 7525572
    Gerrit-PatchSet: 4
    Gerrit-Owner: Hubert Chao <hc...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Hubert Chao <hc...@chromium.org>
    Gerrit-Reviewer: Luca Invernizzi <inver...@google.com>
    Gerrit-Reviewer: Minoru Chikamune <chik...@chromium.org>
    Gerrit-Reviewer: Sun Yueru <yr...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages