[soft navs] In UKM, always attribute the soft navigation to the intended URL. [chromium/src : main]

0 views

Skip to first unread message

Johannes Henkel (Gerrit)

unread,

Nov 1, 2025, 2:58:34 PM (5 days ago) Nov 1

to Annie Sullivan, Scott Haseley, Michal Mocny, Chromium LUCI CQ, AyeAye, blink-...@chromium.org, core-web-vita...@chromium.org, speed-metr...@chromium.org, csharris...@chromium.org, blink-re...@chromium.org, core-timi...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org

Attention needed from Annie Sullivan, Michal Mocny and Scott Haseley

Johannes Henkel added 1 comment

File third_party/blink/renderer/core/timing/soft_navigation_heuristics.cc

Line 312, Patchset 17 (Latest):void SoftNavigationHeuristics::SameDocumentNavigationCommitted(

Johannes Henkel . unresolved

Note to myself: This needs to be called at least for all committed same document navs in the main frame. I think at the moment we filter some out at the call site, e.g. the replacestate, we'll need to do the filtering in here so we can still get the count correctly... or do the count in the caller.

Open in Gerrit

Related details

Attention is currently required from:

Annie Sullivan
Michal Mocny
Scott Haseley

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages