Revert "Homogenize NTP loadtime histogram between C++ and Java" [chromium/src : main]
0 views
Skip to first unread message
Shunya Shishido (Gerrit)
Jul 30, 2026, 8:42:10 PM (9 hours ago) Jul 30
to rubber-...@appspot.gserviceaccount.com, Aldo Culquicondor, Chromium LUCI CQ, Ian Clelland, Tibor Goldschwendt, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, speed-metr...@chromium.org, hanxi...@chromium.org, loading-rev...@chromium.org, csharris...@chromium.org, bmcquad...@chromium.org, speed-metrics...@chromium.org, asvitkine...@chromium.org, ntp-dev...@chromium.org
Attention needed from Aldo Culquicondor, Ian Clelland and Tibor Goldschwendt
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Aldo Culquicondor
- Ian Clelland
- Tibor Goldschwendt
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
rubber-stamper@appspot.gserviceaccount.com (Gerrit)
Jul 30, 2026, 8:42:22 PM (9 hours ago) Jul 30
to Shunya Shishido, Aldo Culquicondor, Chromium LUCI CQ, Ian Clelland, Tibor Goldschwendt, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, speed-metr...@chromium.org, hanxi...@chromium.org, loading-rev...@chromium.org, csharris...@chromium.org, bmcquad...@chromium.org, speed-metrics...@chromium.org, asvitkine...@chromium.org, ntp-dev...@chromium.org
Attention needed from Aldo Culquicondor, Ian Clelland and Tibor Goldschwendt
rubber-...@appspot.gserviceaccount.com voted Bot-Commit+1![]( "Open in Gerrit")
| Bot-Commit | +1 |
Related details
Attention is currently required from:
- Aldo Culquicondor
- Ian Clelland
- Tibor Goldschwendt
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Shunya Shishido (Gerrit)
Jul 30, 2026, 8:44:05 PM (9 hours ago) Jul 30
to rubber-...@appspot.gserviceaccount.com, Aldo Culquicondor, Chromium LUCI CQ, Ian Clelland, Tibor Goldschwendt, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, speed-metr...@chromium.org, hanxi...@chromium.org, loading-rev...@chromium.org, csharris...@chromium.org, bmcquad...@chromium.org, speed-metrics...@chromium.org, asvitkine...@chromium.org, ntp-dev...@chromium.org
Attention needed from Aldo Culquicondor, Ian Clelland and Tibor Goldschwendt
Shunya Shishido voted![]( "Open in Gerrit")
| Commit-Queue | +2 |
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Aldo Culquicondor
- Ian Clelland
- Tibor Goldschwendt
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 30, 2026, 8:44:42 PM (9 hours ago) Jul 30
to Shunya Shishido, rubber-...@appspot.gserviceaccount.com, Aldo Culquicondor, Ian Clelland, Tibor Goldschwendt, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, speed-metr...@chromium.org, hanxi...@chromium.org, loading-rev...@chromium.org, csharris...@chromium.org, bmcquad...@chromium.org, speed-metrics...@chromium.org, asvitkine...@chromium.org, ntp-dev...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "Homogenize NTP loadtime histogram between C++ and Java"
This reverts commit 69687e601640975cff478878700c476c4d5f26d2.
Reason for revert: NewTabPagePageLoadMetricsBrowserTest#MetricsAreRecordedForNTP is failing on multiple platforms.
Failure Link: https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-rel/105589/overview
Original change's description:
> Homogenize NTP loadtime histogram between C++ and Java
>
> NewTabPage.LoadTime.FirstContentfulPaint is now replaced by
> NewTabPage.LoadTime.FirstContentfulPaint2, which correctly matches the
> buckets between the Java and C++ uses.
>
> NewTabPage.LoadTime.FirstContentfulPaint is still recorded for Android
> desktop.
>
> Bug: 531793117
> Change-Id: I057dbee5c9606bf09d5db6d8466dc06a6ed2b4df
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/8171446
> Reviewed-by: Ian Clelland <icle...@chromium.org>
> Reviewed-by: Tibor Goldschwendt <tib...@chromium.org>
> Commit-Queue: Aldo Culquicondor <aco...@chromium.org>
> Auto-Submit: Aldo Culquicondor <aco...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1671446}
Bug: 531793117, 540973617
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 531793117
Change-Id: I117fbf8e8a2ac46a332b8de2633c3cba3fdefc54
Commit-Queue: Shunya Shishido <sisid...@chromium.org>
Owners-Override: Shunya Shishido <sisid...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1671553}
Files:
- M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
- M chrome/browser/page_load_metrics/observers/new_tab_page_page_load_metrics_observer.cc
- M chrome/browser/page_load_metrics/observers/new_tab_page_page_load_metrics_observer.h
- M components/page_load_metrics/browser/page_load_metrics_util.h
- M tools/metrics/histograms/metadata/new_tab_page/histograms.xml
Change size: S
Delta: 5 files changed, 6 insertions(+), 42 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: Bot-Commit+1 by rubber-...@appspot.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages