Track navigations that ignored duplicate requests for GWS metrics [chromium/src : main]

[Anna Sato (Gerrit)]

Attention needed from Rakina Zata Amni

Anna Sato voted and added 1 comment

Votes added by Anna Sato

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Anna Sato . resolved

Could you take a look when you have time?

Open in Gerrit

Related details

Attention is currently required from:

• Rakina Zata Amni

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9208b930200e337bc42d327affe815d77d5be9bd

Gerrit-Change-Number: 7710564

Gerrit-PatchSet: 5

Gerrit-Owner: Anna Sato <anna...@chromium.org>

Gerrit-Reviewer: Anna Sato <anna...@chromium.org>

Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Comment-Date: Tue, 31 Mar 2026 07:00:33 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Rakina Zata Amni (Gerrit)]

Attention needed from Anna Sato

Rakina Zata Amni added 4 comments

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Rakina Zata Amni . resolved

Thanks!

Commit Message

Line 19, Patchset 5 (Latest):rates and performance across different experimental settings.

Rakina Zata Amni . unresolved

I wonder if it's worth adding the UMAs for number of duplicate navs ignored per navigation as well (so using a count instead of just a bool)?

Line 24, Patchset 5 (Latest):

Rakina Zata Amni . unresolved

Can you add a bug number?

File content/common/frame.mojom

Line 715, Patchset 5 (Latest): DidIgnoreDuplicateNavs();

Rakina Zata Amni . unresolved

nit: I know this is following the flag, but since this is triggered for one ignored navigation, let's drop the "s" and maybe also use "Navigation" instead of "Navs" (same in the other names on the interface / functions).

Open in Gerrit

Related details

Attention is currently required from:

• Anna Sato

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9208b930200e337bc42d327affe815d77d5be9bd

Gerrit-Change-Number: 7710564

Gerrit-PatchSet: 5

Gerrit-Owner: Anna Sato <anna...@chromium.org>

Gerrit-Reviewer: Anna Sato <anna...@chromium.org>

Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Attention: Anna Sato <anna...@chromium.org>

Gerrit-Comment-Date: Wed, 01 Apr 2026 03:50:35 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Anna Sato (Gerrit)]

Attention needed from Rakina Zata Amni

Anna Sato added 4 comments

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Anna Sato . resolved

Thanks so much for the review! PTAL again?

Commit Message

Line 19, Patchset 5:rates and performance across different experimental settings.

Rakina Zata Amni . resolved

I wonder if it's worth adding the UMAs for number of duplicate navs ignored per navigation as well (so using a count instead of just a bool)?

Anna Sato

Added the "Navigation.DuplicateNavigationsIgnoredCountPerNavigation" histogram, recorded during `NavigationRequest::DidCommitNavigation()`.

Line 24, Patchset 5:

Rakina Zata Amni . resolved

Can you add a bug number?

Anna Sato

Added

File content/common/frame.mojom

Line 715, Patchset 5: DidIgnoreDuplicateNavs();

Rakina Zata Amni . resolved

nit: I know this is following the flag, but since this is triggered for one ignored navigation, let's drop the "s" and maybe also use "Navigation" instead of "Navs" (same in the other names on the interface / functions).

Anna Sato

Changed them to `NavigationRendererIgnoreDuplicateNavigationListener`/`DidIgnoreDuplicateNavigation`.

Open in Gerrit

Related details

Attention is currently required from:

• Rakina Zata Amni

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9208b930200e337bc42d327affe815d77d5be9bd

Gerrit-Change-Number: 7710564

Gerrit-PatchSet: 7

Gerrit-Owner: Anna Sato <anna...@chromium.org>

Gerrit-Reviewer: Anna Sato <anna...@chromium.org>

Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Comment-Date: Thu, 02 Apr 2026 03:55:35 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Rakina Zata Amni <rak...@chromium.org>

[Anna Sato (Gerrit)]

Anna Sato voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9208b930200e337bc42d327affe815d77d5be9bd

Gerrit-Change-Number: 7710564

Gerrit-PatchSet: 9

Gerrit-Owner: Anna Sato <anna...@chromium.org>

Gerrit-Reviewer: Anna Sato <anna...@chromium.org>

Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-Comment-Date: Thu, 02 Apr 2026 08:07:31 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Rakina Zata Amni (Gerrit)]

Attention needed from Anna Sato

Rakina Zata Amni voted and added 3 comments

Votes added by Rakina Zata Amni

Code-Review

+1

3 comments

Patchset-level comments

File-level comment, Patchset 9 (Latest):

Rakina Zata Amni . resolved

LGTM % some changes, thanks!

File content/browser/renderer_host/navigation_request.cc

Line 2004, Patchset 9 (Latest): GetUIThreadTaskRunner({BrowserTaskType::kNavigationNetworkResponse}));

Rakina Zata Amni . unresolved

I think this one can be kDefault instead, since it's not as critical as cancellation

File content/renderer/navigation_client.cc

Line 175, Patchset 9 (Latest): blink::TaskType::kInternalNavigationCancellation));

Rakina Zata Amni . unresolved

Maybe `kInternalNavigationAssociated` is more appropriate here

Open in Gerrit

Related details

Attention is currently required from:

• Anna Sato

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9208b930200e337bc42d327affe815d77d5be9bd

Gerrit-Change-Number: 7710564

Gerrit-PatchSet: 9

Gerrit-Owner: Anna Sato <anna...@chromium.org>

Gerrit-Reviewer: Anna Sato <anna...@chromium.org>

Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-Attention: Anna Sato <anna...@chromium.org>

Gerrit-Comment-Date: Fri, 03 Apr 2026 01:57:34 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Anna Sato (Gerrit)]

Attention needed from Takashi Toyoshima

Anna Sato voted and added 3 comments

Votes added by Anna Sato

Commit-Queue

+1

3 comments

Patchset-level comments

File-level comment, Patchset 10 (Latest):

Anna Sato . resolved

PTAL?

File content/browser/renderer_host/navigation_request.cc

Line 2004, Patchset 9: GetUIThreadTaskRunner({BrowserTaskType::kNavigationNetworkResponse}));

Rakina Zata Amni . resolved

I think this one can be kDefault instead, since it's not as critical as cancellation

Anna Sato

Understand. Done.

File content/renderer/navigation_client.cc

Line 175, Patchset 9: blink::TaskType::kInternalNavigationCancellation));

Rakina Zata Amni . resolved

Maybe `kInternalNavigationAssociated` is more appropriate here

Anna Sato

Done

Open in Gerrit

Related details

Attention is currently required from:

• Takashi Toyoshima

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9208b930200e337bc42d327affe815d77d5be9bd

Gerrit-Change-Number: 7710564

Gerrit-PatchSet: 10

Gerrit-Owner: Anna Sato <anna...@chromium.org>

Gerrit-Reviewer: Anna Sato <anna...@chromium.org>

Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>

Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>

Gerrit-Comment-Date: Fri, 03 Apr 2026 07:40:44 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes