Measure performance of UpdateSubresourceLoadMetrics [chromium/src : main]
0 views
Skip to first unread message
Shunya Shishido (Gerrit)
Sep 11, 2025, 4:56:53 AM (8 days ago) Sep 11
to Yoshisato Yanagisawa, Minoru Chikamune, chromium...@chromium.org, Chromium Metrics Reviews, Nate Chapin, AyeAye, Chromium LUCI CQ, loading...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, gavinp...@chromium.org
Attention needed from Minoru Chikamune and Yoshisato Yanagisawa
Shunya Shishido voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Minoru Chikamune
- Yoshisato Yanagisawa
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yoshisato Yanagisawa (Gerrit)
Sep 11, 2025, 5:06:12 AM (7 days ago) Sep 11
to Shunya Shishido, Minoru Chikamune, chromium...@chromium.org, Chromium Metrics Reviews, Nate Chapin, AyeAye, Chromium LUCI CQ, loading...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, gavinp...@chromium.org
Attention needed from Minoru Chikamune and Shunya Shishido
Yoshisato Yanagisawa voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Minoru Chikamune
- Shunya Shishido
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Minoru Chikamune (Gerrit)
Sep 11, 2025, 5:10:54 AM (7 days ago) Sep 11
to Shunya Shishido, Minoru Chikamune, Yoshisato Yanagisawa, chromium...@chromium.org, Chromium Metrics Reviews, Nate Chapin, AyeAye, Chromium LUCI CQ, loading...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, gavinp...@chromium.org
Attention needed from Shunya Shishido
Minoru Chikamune voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Shunya Shishido
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Takashi Toyoshima (Gerrit)
Sep 12, 2025, 2:30:14 AM (7 days ago) Sep 12
to Shunya Shishido, Jiacheng Guo, Minoru Chikamune, Yoshisato Yanagisawa, chromium...@chromium.org, Chromium Metrics Reviews, Nate Chapin, AyeAye, Chromium LUCI CQ, loading...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, gavinp...@chromium.org
Attention needed from Jiacheng Guo and Shunya Shishido
Takashi Toyoshima voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Jiacheng Guo
- Shunya Shishido
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Shunya Shishido (Gerrit)
Sep 12, 2025, 2:31:12 AM (7 days ago) Sep 12
to Takashi Toyoshima, Jiacheng Guo, Minoru Chikamune, Yoshisato Yanagisawa, chromium...@chromium.org, Chromium Metrics Reviews, Nate Chapin, AyeAye, Chromium LUCI CQ, loading...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, gavinp...@chromium.org
Attention needed from Jiacheng Guo
Shunya Shishido voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Jiacheng Guo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 12, 2025, 2:35:19 AM (7 days ago) Sep 12
to Shunya Shishido, Takashi Toyoshima, Jiacheng Guo, Minoru Chikamune, Yoshisato Yanagisawa, chromium...@chromium.org, Chromium Metrics Reviews, Nate Chapin, AyeAye, loading...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, gavinp...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Measure performance of UpdateSubresourceLoadMetrics
To better understand the performance cost of observing subresource loads,
this change introduces a UMA metric to track the time spent in the
`UpdateSubresourceLoadMetrics` function.
The execution time for each call to this function is measured and
accumulated in `DocumentLoader`. The total time is then recorded in the
histogram when the parsing is completed. This data will inform future
efforts to optimize the PageLoadMetrics sender and reduce
RenderFrameObserver calls.
Bug: 404425954
Change-Id: Idaa4fd067b235e821a0f4a83d5b3cbe28b8dcdd1
Reviewed-by: Yoshisato Yanagisawa <yyana...@chromium.org>
Reviewed-by: Takashi Toyoshima <toyo...@chromium.org>
Commit-Queue: Shunya Shishido <sisid...@chromium.org>
Reviewed-by: Minoru Chikamune <chik...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1514681}
Files:
- M third_party/blink/renderer/core/dom/document.cc
- M third_party/blink/renderer/core/loader/document_loader.cc
- M third_party/blink/renderer/core/loader/document_loader.h
- M tools/metrics/histograms/metadata/blink/histograms.xml
Change size: S
Delta: 4 files changed, 35 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Takashi Toyoshima, +1 by Yoshisato Yanagisawa, +1 by Minoru Chikamune
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jiacheng Guo (Gerrit)
Sep 12, 2025, 3:00:24 AM (7 days ago) Sep 12
to Shunya Shishido, Chromium LUCI CQ, Takashi Toyoshima, Minoru Chikamune, Yoshisato Yanagisawa, chromium...@chromium.org, Chromium Metrics Reviews, Nate Chapin, AyeAye, loading...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, gavinp...@chromium.org
Jiacheng Guo voted Code-Review+1![]( "Open in Gerrit")
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages