Always use XML syntax for processing instruction attributes [chromium/src : main]

[Philip Jägenstedt (Gerrit)]

Attention needed from Noam Rosenthal

Philip Jägenstedt voted and added 1 comment

Votes added by Philip Jägenstedt

Code-Review

+1

1 comment

File third_party/blink/renderer/core/html/parser/html_document_parser_test.cc

Line 412, Patchset 5 (Latest): pi->setData("name=n > value=v");

Philip Jägenstedt . unresolved

Simplify this test to just test the quoting and not also the behavior of >?

```suggestion
  pi->setData("name=n");
```

And a separate test for "name=\"n\">" which should not work, right?

Open in Gerrit

Related details

Attention is currently required from:

• Noam Rosenthal

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9f9a14c73a0d41ff21ef263465e110669444e3a7

Gerrit-Change-Number: 7849046

Gerrit-PatchSet: 5

Gerrit-Owner: Noam Rosenthal <nrose...@google.com>

Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>

Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Noam Rosenthal <nrose...@google.com>

Gerrit-Comment-Date: Tue, 19 May 2026 12:39:37 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Noam Rosenthal (Gerrit)]

Noam Rosenthal added 1 comment

File third_party/blink/renderer/core/html/parser/html_document_parser_test.cc

Line 412, Patchset 5: pi->setData("name=n > value=v");

Philip Jägenstedt . resolved

Simplify this test to just test the quoting and not also the behavior of >?

```suggestion
  pi->setData("name=n");
```

And a separate test for "name=\"n\">" which should not work, right?

Noam Rosenthal

Fix applied. I don't think we should add more unit-tests... These scenarios are covered by WPT

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9f9a14c73a0d41ff21ef263465e110669444e3a7

Gerrit-Change-Number: 7849046

Gerrit-PatchSet: 6

Gerrit-Owner: Noam Rosenthal <nrose...@google.com>

Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>

Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Tue, 19 May 2026 12:55:40 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Philip Jägenstedt <foo...@chromium.org>

[Noam Rosenthal (Gerrit)]

Noam Rosenthal voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9f9a14c73a0d41ff21ef263465e110669444e3a7

Gerrit-Change-Number: 7849046

Gerrit-PatchSet: 6

Gerrit-Owner: Noam Rosenthal <nrose...@google.com>

Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>

Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Tue, 19 May 2026 12:55:44 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Blink W3C Test Autoroller (Gerrit)]

Message from Blink W3C Test Autoroller

Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/59977.

When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I9f9a14c73a0d41ff21ef263465e110669444e3a7

Gerrit-Change-Number: 7849046

Gerrit-PatchSet: 6

Gerrit-Owner: Noam Rosenthal <nrose...@google.com>

Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>

Gerrit-Reviewer: Philip Jägenstedt <foo...@chromium.org>

Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Comment-Date: Tue, 19 May 2026 13:16:20 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No