[SAA] Remove unused storage access metrics [chromium/src : main]
0 views
Skip to first unread message
Chris Fredrickson (Gerrit)
Nov 2, 2025, 10:54:31 AM (4 days ago) Nov 2
to Robert Kaplow, Adam Rice, Avi Drissman, Daniel Rubery, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, alexmo...@chromium.org, bmcquad...@chromium.org, kinuko...@chromium.org, speed-metrics...@chromium.org, creis...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, navigation...@chromium.org, cfredri...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, csharris...@chromium.org, asvitkine...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, ricea...@chromium.org
Attention needed from Adam Rice, Avi Drissman, Daniel Rubery and Robert Kaplow
Chris Fredrickson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Chris Fredrickson
| Auto-Submit | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Chris Fredrickson . resolved
+rkaplow for ukm_features.cc;
+avi for content/browser/renderer_host/cookie_utils.cc;
+ricea for //net and //services/network;
+drubery for tools/metrics/histograms/metadata/net.
Related details
Attention is currently required from:
- Adam Rice
- Avi Drissman
- Daniel Rubery
- Robert Kaplow
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Avi Drissman (Gerrit)
Nov 2, 2025, 7:32:01 PM (4 days ago) Nov 2
to Chris Fredrickson, Avi Drissman, Robert Kaplow, Adam Rice, Daniel Rubery, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, alexmo...@chromium.org, bmcquad...@chromium.org, kinuko...@chromium.org, speed-metrics...@chromium.org, creis...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, navigation...@chromium.org, cfredri...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, csharris...@chromium.org, asvitkine...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, ricea...@chromium.org
Attention needed from Adam Rice, Chris Fredrickson, Daniel Rubery and Robert Kaplow
Avi Drissman voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Adam Rice
- Chris Fredrickson
- Daniel Rubery
- Robert Kaplow
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Rubery (Gerrit)
Nov 3, 2025, 11:26:52 AM (3 days ago) Nov 3
to Chris Fredrickson, Avi Drissman, Robert Kaplow, Adam Rice, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, alexmo...@chromium.org, bmcquad...@chromium.org, kinuko...@chromium.org, speed-metrics...@chromium.org, creis...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, navigation...@chromium.org, cfredri...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, csharris...@chromium.org, asvitkine...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, ricea...@chromium.org
Attention needed from Adam Rice, Chris Fredrickson and Robert Kaplow
Daniel Rubery voted and added 1 comment![]( "Open in Gerrit")
Votes added by Daniel Rubery
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Adam Rice
- Chris Fredrickson
- Robert Kaplow
Robert Kaplow (Gerrit)
Nov 3, 2025, 11:53:02 AM (3 days ago) Nov 3
to Chris Fredrickson, Daniel Rubery, Avi Drissman, Adam Rice, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, alexmo...@chromium.org, bmcquad...@chromium.org, kinuko...@chromium.org, speed-metrics...@chromium.org, creis...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, navigation...@chromium.org, cfredri...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, csharris...@chromium.org, asvitkine...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, ricea...@chromium.org
Attention needed from Adam Rice and Chris Fredrickson
Robert Kaplow voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Adam Rice
- Chris Fredrickson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Rice (Gerrit)
Nov 5, 2025, 6:53:18 AM (yesterday) Nov 5
to Chris Fredrickson, Robert Kaplow, Daniel Rubery, Avi Drissman, AyeAye, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, alexmo...@chromium.org, bmcquad...@chromium.org, kinuko...@chromium.org, speed-metrics...@chromium.org, creis...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, navigation...@chromium.org, cfredri...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, csharris...@chromium.org, asvitkine...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, ricea...@chromium.org
Attention needed from Chris Fredrickson
Adam Rice voted and added 1 comment![]( "Open in Gerrit")
Votes added by Adam Rice
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Adam Rice . resolved
lgtm. Thanks for the cleanup! This saves a few net::SchemefulSite lookups, and those are expensive.
Related details
Attention is currently required from:
- Chris Fredrickson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 5, 2025, 7:42:57 AM (yesterday) Nov 5
to Chris Fredrickson, Adam Rice, Robert Kaplow, Daniel Rubery, Avi Drissman, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, alexmo...@chromium.org, bmcquad...@chromium.org, kinuko...@chromium.org, speed-metrics...@chromium.org, creis...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, navigation...@chromium.org, cfredri...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org, csharris...@chromium.org, asvitkine...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, ricea...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[SAA] Remove unused storage access metrics
These metrics were used to measure compat impact before shipping the
feature, but are no longer needed.
OBSOLETE_HISTOGRAMS=These metrics were only used to measure possible breakage before launch, and are now unused.
Bug: 332335089
Change-Id: I332128b1aaf9c7a8b90c27957c5bf98e4ba12b28
Reviewed-by: Robert Kaplow <rka...@chromium.org>
Auto-Submit: Chris Fredrickson <cfre...@chromium.org>
Reviewed-by: Adam Rice <ri...@chromium.org>
Commit-Queue: Adam Rice <ri...@chromium.org>
Reviewed-by: Avi Drissman <a...@chromium.org>
Reviewed-by: Daniel Rubery <dru...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1540575}
Files:
- M chrome/browser/storage_access_api/api_browsertest.cc
- M components/page_load_metrics/browser/observers/use_counter/ukm_features.cc
- M content/browser/renderer_host/cookie_utils.cc
- M net/cookies/cookie_util.cc
- M net/cookies/cookie_util.h
- M net/websockets/websocket_stream.cc
- M services/network/url_loader.cc
- M services/network/url_loader_util.cc
- M third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom
- M tools/metrics/histograms/metadata/blink/enums.xml
- M tools/metrics/histograms/metadata/net/enums.xml
- M tools/metrics/histograms/metadata/net/histograms.xml
Change size: M
Delta: 12 files changed, 9 insertions(+), 235 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Robert Kaplow, +1 by Daniel Rubery, +1 by Adam Rice, +1 by Avi Drissman
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages