Revert "[soft navs] Improve CLS test coverage." [chromium/src : main]
0 views
Skip to first unread message
Xinghui Lu (Gerrit)
May 18, 2026, 7:15:28 PM (2 days ago) May 18
to Xinghui Lu, android-bu...@system.gserviceaccount.com, rubber-...@appspot.gserviceaccount.com, Johannes Henkel, Scott Haseley, Chromium LUCI CQ, Annie Sullivan, chromium...@chromium.org, csharris...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org
Attention needed from Annie Sullivan, Johannes Henkel and Scott Haseley
Xinghui Lu voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
| Owners-Override | +1 |
Related details
Attention is currently required from:
- Annie Sullivan
- Johannes Henkel
- Scott Haseley
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
rubber-stamper@appspot.gserviceaccount.com (Gerrit)
May 18, 2026, 7:16:32 PM (2 days ago) May 18
to Xinghui Lu, android-bu...@system.gserviceaccount.com, Johannes Henkel, Scott Haseley, Chromium LUCI CQ, Annie Sullivan, chromium...@chromium.org, csharris...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org
Attention needed from Annie Sullivan, Johannes Henkel and Scott Haseley
rubber-...@appspot.gserviceaccount.com voted![]( "Open in Gerrit")
| Bot-Commit | +1 |
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Annie Sullivan
- Johannes Henkel
- Scott Haseley
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 18, 2026, 7:16:39 PM (2 days ago) May 18
to Xinghui Lu, rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Johannes Henkel, Scott Haseley, Annie Sullivan, chromium...@chromium.org, csharris...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Revert "[soft navs] Improve CLS test coverage."
This reverts commit b12db17c1ee1f4644cdf3ef7dd90769ea20e957c.
Reason for revert: caused timeout issue in linux-wayland-weston-rel-tests. https://ci.chromium.org/ui/p/chromium/builders/ci/linux-wayland-weston-rel-tests/14104/overview
Original change's description:
> [soft navs] Improve CLS test coverage.
>
> * Add coverage for softnav CLS after prerender and bfcache restores.
> * Migrate CLS coverage for regular page loads
> (SoftNavigationTest.LayoutShift) to use
> soft_navigation_basics.html, instead of soft_navigation.html, as
> it's drastically simpler.
> * Due to the migration, SoftNavigationTest::GetCLSFromList is no
> longer needed. Note that the replacement does not perform the
> session window / gap algorithm, instead, it assumes that some
> adjacent layout shifts are going to be expressed as their sum
> in UKM. I think this is good enough, as the window / gap stuff
> is tested elsewhere.
>
> For now, I'm doing exact comparisons (EXPECT_EQ) between the ukm CLS
> values and the values coming from the renderer. I'm hoping that we can
> get away with this and not see flakes (haven't seen any thus far), even
> though the values from the renderer may have added noise and get
> converted to integral values by rounding. But the alternative with
> converting to double and EXPECT_NEAR like it's done in
> layout_instability_browsertest.cc etc. seems less appealing because the
> typical 1.0 allowed error may end up missing salient differences.
>
> Bug: 496610192
> Change-Id: I2e77ce9ff8085f3677bbe8636bbc621609cca80d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7842929
> Reviewed-by: Scott Haseley <shas...@chromium.org>
> Commit-Queue: Johannes Henkel <joha...@chromium.org>
> Reviewed-by: Annie Sullivan <sull...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1632379}
Bug: 496610192
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: I44ff2a159eaad8a9fbcdc1e36c7b0e18dbeb672a
Auto-Submit: Xinghui Lu <xing...@chromium.org>
Owners-Override: Xinghui Lu <xing...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1632462}
Files:
- M chrome/browser/page_load_metrics/integration_tests/data/soft_navigation_basics.html
- M chrome/browser/page_load_metrics/integration_tests/soft_navigation_metrics_browsertest.cc
Change size: L
Delta: 2 files changed, 141 insertions(+), 342 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: Bot-Commit+1 by rubber-...@appspot.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johannes Henkel (Gerrit)
May 19, 2026, 2:49:29 AM (yesterday) May 19
to Xinghui Lu, Chromium LUCI CQ, rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, Scott Haseley, Annie Sullivan, chromium...@chromium.org, csharris...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, loading-rev...@chromium.org, bmcquad...@chromium.org
Johannes Henkel has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages