[PageLoadMetrics] Segment GWS DNS delay by source [chromium/src : main]

0 views
Skip to first unread message

Kenichi Ishibashi (Gerrit)

unread,
4:56 AM (16 hours ago) 4:56 AM
to Takashi Toyoshima, Rakina Zata Amni, Chromium Metrics Reviews, AyeAye, chromium...@chromium.org, Chromium LUCI CQ, asvitkine...@chromium.org, net-r...@chromium.org, bnc+...@chromium.org, alexmo...@chromium.org, bmcquad...@chromium.org, creis...@chromium.org, csharris...@chromium.org, ipc-securi...@chromium.org, loading-rev...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Rakina Zata Amni and Takashi Toyoshima

Kenichi Ishibashi added 2 comments

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Kenichi Ishibashi . resolved

toyoshim@: PTAL
rakina@: PTAL //content

I'd like to submit this before the M148 branch cut.

File content/public/browser/navigation_handle_timing.h
Line 37, Patchset 4 (Latest): std::optional<net::ResolutionSource> resolution_source;
Kenichi Ishibashi . unresolved

I plan to extend this to pass ResolutionDetails itself to add further histograms.

Open in Gerrit

Related details

Attention is currently required from:
  • Rakina Zata Amni
  • Takashi Toyoshima
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifa343b7a5a5813c6cf908884f7f97432412444bc
Gerrit-Change-Number: 7725965
Gerrit-PatchSet: 4
Gerrit-Owner: Kenichi Ishibashi <ba...@chromium.org>
Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>
Gerrit-Comment-Date: Fri, 03 Apr 2026 08:55:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Rakina Zata Amni (Gerrit)

unread,
5:05 AM (16 hours ago) 5:05 AM
to Kenichi Ishibashi, Takashi Toyoshima, Chromium Metrics Reviews, AyeAye, chromium...@chromium.org, Chromium LUCI CQ, asvitkine...@chromium.org, net-r...@chromium.org, bnc+...@chromium.org, alexmo...@chromium.org, bmcquad...@chromium.org, creis...@chromium.org, csharris...@chromium.org, ipc-securi...@chromium.org, loading-rev...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Kenichi Ishibashi and Takashi Toyoshima

Rakina Zata Amni voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kenichi Ishibashi
  • Takashi Toyoshima
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifa343b7a5a5813c6cf908884f7f97432412444bc
    Gerrit-Change-Number: 7725965
    Gerrit-PatchSet: 4
    Gerrit-Owner: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Comment-Date: Fri, 03 Apr 2026 09:04:29 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Takashi Toyoshima (Gerrit)

    unread,
    7:23 AM (14 hours ago) 7:23 AM
    to Kenichi Ishibashi, Rakina Zata Amni, Chromium Metrics Reviews, AyeAye, chromium...@chromium.org, Chromium LUCI CQ, asvitkine...@chromium.org, net-r...@chromium.org, bnc+...@chromium.org, alexmo...@chromium.org, bmcquad...@chromium.org, creis...@chromium.org, csharris...@chromium.org, ipc-securi...@chromium.org, loading-rev...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
    Attention needed from Kenichi Ishibashi

    Takashi Toyoshima voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Kenichi Ishibashi
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifa343b7a5a5813c6cf908884f7f97432412444bc
    Gerrit-Change-Number: 7725965
    Gerrit-PatchSet: 4
    Gerrit-Owner: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Comment-Date: Fri, 03 Apr 2026 11:22:36 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages