Make sure the new streaming parser invalidates CSS correctly [chromium/src : main]

0 views

Skip to first unread message

Philip Jägenstedt (Gerrit)

unread,

Dec 12, 2025, 4:38:20 AM (5 days ago) Dec 12

to Noam Rosenthal, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, loading-rev...@chromium.org, kinuko...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Noam Rosenthal

Philip Jägenstedt added 2 comments

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Philip Jägenstedt . resolved

The commit message talks about insertions, but only removals are changed here. Are insertions already not treated as parser-inserted?

File third_party/blink/renderer/core/html/parser/html_construction_site.cc

Line 295, Patchset 5 (Latest): task.parent->RemoveChildren();

Philip Jägenstedt . unresolved

Can you leave a comment here explaining why it's not ParserRemoveChildren() as one might expect from the surrounding code?

Open in Gerrit

Related details

Attention is currently required from:

Noam Rosenthal

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Noam Rosenthal (Gerrit)

unread,

Dec 15, 2025, 6:30:44 AM (yesterday) Dec 15

to Philip Jägenstedt, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, loading-rev...@chromium.org, kinuko...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention needed from Philip Jägenstedt

Noam Rosenthal added 2 comments

Patchset-level comments

File-level comment, Patchset 6:

Noam Rosenthal . resolved

Thanks, updated comment and CL description

File third_party/blink/renderer/core/html/parser/html_construction_site.cc

Line 295, Patchset 5: task.parent->RemoveChildren();

Philip Jägenstedt . resolved

Can you leave a comment here explaining why it's not ParserRemoveChildren() as one might expect from the surrounding code?

Noam Rosenthal

Done