[source-phase-imports] Enable Wasm module streaming for source phase [chromium/src : main]

0 views
Skip to first unread message

Issack John (Gerrit)

unread,
Jan 30, 2026, 3:59:26 PMJan 30
to Clemens Backes, Hiroshige Hayashizaki, Kouhei Ueno, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org, loading...@chromium.org
Attention needed from Clemens Backes, Hiroshige Hayashizaki and Kouhei Ueno

Message from Issack John

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • Clemens Backes
  • Hiroshige Hayashizaki
  • Kouhei Ueno
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I241dc2c7679297a43400162eacfc3d5d72fa6b7e
Gerrit-Change-Number: 7534844
Gerrit-PatchSet: 1
Gerrit-Owner: Issack John <issac...@microsoft.com>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>
Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Hiroshige Hayashizaki <hiro...@chromium.org>
Gerrit-Attention: Kouhei Ueno <kou...@chromium.org>
Gerrit-Attention: Clemens Backes <clem...@chromium.org>
Gerrit-Comment-Date: Fri, 30 Jan 2026 20:59:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Issack John (Gerrit)

unread,
Feb 2, 2026, 1:18:58 PMFeb 2
to Clemens Backes, Hiroshige Hayashizaki, Kouhei Ueno, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org, loading...@chromium.org
Attention needed from Clemens Backes, Hiroshige Hayashizaki and Kouhei Ueno

Issack John added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Issack John . resolved

clemensb@ PTAL and re‑add your +1 if everything still looks good. Thanks!

Gerrit-Comment-Date: Mon, 02 Feb 2026 18:18:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Clemens Backes (Gerrit)

unread,
Feb 3, 2026, 12:08:14 PMFeb 3
to Issack John, Hiroshige Hayashizaki, Kouhei Ueno, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org, loading...@chromium.org
Attention needed from Hiroshige Hayashizaki, Issack John and Kouhei Ueno

Clemens Backes voted and added 1 comment

Votes added by Clemens Backes

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Clemens Backes . resolved

As on the other CL, there is not much I can review. The usage of the V8 API looks good, but the main review will have to be done by blink / loading / streaming owners.

Open in Gerrit

Related details

Attention is currently required from:
  • Hiroshige Hayashizaki
  • Issack John
  • Kouhei Ueno
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I241dc2c7679297a43400162eacfc3d5d72fa6b7e
Gerrit-Change-Number: 7534844
Gerrit-PatchSet: 2
Gerrit-Owner: Issack John <issac...@microsoft.com>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>
Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Hiroshige Hayashizaki <hiro...@chromium.org>
Gerrit-Attention: Issack John <issac...@microsoft.com>
Gerrit-Attention: Kouhei Ueno <kou...@chromium.org>
Gerrit-Comment-Date: Tue, 03 Feb 2026 17:07:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Clemens Backes (Gerrit)

unread,
Feb 3, 2026, 12:08:47 PMFeb 3
to Issack John, Hiroshige Hayashizaki, Kouhei Ueno, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org, loading...@chromium.org
Attention needed from Hiroshige Hayashizaki, Issack John and Kouhei Ueno

Clemens Backes added 1 comment

Patchset-level comments
Clemens Backes . resolved

Thanks for picking this up and driving it forward, Issack!

Gerrit-Comment-Date: Tue, 03 Feb 2026 17:08:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Issack John (Gerrit)

unread,
Feb 4, 2026, 12:20:59 PMFeb 4
to Clemens Backes, Hiroshige Hayashizaki, Kouhei Ueno, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org, loading...@chromium.org
Attention needed from Hiroshige Hayashizaki and Kouhei Ueno

Issack John added 1 comment

Patchset-level comments
Issack John . resolved

hiroshige@ kouhei@ PTAL 😊

Open in Gerrit

Related details

Attention is currently required from:
  • Hiroshige Hayashizaki
  • Kouhei Ueno
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I241dc2c7679297a43400162eacfc3d5d72fa6b7e
Gerrit-Change-Number: 7534844
Gerrit-PatchSet: 2
Gerrit-Owner: Issack John <issac...@microsoft.com>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>
Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Hiroshige Hayashizaki <hiro...@chromium.org>
Gerrit-Attention: Kouhei Ueno <kou...@chromium.org>
Gerrit-Comment-Date: Wed, 04 Feb 2026 17:20:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Issack John (Gerrit)

unread,
Feb 9, 2026, 4:43:27 PM (11 days ago) Feb 9
to Clemens Backes, Hiroshige Hayashizaki, Kouhei Ueno, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org, loading...@chromium.org
Attention needed from Hiroshige Hayashizaki and Kouhei Ueno

Issack John added 1 comment

Patchset-level comments
Issack John . resolved

Gentle ping.

Gerrit-Comment-Date: Mon, 09 Feb 2026 21:43:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Issack John (Gerrit)

unread,
Feb 12, 2026, 7:31:34 PM (8 days ago) Feb 12
to Clemens Backes, Hiroshige Hayashizaki, Kouhei Ueno, chromium...@chromium.org, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org, loading...@chromium.org
Attention needed from Hiroshige Hayashizaki and Kouhei Ueno

Issack John added 1 comment

Patchset-level comments
Issack John . resolved

Another Ping. 😊

Gerrit-Comment-Date: Fri, 13 Feb 2026 00:31:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Issack John (Gerrit)

unread,
Feb 17, 2026, 3:04:20 PM (3 days ago) Feb 17
to Kentaro Hara, Clemens Backes, Hiroshige Hayashizaki, chromium...@chromium.org, Nate Chapin, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org, loading...@chromium.org
Attention needed from Hiroshige Hayashizaki and Kentaro Hara

Issack John added 1 comment

Patchset-level comments
Issack John . resolved

hiroshige@, haraken@ would you be able to help with the reivews please? Looking to get some traction here.

Open in Gerrit

Related details

Attention is currently required from:
  • Hiroshige Hayashizaki
  • Kentaro Hara
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I241dc2c7679297a43400162eacfc3d5d72fa6b7e
Gerrit-Change-Number: 7534844
Gerrit-PatchSet: 2
Gerrit-Owner: Issack John <issac...@microsoft.com>
Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Hiroshige Hayashizaki <hiro...@chromium.org>
Gerrit-Attention: Kentaro Hara <har...@chromium.org>
Gerrit-Comment-Date: Tue, 17 Feb 2026 20:04:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Alison Maher (Gerrit)

unread,
Feb 19, 2026, 11:53:04 AM (yesterday) Feb 19
to Issack John, Kouhei Ueno, Kentaro Hara, Clemens Backes, Hiroshige Hayashizaki, chromium...@chromium.org, Nate Chapin, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, dom+...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org, loading...@chromium.org
Attention needed from Hiroshige Hayashizaki, Issack John and Kentaro Hara

Alison Maher added 11 comments

File third_party/blink/renderer/bindings/core/v8/script_streamer.h
Line 104, Patchset 2 (Latest): return nullptr;
Alison Maher . unresolved

nit: any reason for this to return something vs being a pure virtual method like the others above?

File third_party/blink/renderer/bindings/core/v8/script_streamer.cc
Line 1213, Patchset 2 (Latest): friend class BackgroundStreamManager;
Alison Maher . unresolved

nit: can be moved below the JS one for alphabetical ordering

Line 1283, Patchset 2 (Latest): virtual void ResetOwnership(
Alison Maher . unresolved

nit: I'd suggest adding a comment for this one to explain what this method is doing with the various output params

Line 1298, Patchset 2 (Latest): background_processor_->PostJSResultToMainThread(nullptr, reason);
Alison Maher . unresolved

nit: This could use a param comment (example `/*param_name=*/nullptr`)

Line 1432, Patchset 2 (Latest): // `WasmModuleCompilation::Finish`, the watcher is destroyed before
Alison Maher . unresolved

nit: missing ()

File third_party/blink/renderer/bindings/core/v8/script_streamer_test.cc
Line 783, Patchset 2 (Latest):// WASM module constants
// Use string_views instead of char c-style arrays because the Wasm bytes
// include null characters.
// A valid Wasm module should start with the magic number and the version.
Alison Maher . unresolved

nit: This comment looks like it can be re-wrapped

File third_party/blink/renderer/core/loader/modulescript/module_script_loader.cc
Line 357, Patchset 2 (Latest): // `WasmModuleCompilation::Finish` which will finish the compilation
Alison Maher . unresolved

nit: missing ()

Line 359, Patchset 2 (Latest): v8::WasmModuleCompilation* wasm_module_compilation =
Alison Maher . unresolved

Should we check that this isn't nullptr?

File third_party/blink/renderer/core/script/wasm_module_script.h
Line 33, Patchset 2 (Latest): Modulator* modulator,
Alison Maher . unresolved

Is this one an input/output param? If so, it should move to the bottom of the list of vars per the style guide

File third_party/blink/renderer/core/script/wasm_module_script.cc
Line 22, Patchset 2 (Latest): Modulator* modulator,
Alison Maher . unresolved

Should this check it isn't nullptr

Line 103, Patchset 2 (Latest): ScriptState* script_state = modulator->GetScriptState();
Alison Maher . unresolved

Should we check this isn't nullptr before using

Open in Gerrit

Related details

Attention is currently required from:
  • Hiroshige Hayashizaki
  • Issack John
  • Kentaro Hara
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I241dc2c7679297a43400162eacfc3d5d72fa6b7e
    Gerrit-Change-Number: 7534844
    Gerrit-PatchSet: 2
    Gerrit-Owner: Issack John <issac...@microsoft.com>
    Gerrit-Reviewer: Clemens Backes <clem...@chromium.org>
    Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>
    Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
    Gerrit-Reviewer: Kouhei Ueno <kou...@chromium.org>
    Gerrit-CC: Alison Maher <alm...@microsoft.com>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Hiroshige Hayashizaki <hiro...@chromium.org>
    Gerrit-Attention: Issack John <issac...@microsoft.com>
    Gerrit-Attention: Kentaro Hara <har...@chromium.org>
    Gerrit-Comment-Date: Thu, 19 Feb 2026 16:52:54 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages