STTF: Delay sttf until related pages are finalized. [chromium/src : main]

0 views
Skip to first unread message

Vladimir Levin (Gerrit)

unread,
Apr 27, 2026, 5:06:19 PM (2 days ago) Apr 27
to Rakina Zata Amni, AI Code Reviewer, chromium...@chromium.org, Nate Chapin, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org
Attention needed from Rakina Zata Amni

Vladimir Levin voted and added 1 comment

Votes added by Vladimir Levin

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Vladimir Levin . resolved

Please take a look.

Open in Gerrit

Related details

Attention is currently required from:
  • Rakina Zata Amni
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifc03488451bd3d1e99c4ab447362437778ddf96d
Gerrit-Change-Number: 7629937
Gerrit-PatchSet: 3
Gerrit-Owner: Vladimir Levin <vmp...@chromium.org>
Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>
Gerrit-Comment-Date: Mon, 27 Apr 2026 21:06:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Vladimir Levin (Gerrit)

unread,
Apr 27, 2026, 6:07:46 PM (2 days ago) Apr 27
to Chromium LUCI CQ, Rakina Zata Amni, AI Code Reviewer, chromium...@chromium.org, Nate Chapin, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org
Attention needed from Rakina Zata Amni

Vladimir Levin added 1 comment

File third_party/blink/renderer/core/page/page.h
Line 678, Patchset 1: bool related_pages_finalized_ = false;
AI Code Reviewer . resolved

nit: Blink Style Guide: Naming - Precede boolean values with words like “is” and “did”. Consider renaming 'related_pages_finalized_' to 'are_related_pages_finalized_' or 'is_related_pages_finalized_'.

To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason


_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Vladimir Levin

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:
  • Rakina Zata Amni
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifc03488451bd3d1e99c4ab447362437778ddf96d
    Gerrit-Change-Number: 7629937
    Gerrit-PatchSet: 4
    Gerrit-Owner: Vladimir Levin <vmp...@chromium.org>
    Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-Comment-Date: Mon, 27 Apr 2026 22:07:35 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Rakina Zata Amni (Gerrit)

    unread,
    Apr 28, 2026, 11:39:29 AM (yesterday) Apr 28
    to Vladimir Levin, Chromium LUCI CQ, AI Code Reviewer, chromium...@chromium.org, Nate Chapin, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org
    Attention needed from Vladimir Levin

    Rakina Zata Amni added 1 comment

    Patchset-level comments
    File-level comment, Patchset 4 (Latest):
    Rakina Zata Amni . resolved

    Thanks! Didn't get a chance to try and repro the case in the bug yet, but I wonder if you can make a test that fails like the one it does on the repro?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Vladimir Levin
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifc03488451bd3d1e99c4ab447362437778ddf96d
    Gerrit-Change-Number: 7629937
    Gerrit-PatchSet: 4
    Gerrit-Owner: Vladimir Levin <vmp...@chromium.org>
    Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Vladimir Levin <vmp...@chromium.org>
    Gerrit-Comment-Date: Tue, 28 Apr 2026 15:39:00 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Vladimir Levin (Gerrit)

    unread,
    Apr 28, 2026, 5:15:14 PM (23 hours ago) Apr 28
    to Stephen Chenney, Dirk Schulze, Fredrik Söderquist, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Rakina Zata Amni, AI Code Reviewer, chromium...@chromium.org, Nate Chapin, pdr+svgw...@chromium.org, kouhe...@chromium.org, fmalit...@chromium.org, blink-revie...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org
    Attention needed from Rakina Zata Amni

    Vladimir Levin added 1 comment

    Patchset-level comments
    Rakina Zata Amni . resolved

    Thanks! Didn't get a chance to try and repro the case in the bug yet, but I wonder if you can make a test that fails like the one it does on the repro?

    Vladimir Levin

    Yeah I can see if I can construct something like that, as soon as make the rest of the tests pass.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Rakina Zata Amni
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifc03488451bd3d1e99c4ab447362437778ddf96d
    Gerrit-Change-Number: 7629937
    Gerrit-PatchSet: 8
    Gerrit-Owner: Vladimir Levin <vmp...@chromium.org>
    Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Fredrik Söderquist <f...@opera.com>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-Comment-Date: Tue, 28 Apr 2026 21:15:03 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Rakina Zata Amni <rak...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Vladimir Levin (Gerrit)

    unread,
    Apr 28, 2026, 10:29:39 PM (18 hours ago) Apr 28
    to Stephen Chenney, Dirk Schulze, Fredrik Söderquist, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Rakina Zata Amni, AI Code Reviewer, chromium...@chromium.org, Nate Chapin, pdr+svgw...@chromium.org, kouhe...@chromium.org, fmalit...@chromium.org, blink-revie...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org
    Attention needed from Rakina Zata Amni

    Vladimir Levin voted Commit-Queue+1

    Commit-Queue+1
    Gerrit-Comment-Date: Wed, 29 Apr 2026 02:29:30 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Vladimir Levin (Gerrit)

    unread,
    Apr 28, 2026, 11:39:37 PM (16 hours ago) Apr 28
    to Stephen Chenney, Dirk Schulze, Fredrik Söderquist, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Rakina Zata Amni, AI Code Reviewer, chromium...@chromium.org, Nate Chapin, pdr+svgw...@chromium.org, kouhe...@chromium.org, fmalit...@chromium.org, blink-revie...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org
    Attention needed from Rakina Zata Amni

    Vladimir Levin added 2 comments

    Patchset-level comments
    Rakina Zata Amni . resolved

    Thanks! Didn't get a chance to try and repro the case in the bug yet, but I wonder if you can make a test that fails like the one it does on the repro?

    Vladimir Levin

    Yeah I can see if I can construct something like that, as soon as make the rest of the tests pass.

    Vladimir Levin

    Done.

    File-level comment, Patchset 10 (Latest):
    Vladimir Levin . resolved

    PTAL

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Rakina Zata Amni
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifc03488451bd3d1e99c4ab447362437778ddf96d
    Gerrit-Change-Number: 7629937
    Gerrit-PatchSet: 10
    Gerrit-Owner: Vladimir Levin <vmp...@chromium.org>
    Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Fredrik Söderquist <f...@opera.com>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-Comment-Date: Wed, 29 Apr 2026 03:39:30 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Vladimir Levin <vmp...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages