[M147] Check scripting flag at the right place [chromium/src : refs/branch-heads/7727]

0 views

Skip to first unread message

Rubber Stamper (Gerrit)

unread,

Mar 11, 2026, 5:01:28 PM (yesterday) Mar 11

to Chrome Cherry Picker, Noam Rosenthal, AyeAye, blink-...@chromium.org, loading-rev...@chromium.org, kinuko...@chromium.org, blink-rev...@chromium.org

Rubber Stamper voted

Bot-Commit	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Lint
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Mar 11, 2026, 6:45:07 PM (yesterday) Mar 11

to Chrome Cherry Picker, Noam Rosenthal, Rubber Stamper, AyeAye, blink-...@chromium.org, loading-rev...@chromium.org, kinuko...@chromium.org, blink-rev...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[M147] Check scripting flag at the right place

Original change's description:
> Check scripting flag at the right place
> 
> createContextualFragment should enable scripts regardless of flag.
> The fragment parser refactor made that behavior flag-protected by
> mistake, causing a crash in stable.
> 
> Moved the flag check to when querying the SetHTML{Unsafe}Options
> dictionary.
> 
> Bug: 488517727
> Change-Id: I2615b176e841f643a233b88ff830eb24f031d8dd
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7645210
> Reviewed-by: Philip Jägenstedt <foo...@chromium.org>
> Commit-Queue: Koji Ishii <ko...@chromium.org>
> Auto-Submit: Noam Rosenthal <nrose...@google.com>
> Reviewed-by: Koji Ishii <ko...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1596857}

(cherry picked from commit c7d15cf092dc10e16cf6d35382e8946e3f6c0549)

Bug: 491543414,488517727

Change-Id: I2615b176e841f643a233b88ff830eb24f031d8dd

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7657366

Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>

Auto-Submit: Chrome Cherry Picker <chrome-che...@chops-service-accounts.iam.gserviceaccount.com>

Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>

Cr-Commit-Position: refs/branch-heads/7727@{#93}

Cr-Branched-From: ce01102937348db7b88c8a4257ee4b3ac702eb1a-refs/heads/main@{#1596535}

Files:

M third_party/blink/renderer/core/editing/serializers/serialization.cc
M third_party/blink/renderer/core/html/parser/fragment_parser_options.h
M third_party/blink/web_tests/VirtualTestSuites
A third_party/blink/web_tests/fast/parser/createContextualFragment-querySelector-crash-expected.txt
A third_party/blink/web_tests/fast/parser/createContextualFragment-querySelector-crash.html

Change size: S

Delta: 5 files changed, 20 insertions(+), 6 deletions(-)

Branch: refs/branch-heads/7727

Submit Requirements:

Code-Review: Bot-Commit+1 by Rubber Stamper

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages