Update GWS font loading duration metrics minimum boundary to 1ms [chromium/src : main]
0 views
Skip to first unread message
Keita Suzuki (Gerrit)
Jun 10, 2026, 9:36:31 PM (9 hours ago) Jun 10
to chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, speed-metrics...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org
Keita Suzuki has uploaded the change for review![]( "Open in Gerrit")
Commit message
Update GWS font loading duration metrics minimum boundary to 1ms
Update GWS font loading duration metrics minimum boundary to 1ms
This CL updates the minimum boundary of the following histograms from
10ms to 1ms to capture sub-10ms durations:
- PageLoad.Clients.GoogleSearch.FontLoading.FallbackDuration.{GWSFontLoadingMilestone}
- PageLoad.Clients.GoogleSearch.FontLoading.InitialFallbackDuration.Complete
This prevents sub-10ms values from being rounded to zero and falling
into the underflow bucket.
Bug: 517003594
Change-Id: If87e6f9b631ebd60ac7d10a6824d144498250f06
Change diff
diff --git a/components/page_load_metrics/google/browser/gws_page_load_metrics_observer.cc b/components/page_load_metrics/google/browser/gws_page_load_metrics_observer.cc
index 51245eb..1a52b48 100644
--- a/components/page_load_metrics/google/browser/gws_page_load_metrics_observer.cc
+++ b/components/page_load_metrics/google/browser/gws_page_load_metrics_observer.cc
@@ -459,7 +459,7 @@
base::StrCat(
{"PageLoad.Clients.GoogleSearch.FontLoading.FallbackDuration.",
suffix}),
- font_loading_metrics->fallback_duration.value(), base::Milliseconds(10),
+ font_loading_metrics->fallback_duration.value(), base::Milliseconds(1),
base::Minutes(10), 100);
}
@@ -1193,7 +1193,7 @@
RecordFontMetrics(font_loading_metrics, internal::kSuffixComplete);
if (font_loading_metrics->fallback_initial_duration) {
- PAGE_LOAD_HISTOGRAM(
+ PAGE_LOAD_HISTOGRAM2(
"PageLoad.Clients.GoogleSearch.FontLoading.InitialFallbackDuration."
"Complete",
font_loading_metrics->fallback_initial_duration.value());
Change information
Files:
- M components/page_load_metrics/google/browser/gws_page_load_metrics_observer.cc
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keita Suzuki (Gerrit)
Jun 10, 2026, 9:44:06 PM (9 hours ago) Jun 10
to Takashi Toyoshima, Chromium LUCI CQ, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Takashi Toyoshima
Keita Suzuki added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Keita Suzuki . resolved
PTAL.
I haven't updated the metric name since we are not getting much data and we are the only people who is looking at this metric as of now. If we need to rename them, please let me know.
Related details
Attention is currently required from:
- Takashi Toyoshima
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Takashi Toyoshima (Gerrit)
5:35 AM (1 hour ago) 5:35 AM
to Keita Suzuki, Chromium LUCI CQ, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Keita Suzuki
Takashi Toyoshima voted and added 2 comments![]( "Open in Gerrit")
Votes added by Takashi Toyoshima
| Code-Review | +1 |
2 comments
File components/page_load_metrics/google/browser/gws_page_load_metrics_observer.cc
Line 459, Patchset 2 (Latest):
base::StrCat(Takashi Toyoshima . unresolved
Can you add a suffix number, or update the XML side comment to note that the logic is changed? (guideline prefers the suffix)
Related details
Attention is currently required from:
- Keita Suzuki
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keita Suzuki (Gerrit)
6:33 AM (1 hour ago) 6:33 AM
to Takashi Toyoshima, Chromium LUCI CQ, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Takashi Toyoshima
Keita Suzuki voted and added 3 comments![]( "Open in Gerrit")
Votes added by Keita Suzuki
| Commit-Queue | +1 |
3 comments
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Keita Suzuki . resolved
Added prefix. Can you rubber stamp the CL as it lost +1? Thanks!
File components/page_load_metrics/google/browser/gws_page_load_metrics_observer.cc
Can you add a suffix number, or update the XML side comment to note that the logic is changed? (guideline prefers the suffix)
Attention is currently required from:
- Takashi Toyoshima
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages