Introduce on-prefetch-activation header to parsed headers [chromium/src : main]

0 views
Skip to first unread message

gwsq (Gerrit)

unread,
May 14, 2026, 2:48:28 AM (6 days ago) May 14
to Jiacheng Guo, Chromium IPC Reviews, Takashi Toyoshima, Kenichi Ishibashi, Koji Ishii, Hiroki Nakagawa, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, crmulli...@chromium.org, feature-me...@chromium.org, jorgel...@chromium.org, nicolas...@chromium.org, ramyagopa...@google.com, alexmo...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org, tburkar...@chromium.org
Attention needed from Kenichi Ishibashi, Koji Ishii and Takashi Toyoshima

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: toyo...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): toyo...@chromium.org


Reviewer source(s):
toyo...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Kenichi Ishibashi
  • Koji Ishii
  • Takashi Toyoshima
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iedfc7bfb8e1a8733735df7294cb03804c21eafd5
Gerrit-Change-Number: 7838802
Gerrit-PatchSet: 5
Gerrit-Owner: Jiacheng Guo <g...@google.com>
Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: gwsq
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>
Gerrit-Attention: Koji Ishii <ko...@chromium.org>
Gerrit-Comment-Date: Thu, 14 May 2026 06:48:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kenichi Ishibashi (Gerrit)

unread,
May 14, 2026, 4:08:46 AM (6 days ago) May 14
to Jiacheng Guo, Chromium IPC Reviews, Takashi Toyoshima, Koji Ishii, Hiroki Nakagawa, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, crmulli...@chromium.org, feature-me...@chromium.org, jorgel...@chromium.org, nicolas...@chromium.org, ramyagopa...@google.com, alexmo...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org, tburkar...@chromium.org
Attention needed from Jiacheng Guo, Koji Ishii and Takashi Toyoshima

Kenichi Ishibashi added 2 comments

File services/network/public/mojom/parsed_headers.mojom
Line 164, Patchset 5 (Latest): // https://docs.google.com/document/d/1ef8vZG-Dzg9f5-gew7-42nHumYe2GvbRMC32AyWmyqs/edit
Kenichi Ishibashi . unresolved

Is it possible to use actual explainer link (not Google docs link)?

Line 165, Patchset 5 (Latest): string? prefetch_activation_beacon_endpoint;
Kenichi Ishibashi . unresolved

https://github.com/explainers-by-googlers/prefetch-activation-beacon says the value is <url>. It doesn't seem to align with the test case above? Also, should we use url.mojom.Url instead of string, since string is less strict than url.mojom.Url?

Open in Gerrit

Related details

Attention is currently required from:
  • Jiacheng Guo
  • Koji Ishii
  • Takashi Toyoshima
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iedfc7bfb8e1a8733735df7294cb03804c21eafd5
    Gerrit-Change-Number: 7838802
    Gerrit-PatchSet: 5
    Gerrit-Owner: Jiacheng Guo <g...@google.com>
    Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
    Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: gwsq
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-Attention: Jiacheng Guo <g...@google.com>
    Gerrit-Attention: Koji Ishii <ko...@chromium.org>
    Gerrit-Comment-Date: Thu, 14 May 2026 08:08:36 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Takashi Toyoshima (Gerrit)

    unread,
    May 14, 2026, 1:45:00 PM (6 days ago) May 14
    to Jiacheng Guo, Chromium IPC Reviews, Kenichi Ishibashi, Koji Ishii, Hiroki Nakagawa, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, crmulli...@chromium.org, feature-me...@chromium.org, jorgel...@chromium.org, nicolas...@chromium.org, ramyagopa...@google.com, alexmo...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org, tburkar...@chromium.org
    Attention needed from Jiacheng Guo and Koji Ishii

    Takashi Toyoshima added 1 comment

    Patchset-level comments
    File-level comment, Patchset 5 (Latest):
    Takashi Toyoshima . resolved

    bashi-san already pointed out what I noticed. So, let me wait for the next round.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jiacheng Guo
    • Koji Ishii
    Gerrit-Attention: Jiacheng Guo <g...@google.com>
    Gerrit-Attention: Koji Ishii <ko...@chromium.org>
    Gerrit-Comment-Date: Thu, 14 May 2026 17:44:26 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Jiacheng Guo (Gerrit)

    unread,
    May 15, 2026, 2:18:53 AM (5 days ago) May 15
    to Chromium IPC Reviews, Takashi Toyoshima, Kenichi Ishibashi, Koji Ishii, Hiroki Nakagawa, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, crmulli...@chromium.org, feature-me...@chromium.org, jorgel...@chromium.org, nicolas...@chromium.org, ramyagopa...@google.com, alexmo...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org, tburkar...@chromium.org
    Attention needed from Kenichi Ishibashi and Koji Ishii

    Jiacheng Guo added 2 comments

    File services/network/public/mojom/parsed_headers.mojom

    Is it possible to use actual explainer link (not Google docs link)?

    Jiacheng Guo

    Done

    Line 165, Patchset 5: string? prefetch_activation_beacon_endpoint;
    Kenichi Ishibashi . unresolved

    https://github.com/explainers-by-googlers/prefetch-activation-beacon says the value is <url>. It doesn't seem to align with the test case above? Also, should we use url.mojom.Url instead of string, since string is less strict than url.mojom.Url?

    Jiacheng Guo

    The naming `<url>` in the explainer is not precise and has been updated. The value in the header should be the relative path to the endpoint. We've also updated the mojo definition to use `url.mojom.Url`.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Kenichi Ishibashi
    • Koji Ishii
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iedfc7bfb8e1a8733735df7294cb03804c21eafd5
    Gerrit-Change-Number: 7838802
    Gerrit-PatchSet: 7
    Gerrit-Owner: Jiacheng Guo <g...@google.com>
    Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
    Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: gwsq
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Kenichi Ishibashi <ba...@chromium.org>
    Gerrit-Attention: Koji Ishii <ko...@chromium.org>
    Gerrit-Comment-Date: Fri, 15 May 2026 06:18:24 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Kenichi Ishibashi <ba...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Kenichi Ishibashi (Gerrit)

    unread,
    May 15, 2026, 2:33:04 AM (5 days ago) May 15
    to Jiacheng Guo, Chromium IPC Reviews, Takashi Toyoshima, Koji Ishii, Hiroki Nakagawa, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, crmulli...@chromium.org, feature-me...@chromium.org, jorgel...@chromium.org, nicolas...@chromium.org, ramyagopa...@google.com, alexmo...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org, tburkar...@chromium.org
    Attention needed from Jiacheng Guo and Koji Ishii

    Kenichi Ishibashi voted and added 2 comments

    Votes added by Kenichi Ishibashi

    Code-Review+1

    2 comments

    Patchset-level comments
    File-level comment, Patchset 7 (Latest):
    Kenichi Ishibashi . resolved

    lgtm

    File services/network/public/mojom/parsed_headers.mojom
    Line 165, Patchset 5: string? prefetch_activation_beacon_endpoint;
    Kenichi Ishibashi . resolved

    https://github.com/explainers-by-googlers/prefetch-activation-beacon says the value is <url>. It doesn't seem to align with the test case above? Also, should we use url.mojom.Url instead of string, since string is less strict than url.mojom.Url?

    Jiacheng Guo

    The naming `<url>` in the explainer is not precise and has been updated. The value in the header should be the relative path to the endpoint. We've also updated the mojo definition to use `url.mojom.Url`.

    Kenichi Ishibashi

    Acknowledged

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jiacheng Guo
    • Koji Ishii
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iedfc7bfb8e1a8733735df7294cb03804c21eafd5
      Gerrit-Change-Number: 7838802
      Gerrit-PatchSet: 7
      Gerrit-Owner: Jiacheng Guo <g...@google.com>
      Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
      Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
      Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
      Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
      Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
      Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
      Gerrit-CC: gwsq
      Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
      Gerrit-Attention: Jiacheng Guo <g...@google.com>
      Gerrit-Attention: Koji Ishii <ko...@chromium.org>
      Gerrit-Comment-Date: Fri, 15 May 2026 06:32:40 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Jiacheng Guo <g...@google.com>
      Comment-In-Reply-To: Kenichi Ishibashi <ba...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Koji Ishii (Gerrit)

      unread,
      May 18, 2026, 2:10:48 AM (2 days ago) May 18
      to Jiacheng Guo, Kenichi Ishibashi, Chromium IPC Reviews, Takashi Toyoshima, Hiroki Nakagawa, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, crmulli...@chromium.org, feature-me...@chromium.org, jorgel...@chromium.org, nicolas...@chromium.org, ramyagopa...@google.com, alexmo...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org, tburkar...@chromium.org
      Attention needed from Jiacheng Guo

      Koji Ishii added 1 comment

      Patchset-level comments
      Koji Ishii . resolved

      removing me, I don't think I'm a good reviewer for this area, and other experts are already in.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Jiacheng Guo
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iedfc7bfb8e1a8733735df7294cb03804c21eafd5
      Gerrit-Change-Number: 7838802
      Gerrit-PatchSet: 7
      Gerrit-Owner: Jiacheng Guo <g...@google.com>
      Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
      Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
      Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
      Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
      Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
      Gerrit-CC: gwsq
      Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
      Gerrit-Attention: Jiacheng Guo <g...@google.com>
      Gerrit-Comment-Date: Mon, 18 May 2026 06:10:20 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Hiroki Nakagawa (Gerrit)

      unread,
      May 19, 2026, 1:27:25 AM (yesterday) May 19
      to Jiacheng Guo, Kenichi Ishibashi, Chromium IPC Reviews, Takashi Toyoshima, Chromium LUCI CQ, chromium...@chromium.org, prerendering-reviews, crmulli...@chromium.org, feature-me...@chromium.org, jorgel...@chromium.org, nicolas...@chromium.org, ramyagopa...@google.com, alexmo...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavin...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org, tburkar...@chromium.org
      Attention needed from Jiacheng Guo

      Hiroki Nakagawa voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Jiacheng Guo
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iedfc7bfb8e1a8733735df7294cb03804c21eafd5
      Gerrit-Change-Number: 7838802
      Gerrit-PatchSet: 7
      Gerrit-Owner: Jiacheng Guo <g...@google.com>
      Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
      Gerrit-Reviewer: Jiacheng Guo <g...@google.com>
      Gerrit-Reviewer: Kenichi Ishibashi <ba...@chromium.org>
      Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
      Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
      Gerrit-CC: gwsq
      Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
      Gerrit-Attention: Jiacheng Guo <g...@google.com>
      Gerrit-Comment-Date: Tue, 19 May 2026 05:27:01 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages