Eliminate redundant structured-header item type checks [chromium/src : main]

0 views
Skip to first unread message

Andrew Paseltiner (Gerrit)

unread,
Aug 6, 2026, 1:17:31 PM (14 days ago) Aug 6
to Kinuko Yasuda, Chromium LUCI CQ, Nate Chapin, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Luna Lu, kinuko...@chromium.org, loading...@chromium.org, loading-re...@chromium.org, gavinp...@chromium.org, blink-...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org
Attention needed from Kinuko Yasuda

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Kinuko Yasuda
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ieaef69708ecb3050c647572d5e6711732d9176f9
Gerrit-Change-Number: 8212821
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Paseltiner <apase...@chromium.org>
Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
Gerrit-Reviewer: Kinuko Yasuda <kin...@chromium.org>
Gerrit-CC: Luna Lu <loon...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Kinuko Yasuda <kin...@chromium.org>
Gerrit-Comment-Date: Thu, 06 Aug 2026 17:17:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Andrew Paseltiner (Gerrit)

unread,
Aug 19, 2026, 11:21:29 AM (yesterday) Aug 19
to Code Review Nudger, Kinuko Yasuda, Chromium LUCI CQ, Nate Chapin, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Luna Lu, kinuko...@chromium.org, loading...@chromium.org, loading-re...@chromium.org, gavinp...@chromium.org, blink-...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org
Attention needed from Kinuko Yasuda

Andrew Paseltiner voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Kinuko Yasuda
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ieaef69708ecb3050c647572d5e6711732d9176f9
Gerrit-Change-Number: 8212821
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Paseltiner <apase...@chromium.org>
Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
Gerrit-Reviewer: Kinuko Yasuda <kin...@chromium.org>
Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
Gerrit-CC: Luna Lu <loon...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Kinuko Yasuda <kin...@chromium.org>
Gerrit-Comment-Date: Wed, 19 Aug 2026 15:21:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Nate Chapin (Gerrit)

unread,
Aug 19, 2026, 2:46:40 PM (21 hours ago) Aug 19
to Andrew Paseltiner, Maks Orlovich, Code Review Nudger, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Luna Lu, kinuko...@chromium.org, loading...@chromium.org, loading-re...@chromium.org, gavinp...@chromium.org, blink-...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org
Attention needed from Andrew Paseltiner and Maks Orlovich

Nate Chapin voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Paseltiner
  • Maks Orlovich
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ieaef69708ecb3050c647572d5e6711732d9176f9
    Gerrit-Change-Number: 8212821
    Gerrit-PatchSet: 5
    Gerrit-Owner: Andrew Paseltiner <apase...@chromium.org>
    Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
    Gerrit-Reviewer: Maks Orlovich <morl...@chromium.org>
    Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-CC: Luna Lu <loon...@chromium.org>
    Gerrit-Attention: Andrew Paseltiner <apase...@chromium.org>
    Gerrit-Attention: Maks Orlovich <morl...@chromium.org>
    Gerrit-Comment-Date: Wed, 19 Aug 2026 18:46:25 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Maks Orlovich (Gerrit)

    unread,
    9:36 AM (2 hours ago) 9:36 AM
    to Andrew Paseltiner, Nate Chapin, Code Review Nudger, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Luna Lu, kinuko...@chromium.org, loading...@chromium.org, loading-re...@chromium.org, gavinp...@chromium.org, blink-...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org
    Attention needed from Andrew Paseltiner

    Maks Orlovich voted

    Code-Review+1
    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Andrew Paseltiner
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ieaef69708ecb3050c647572d5e6711732d9176f9
    Gerrit-Change-Number: 8212821
    Gerrit-PatchSet: 5
    Gerrit-Owner: Andrew Paseltiner <apase...@chromium.org>
    Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
    Gerrit-Reviewer: Maks Orlovich <morl...@chromium.org>
    Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-CC: Luna Lu <loon...@chromium.org>
    Gerrit-Attention: Andrew Paseltiner <apase...@chromium.org>
    Gerrit-Comment-Date: Thu, 20 Aug 2026 13:36:27 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    9:45 AM (2 hours ago) 9:45 AM
    to Andrew Paseltiner, Maks Orlovich, Nate Chapin, Code Review Nudger, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Luna Lu, kinuko...@chromium.org, loading...@chromium.org, loading-re...@chromium.org, gavinp...@chromium.org, blink-...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, network-ser...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Eliminate redundant structured-header item type checks

    Use GetIfFoo rather than is_foo / GetFoo when checking item types.

    This CL contains no intentional user-visible behavioral changes.
    Bug: 541216675
    Change-Id: Ieaef69708ecb3050c647572d5e6711732d9176f9
    Reviewed-by: Nate Chapin <jap...@chromium.org>
    Reviewed-by: Maks Orlovich <morl...@chromium.org>
    Commit-Queue: Maks Orlovich <morl...@chromium.org>
    Auto-Submit: Andrew Paseltiner <apase...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1683094}
    Files:
    • M services/network/public/cpp/fence_event_reporting_parser.cc
    • M third_party/blink/renderer/core/permissions_policy/document_policy_parser.cc
    • M third_party/blink/renderer/platform/loader/fetch/resource_response.cc
    Change size: S
    Delta: 3 files changed, 18 insertions(+), 11 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Nate Chapin, +1 by Maks Orlovich
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ieaef69708ecb3050c647572d5e6711732d9176f9
    Gerrit-Change-Number: 8212821
    Gerrit-PatchSet: 6
    Gerrit-Owner: Andrew Paseltiner <apase...@chromium.org>
    Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Maks Orlovich <morl...@chromium.org>
    Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages