Enable renderer-side speculation rules heuristics [chromium/src : main]

0 views
Skip to first unread message

Hiroki Nakagawa (Gerrit)

unread,
Jul 30, 2026, 6:23:37 AM (23 hours ago) Jul 30
to Yoav Weiss (@Shopify), Vladimir Levin, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, prerendering-reviews, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gavinp+p...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, speed-metrics...@chromium.org, tburkar...@chromium.org
Attention needed from Vladimir Levin and Yoav Weiss (@Shopify)

Hiroki Nakagawa added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Hiroki Nakagawa . unresolved

Can you fix bot failures?

Open in Gerrit

Related details

Attention is currently required from:
  • Vladimir Levin
  • Yoav Weiss (@Shopify)
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9d9efaf44ad1517ca1f1f724b518827add897b50
Gerrit-Change-Number: 8164204
Gerrit-PatchSet: 4
Gerrit-Owner: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
Gerrit-Attention: Vladimir Levin <vmp...@chromium.org>
Gerrit-Comment-Date: Thu, 30 Jul 2026 10:23:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Hiroki Nakagawa (Gerrit)

unread,
Jul 30, 2026, 12:10:20 PM (17 hours ago) Jul 30
to Yoav Weiss (@Shopify), Vladimir Levin, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, prerendering-reviews, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gavinp+p...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, speed-metrics...@chromium.org, tburkar...@chromium.org
Attention needed from Vladimir Levin and Yoav Weiss (@Shopify)

Hiroki Nakagawa voted and added 1 comment

Votes added by Hiroki Nakagawa

Code-Review+1

1 comment

Patchset-level comments
Hiroki Nakagawa . unresolved

Can you fix bot failures?

Related details

Attention is currently required from:
  • Vladimir Levin
  • Yoav Weiss (@Shopify)
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9d9efaf44ad1517ca1f1f724b518827add897b50
    Gerrit-Change-Number: 8164204
    Gerrit-PatchSet: 4
    Gerrit-Owner: Yoav Weiss (@Shopify) <yoav...@chromium.org>
    Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
    Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Yoav Weiss (@Shopify) <yoav...@chromium.org>
    Gerrit-Attention: Vladimir Levin <vmp...@chromium.org>
    Gerrit-Comment-Date: Thu, 30 Jul 2026 16:09:47 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Hiroki Nakagawa <nhi...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Yoav Weiss (@Shopify) (Gerrit)

    unread,
    3:16 AM (2 hours ago) 3:16 AM
    to Hiroki Nakagawa, Vladimir Levin, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, prerendering-reviews, blink-revie...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, gavinp+p...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, speed-metrics...@chromium.org, tburkar...@chromium.org
    Attention needed from Vladimir Levin

    Yoav Weiss (@Shopify) added 1 comment

    Patchset-level comments
    File-level comment, Patchset 4:
    Hiroki Nakagawa . resolved

    Can you fix bot failures?

    Hiroki Nakagawa

    LGTM after https://crrev.com/c/8175083

    Yoav Weiss (@Shopify)

    Thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Vladimir Levin
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I9d9efaf44ad1517ca1f1f724b518827add897b50
      Gerrit-Change-Number: 8164204
      Gerrit-PatchSet: 6
      Gerrit-Owner: Yoav Weiss (@Shopify) <yoav...@chromium.org>
      Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
      Gerrit-Reviewer: Vladimir Levin <vmp...@chromium.org>
      Gerrit-Reviewer: Yoav Weiss (@Shopify) <yoav...@chromium.org>
      Gerrit-CC: Nate Chapin <jap...@chromium.org>
      Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
      Gerrit-Attention: Vladimir Levin <vmp...@chromium.org>
      Gerrit-Comment-Date: Fri, 31 Jul 2026 07:15:58 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Hiroki Nakagawa <nhi...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages