Initialize ICU to load ICU data file for fuzzing [chromium/src : main]

0 views
Skip to first unread message

Ryan Kalla (Gerrit)

unread,
10:00 AM (14 hours ago) 10:00 AM
to Ryan Sturm, Chromium LUCI CQ, AyeAye, speed-metrics...@chromium.org, csharris...@chromium.org, fuzzin...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org
Attention needed from Ryan Sturm

Ryan Kalla voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ryan Sturm
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Icd54e653bb5bf73e1248c34a6d3addf083c753c5
Gerrit-Change-Number: 7531116
Gerrit-PatchSet: 1
Gerrit-Owner: Ryan Kalla <ryan...@google.com>
Gerrit-Reviewer: Ryan Kalla <ryan...@google.com>
Gerrit-Reviewer: Ryan Sturm <ryan...@chromium.org>
Gerrit-Attention: Ryan Sturm <ryan...@chromium.org>
Gerrit-Comment-Date: Fri, 30 Jan 2026 15:00:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Ryan Sturm (Gerrit)

unread,
11:03 AM (13 hours ago) 11:03 AM
to Ryan Kalla, Chromium LUCI CQ, AyeAye, speed-metrics...@chromium.org, csharris...@chromium.org, fuzzin...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org
Attention needed from Ryan Kalla

Ryan Sturm voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ryan Kalla
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Icd54e653bb5bf73e1248c34a6d3addf083c753c5
Gerrit-Change-Number: 7531116
Gerrit-PatchSet: 1
Gerrit-Owner: Ryan Kalla <ryan...@google.com>
Gerrit-Reviewer: Ryan Kalla <ryan...@google.com>
Gerrit-Reviewer: Ryan Sturm <ryan...@chromium.org>
Gerrit-Attention: Ryan Kalla <ryan...@google.com>
Gerrit-Comment-Date: Fri, 30 Jan 2026 16:03:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Ryan Kalla (Gerrit)

unread,
11:04 AM (13 hours ago) 11:04 AM
to Ryan Sturm, Chromium LUCI CQ, AyeAye, speed-metrics...@chromium.org, csharris...@chromium.org, fuzzin...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org

Ryan Kalla voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Icd54e653bb5bf73e1248c34a6d3addf083c753c5
Gerrit-Change-Number: 7531116
Gerrit-PatchSet: 1
Gerrit-Owner: Ryan Kalla <ryan...@google.com>
Gerrit-Reviewer: Ryan Kalla <ryan...@google.com>
Gerrit-Reviewer: Ryan Sturm <ryan...@chromium.org>
Gerrit-Comment-Date: Fri, 30 Jan 2026 16:04:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
11:07 AM (13 hours ago) 11:07 AM
to Ryan Kalla, Ryan Sturm, AyeAye, speed-metrics...@chromium.org, csharris...@chromium.org, fuzzin...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Initialize ICU to load ICU data file for fuzzing

The CaptchaProviderManager fuzztest relies on GURL, which depends on
ICU for IDN handling. We need to initialize ICU to avoid a CHECK
failure when ICU's IDN class is initialized.
See http://crbug.com/40546867.
Bug: 477312391
Change-Id: Icd54e653bb5bf73e1248c34a6d3addf083c753c5
Reviewed-by: Ryan Sturm <ryan...@chromium.org>
Commit-Queue: Ryan Kalla <ryan...@google.com>
Cr-Commit-Position: refs/heads/main@{#1577262}
Files:
  • M chrome/browser/page_load_metrics/observers/captcha_provider_manager_fuzztest.cc
  • M chrome/test/BUILD.gn
Change size: S
Delta: 2 files changed, 14 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Ryan Sturm
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Icd54e653bb5bf73e1248c34a6d3addf083c753c5
Gerrit-Change-Number: 7531116
Gerrit-PatchSet: 2
Gerrit-Owner: Ryan Kalla <ryan...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages