Remove CC frame rate throttling logic and Blink plumbing. [chromium/src : main]
0 views
Skip to first unread message
Jiacheng Guo (Gerrit)
Jun 9, 2026, 12:54:05 AM (3 days ago) Jun 9
to chromium...@chromium.org, Nate Chapin, Chromium Metrics Reviews, Daniel Cheng, asvitkine...@chromium.org, kinuko...@chromium.org, cc-...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, jmedle...@chromium.org, blink-re...@chromium.org, loading...@chromium.org, schedule...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org
Jiacheng Guo has uploaded the change for review![]( "Open in Gerrit")
Commit message
Remove CC frame rate throttling logic and Blink plumbing.
Remove the frame rate throttling implementation in the compositor
scheduler and its plumbing from Blink. This feature was added to
throttle the renderer frame rate during the loading phase but was
found to be not helpful for loading performance.
This CL removes the kRenderThrottleFrameRate feature and its
plumbing through LayerTreeHost, Proxy, Scheduler, and
SchedulerStateMachine, along with the corresponding
SetShouldThrottleFrameRate methods and plumbing in WebFrameWidgetImpl,
ChromeClient, and ChromeClientImpl. The calls in Document are also
removed.
Bug: 521610226
Change-Id: I02d3975cd493cb3f10f42a61bca9b778953866a2
Change diff
Change information
Files:
- M cc/base/features.cc
- M cc/base/features.h
- M cc/scheduler/scheduler.cc
- M cc/scheduler/scheduler.h
- M cc/scheduler/scheduler_state_machine.cc
- M cc/scheduler/scheduler_state_machine.h
- M cc/scheduler/scheduler_state_machine_unittest.cc
- M cc/scheduler/scheduler_unittest.cc
- M cc/test/fake_proxy.h
- M cc/trees/layer_tree_host.cc
- M cc/trees/layer_tree_host.h
- M cc/trees/proxy.h
- M cc/trees/proxy_impl.cc
- M cc/trees/proxy_impl.h
- M cc/trees/proxy_main.cc
- M cc/trees/proxy_main.h
- M cc/trees/single_thread_proxy.cc
- M cc/trees/single_thread_proxy.h
- M third_party/blink/renderer/core/dom/document.cc
- M third_party/blink/renderer/core/frame/web_frame_widget_impl.cc
- M third_party/blink/renderer/core/frame/web_frame_widget_impl.h
- M third_party/blink/renderer/core/loader/empty_clients.h
- M third_party/blink/renderer/core/page/chrome_client.h
- M third_party/blink/renderer/core/page/chrome_client_impl.cc
- M third_party/blink/renderer/core/page/chrome_client_impl.h
Change size: M
Delta: 25 files changed, 4 insertions(+), 240 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vladimir Levin (Gerrit)
Jun 10, 2026, 8:46:19 AM (yesterday) Jun 10
to Jiacheng Guo, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Daniel Cheng, Nate Chapin, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, schedule...@chromium.org
Attention needed from Jiacheng Guo
Vladimir Levin voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Jiacheng Guo
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jiacheng Guo (Gerrit)
Jun 10, 2026, 11:48:25 PM (14 hours ago) Jun 10
to Vladimir Levin, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Daniel Cheng, Nate Chapin, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, schedule...@chromium.org
Jiacheng Guo voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
12:36 AM (14 hours ago) 12:36 AM
to Jiacheng Guo, Vladimir Levin, Chromium Metrics Reviews, chromium...@chromium.org, Daniel Cheng, Nate Chapin, android-web...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, gavinp...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, schedule...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Remove CC frame rate throttling logic and Blink plumbing.
Remove the frame rate throttling implementation in the compositor
scheduler and its plumbing from Blink. This feature was added to
throttle the renderer frame rate during the loading phase but was
found to be not helpful for loading performance.
This CL removes the kRenderThrottleFrameRate feature and its
plumbing through LayerTreeHost, Proxy, Scheduler, and
SchedulerStateMachine, along with the corresponding
SetShouldThrottleFrameRate methods and plumbing in WebFrameWidgetImpl,
ChromeClient, and ChromeClientImpl. The calls in Document are also
removed.
Bug: 521610226
Change-Id: I02d3975cd493cb3f10f42a61bca9b778953866a2
Reviewed-by: Vladimir Levin <vmp...@chromium.org>
Commit-Queue: Jiacheng Guo <g...@google.com>
Cr-Commit-Position: refs/heads/main@{#1645104}
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Vladimir Levin
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages