Initial: Deferred cross-document commit [chromium/src : main]

1 view
Skip to first unread message

Nasko Oskov (Gerrit)

unread,
Dec 3, 2025, 6:23:20 PM12/3/25
to Noam Rosenthal, Dominic Farolino, AyeAye, Nate Chapin, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, ashleynewson+w...@chromium.org, android-web...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org
Attention needed from Dominic Farolino, Nate Chapin and Noam Rosenthal

Nasko Oskov added 1 comment

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Nasko Oskov . resolved

This is the first time I hear about this new work and it sounds fairly complex. Is there a design doc I can read up on other than the GitHub issue?

Just to set expectations, it will take me more than 24 hours to review this.

Open in Gerrit

Related details

Attention is currently required from:
  • Dominic Farolino
  • Nate Chapin
  • Noam Rosenthal
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6c9064175104a3f3b25f2a1a31af741f72fad9cf
Gerrit-Change-Number: 7207394
Gerrit-PatchSet: 7
Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
Gerrit-Reviewer: Nasko Oskov <na...@chromium.org>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Dominic Farolino <d...@chromium.org>
Gerrit-Attention: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
Gerrit-Comment-Date: Wed, 03 Dec 2025 23:23:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Noam Rosenthal (Gerrit)

unread,
Dec 4, 2025, 4:34:01 AM12/4/25
to Dominic Farolino, AyeAye, Nate Chapin, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, ashleynewson+w...@chromium.org, android-web...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org
Attention needed from Dominic Farolino, Nasko Oskov and Nate Chapin

Noam Rosenthal added 1 comment

Patchset-level comments
Nasko Oskov . resolved

This is the first time I hear about this new work and it sounds fairly complex. Is there a design doc I can read up on other than the GitHub issue?

Just to set expectations, it will take me more than 24 hours to review this.

Noam Rosenthal

I've shared the internal design document with you (I find that sharing Google docs here brings a lot of spam). No rush, thanks for taking a look.

Open in Gerrit

Related details

Attention is currently required from:
  • Dominic Farolino
  • Nasko Oskov
  • Nate Chapin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6c9064175104a3f3b25f2a1a31af741f72fad9cf
Gerrit-Change-Number: 7207394
Gerrit-PatchSet: 7
Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
Gerrit-Reviewer: Nasko Oskov <na...@chromium.org>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Nasko Oskov <na...@chromium.org>
Gerrit-Attention: Dominic Farolino <d...@chromium.org>
Gerrit-Attention: Nate Chapin <jap...@chromium.org>
Gerrit-Comment-Date: Thu, 04 Dec 2025 09:33:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nasko Oskov <na...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Noam Rosenthal (Gerrit)

unread,
Dec 15, 2025, 8:33:58 AM12/15/25
to Dominic Farolino, AyeAye, Nate Chapin, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, ashleynewson+w...@chromium.org, android-web...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org
Attention needed from Dominic Farolino, Nasko Oskov, Nate Chapin and Noam Rosenthal

Message from Noam Rosenthal

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • Dominic Farolino
  • Nasko Oskov
  • Nate Chapin
  • Noam Rosenthal
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6c9064175104a3f3b25f2a1a31af741f72fad9cf
Gerrit-Change-Number: 7207394
Gerrit-PatchSet: 9
Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
Gerrit-Reviewer: Nasko Oskov <na...@chromium.org>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Nasko Oskov <na...@chromium.org>
Gerrit-Attention: Dominic Farolino <d...@chromium.org>
Gerrit-Attention: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
Gerrit-Comment-Date: Mon, 15 Dec 2025 13:33:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Noam Rosenthal (Gerrit)

unread,
Dec 17, 2025, 6:12:14 AM12/17/25
to Dominic Farolino, AyeAye, Nate Chapin, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, ashleynewson+w...@chromium.org, android-web...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org
Attention needed from Dominic Farolino, Nasko Oskov and Nate Chapin

Noam Rosenthal added 1 comment

Patchset-level comments
Nasko Oskov . resolved

This is the first time I hear about this new work and it sounds fairly complex. Is there a design doc I can read up on other than the GitHub issue?

Just to set expectations, it will take me more than 24 hours to review this.

Noam Rosenthal

I've shared the internal design document with you (I find that sharing Google docs here brings a lot of spam). No rush, thanks for taking a look.

Noam Rosenthal

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Dominic Farolino
  • Nasko Oskov
  • Nate Chapin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6c9064175104a3f3b25f2a1a31af741f72fad9cf
Gerrit-Change-Number: 7207394
Gerrit-PatchSet: 13
Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
Gerrit-Reviewer: Nasko Oskov <na...@chromium.org>
Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Nasko Oskov <na...@chromium.org>
Gerrit-Attention: Dominic Farolino <d...@chromium.org>
Gerrit-Attention: Nate Chapin <jap...@chromium.org>
Gerrit-Comment-Date: Wed, 17 Dec 2025 11:11:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nasko Oskov <na...@chromium.org>
Comment-In-Reply-To: Noam Rosenthal <nrose...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Nate Chapin (Gerrit)

unread,
Jan 8, 2026, 4:30:44 PM (yesterday) Jan 8
to Noam Rosenthal, Code Review Nudger, Dominic Farolino, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, ashleynewson+w...@chromium.org, android-web...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org
Attention needed from Dominic Farolino, Nasko Oskov and Noam Rosenthal

Nate Chapin added 3 comments

Patchset-level comments
File-level comment, Patchset 13 (Latest):
Nate Chapin . unresolved

WPT should be `tentative`, right?

File third_party/blink/renderer/core/navigation_api/navigate_event.h
Line 15, Patchset 13 (Latest):#include "third_party/blink/renderer/bindings/core/v8/script_promise_resolver.h"
Nate Chapin . unresolved

Some of these #includes look unnecessary (like this one)

File third_party/blink/renderer/core/navigation_api/navigate_event.cc
Line 310, Patchset 13 (Latest): ScriptState* script_state = ToScriptStateForMainWorld(DomWindow());
Nate Chapin . unresolved

Nit: Pass in, since ethe caller has it?

Open in Gerrit

Related details

Attention is currently required from:
  • Dominic Farolino
  • Nasko Oskov
  • Noam Rosenthal
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6c9064175104a3f3b25f2a1a31af741f72fad9cf
    Gerrit-Change-Number: 7207394
    Gerrit-PatchSet: 13
    Gerrit-Owner: Noam Rosenthal <nrose...@google.com>
    Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
    Gerrit-Reviewer: Nasko Oskov <na...@chromium.org>
    Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
    Gerrit-Reviewer: Noam Rosenthal <nrose...@google.com>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Nasko Oskov <na...@chromium.org>
    Gerrit-Attention: Dominic Farolino <d...@chromium.org>
    Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
    Gerrit-Comment-Date: Thu, 08 Jan 2026 21:30:36 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Nasko Oskov (Gerrit)

    unread,
    3:10 PM (4 hours ago) 3:10 PM
    to Noam Rosenthal, Code Review Nudger, Dominic Farolino, AyeAye, Nate Chapin, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, ashleynewson+w...@chromium.org, android-web...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, creis...@chromium.org, gavinp...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, loading...@chromium.org, navigation...@chromium.org
    Attention needed from Dominic Farolino and Noam Rosenthal

    Nasko Oskov added 4 comments

    File content/browser/renderer_host/navigation_api_commit_deferring_condition.h
    Line 1, Patchset 13 (Latest):// Copyright 2025 The Chromium Authors
    Nasko Oskov . unresolved

    2026

    File content/browser/renderer_host/navigation_api_commit_deferring_condition.cc
    Line 1, Patchset 13 (Latest):// Copyright 2025 The Chromium Authors
    Nasko Oskov . unresolved

    2026

    Line 45, Patchset 13 (Latest): ~NavigationAPICommitDeferringCondition() {}
    Nasko Oskov . unresolved

    Please fix this WARNING reported by ClangTidy: check: modernize-use-equals-default

    use '= default' to define a trivial destruc...

    check: modernize-use-equals-default

    use '= default' to define a trivial destructor (https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-equals-default.html)

    (Note: You can add `Skip-Clang-Tidy-Checks: modernize-use-equals-default` footer to the CL description to skip the check)

    (Lint observed on `android-clang-tidy-rel`, but not on `linux-clang-tidy-rel`)

    File third_party/blink/public/mojom/navigation/navigation_params.mojom
    Line 108, Patchset 13 (Latest): // This is called by the navigation API after author-provided conditions are met.
    Nasko Oskov . unresolved

    Line exceeds max characters.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dominic Farolino
    • Noam Rosenthal
    Gerrit-Attention: Dominic Farolino <d...@chromium.org>
    Gerrit-Attention: Noam Rosenthal <nrose...@google.com>
    Gerrit-Comment-Date: Fri, 09 Jan 2026 20:10:27 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages