[iOS] Trigger LensOverlay instead of LVF on AppBar Lens button [chromium/src : main]

0 views
Skip to first unread message

Chris Lu (Gerrit)

unread,
Jul 7, 2026, 1:54:48 PM (2 days ago) Jul 7
to Gauthier Ambard, Radu Nitescu, Enterprise Policy Reviews, Sadrul Chowdhury, Nate Chapin, Menard, Alexis, Chromium Metrics Reviews, Stephen Chenney, Dirk Schulze, Christian Biesinger, Kentaro Hara, Olga Gerchikov, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, SLSA Policy Verification Service, japhet+...@chromium.org, loading...@chromium.org, navigation...@chromium.org, asvitki...@chromium.org, loading-re...@chromium.org, vasilii+watchlis...@chromium.org, cblume...@chromium.org, kinuko...@chromium.org, jdonnel...@chromium.org, feature-v...@chromium.org, tburkar...@chromium.org, mek+w...@chromium.org, blink-revie...@chromium.org, browser-comp...@chromium.org, grt+...@chromium.org, srahim...@chromium.org, lize...@chromium.org, prerenderi...@chromium.org, gavinp...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, christia...@chromium.org, roblia...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, rsleev...@chromium.org, storage...@chromium.org, nyquis...@chromium.org, blink-...@chromium.org, pasko...@chromium.org, gcasto+w...@chromium.org, bartek...@chromium.org, fserb...@chromium.org, lizeb...@chromium.org, jshin...@chromium.org, npm+...@chromium.org, fmalit...@chromium.org, martijn...@martijnc.be, yigu+...@chromium.org, chrome-intelligence-te...@google.com, mac-r...@chromium.org, omnibox-...@chromium.org, blink-rev...@chromium.org, xinghui...@chromium.org, android-web...@chromium.org, mgiuca...@chromium.org, tbarzi...@chromium.org, rrsilva+wat...@google.com, webap...@microsoft.com, asvitkine...@chromium.org, telemetr...@chromium.org, alexmo...@chromium.org, drott+bl...@chromium.org, chrome-intell...@chromium.org, blink-reviews-p...@chromium.org, creis...@chromium.org, gavin...@chromium.org, zelin+watch-we...@chromium.org, jessemcke...@google.com, jdeblas...@chromium.org, aixba+wat...@chromium.org, philli...@chromium.org, vakh+safe_br...@chromium.org, blink-revie...@chromium.org, yfriedm...@chromium.org, kuragin+web-ap...@chromium.org, wfh+...@chromium.org, torne...@chromium.org, agriev...@chromium.org, penghuan...@chromium.org, zackha...@chromium.org, jmedle...@chromium.org, nwoked...@chromium.org, net-r...@chromium.org, loyso...@chromium.org, dewitt...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard and Radu Nitescu

Chris Lu voted and added 1 comment

Votes added by Chris Lu

Code-Review+1

1 comment

File ios/chrome/browser/app_bar/coordinator/app_bar_mediator.mm
Line 393, Patchset 6 (Latest): if (status.active_web_state_change()) {
if (!_tabGridState.tabGridVisible) {
self.currentTabGroup = GetGroupForActiveWebState(webStateList);
}
Chris Lu . unresolved

nit: is this change doing anything different?

Open in Gerrit

Related details

Attention is currently required from:
  • Gauthier Ambard
  • Radu Nitescu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7580c6203e0020677b6fc44a63219172d8de8035
Gerrit-Change-Number: 8052184
Gerrit-PatchSet: 6
Gerrit-Owner: Gauthier Ambard <gam...@chromium.org>
Gerrit-Reviewer: Chris Lu <thegre...@chromium.org>
Gerrit-Reviewer: Radu Nitescu <radun...@google.com>
Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Radu Nitescu <radun...@google.com>
Gerrit-Attention: Gauthier Ambard <gam...@chromium.org>
Gerrit-Comment-Date: Tue, 07 Jul 2026 17:54:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Gauthier Ambard (Gerrit)

unread,
Jul 8, 2026, 11:20:01 AM (17 hours ago) Jul 8
to Chris Lu, Radu Nitescu, Enterprise Policy Reviews, Sadrul Chowdhury, Nate Chapin, Menard, Alexis, Chromium Metrics Reviews, Stephen Chenney, Dirk Schulze, Christian Biesinger, Kentaro Hara, Olga Gerchikov, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, SLSA Policy Verification Service, japhet+...@chromium.org, loading...@chromium.org, navigation...@chromium.org, asvitki...@chromium.org, loading-re...@chromium.org, vasilii+watchlis...@chromium.org, cblume...@chromium.org, kinuko...@chromium.org, jdonnel...@chromium.org, feature-v...@chromium.org, tburkar...@chromium.org, mek+w...@chromium.org, blink-revie...@chromium.org, browser-comp...@chromium.org, grt+...@chromium.org, srahim...@chromium.org, lize...@chromium.org, prerenderi...@chromium.org, gavinp...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, christia...@chromium.org, roblia...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, rsleev...@chromium.org, storage...@chromium.org, nyquis...@chromium.org, blink-...@chromium.org, pasko...@chromium.org, gcasto+w...@chromium.org, bartek...@chromium.org, fserb...@chromium.org, lizeb...@chromium.org, jshin...@chromium.org, npm+...@chromium.org, fmalit...@chromium.org, martijn...@martijnc.be, yigu+...@chromium.org, chrome-intelligence-te...@google.com, mac-r...@chromium.org, omnibox-...@chromium.org, blink-rev...@chromium.org, xinghui...@chromium.org, android-web...@chromium.org, mgiuca...@chromium.org, tbarzi...@chromium.org, rrsilva+wat...@google.com, webap...@microsoft.com, asvitkine...@chromium.org, telemetr...@chromium.org, alexmo...@chromium.org, drott+bl...@chromium.org, chrome-intell...@chromium.org, blink-reviews-p...@chromium.org, creis...@chromium.org, gavin...@chromium.org, zelin+watch-we...@chromium.org, jessemcke...@google.com, jdeblas...@chromium.org, aixba+wat...@chromium.org, philli...@chromium.org, vakh+safe_br...@chromium.org, blink-revie...@chromium.org, yfriedm...@chromium.org, kuragin+web-ap...@chromium.org, wfh+...@chromium.org, torne...@chromium.org, agriev...@chromium.org, penghuan...@chromium.org, zackha...@chromium.org, jmedle...@chromium.org, nwoked...@chromium.org, net-r...@chromium.org, loyso...@chromium.org, dewitt...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Radu Nitescu

Gauthier Ambard voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Radu Nitescu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7580c6203e0020677b6fc44a63219172d8de8035
Gerrit-Change-Number: 8052184
Gerrit-PatchSet: 7
Gerrit-Owner: Gauthier Ambard <gam...@chromium.org>
Gerrit-Reviewer: Chris Lu <thegre...@chromium.org>
Gerrit-Reviewer: Gauthier Ambard <gam...@chromium.org>
Gerrit-Reviewer: Radu Nitescu <radun...@google.com>
Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Radu Nitescu <radun...@google.com>
Gerrit-Comment-Date: Wed, 08 Jul 2026 15:19:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Radu Nitescu (Gerrit)

unread,
Jul 8, 2026, 11:23:51 AM (17 hours ago) Jul 8
to Gauthier Ambard, Chromium LUCI CQ, Chris Lu, Enterprise Policy Reviews, Sadrul Chowdhury, Nate Chapin, Menard, Alexis, Chromium Metrics Reviews, Stephen Chenney, Dirk Schulze, Christian Biesinger, Kentaro Hara, Olga Gerchikov, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, SLSA Policy Verification Service, japhet+...@chromium.org, loading...@chromium.org, navigation...@chromium.org, asvitki...@chromium.org, loading-re...@chromium.org, vasilii+watchlis...@chromium.org, cblume...@chromium.org, kinuko...@chromium.org, jdonnel...@chromium.org, feature-v...@chromium.org, tburkar...@chromium.org, mek+w...@chromium.org, blink-revie...@chromium.org, browser-comp...@chromium.org, grt+...@chromium.org, srahim...@chromium.org, lize...@chromium.org, prerenderi...@chromium.org, gavinp...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, christia...@chromium.org, roblia...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, rsleev...@chromium.org, storage...@chromium.org, nyquis...@chromium.org, blink-...@chromium.org, pasko...@chromium.org, gcasto+w...@chromium.org, bartek...@chromium.org, fserb...@chromium.org, lizeb...@chromium.org, jshin...@chromium.org, npm+...@chromium.org, fmalit...@chromium.org, martijn...@martijnc.be, yigu+...@chromium.org, chrome-intelligence-te...@google.com, mac-r...@chromium.org, omnibox-...@chromium.org, blink-rev...@chromium.org, xinghui...@chromium.org, android-web...@chromium.org, mgiuca...@chromium.org, tbarzi...@chromium.org, rrsilva+wat...@google.com, webap...@microsoft.com, asvitkine...@chromium.org, telemetr...@chromium.org, alexmo...@chromium.org, drott+bl...@chromium.org, chrome-intell...@chromium.org, blink-reviews-p...@chromium.org, creis...@chromium.org, gavin...@chromium.org, zelin+watch-we...@chromium.org, jessemcke...@google.com, jdeblas...@chromium.org, aixba+wat...@chromium.org, philli...@chromium.org, vakh+safe_br...@chromium.org, blink-revie...@chromium.org, yfriedm...@chromium.org, kuragin+web-ap...@chromium.org, wfh+...@chromium.org, torne...@chromium.org, agriev...@chromium.org, penghuan...@chromium.org, zackha...@chromium.org, jmedle...@chromium.org, nwoked...@chromium.org, net-r...@chromium.org, loyso...@chromium.org, dewitt...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard

Radu Nitescu voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Gauthier Ambard
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7580c6203e0020677b6fc44a63219172d8de8035
Gerrit-Change-Number: 8052184
Gerrit-PatchSet: 7
Gerrit-Owner: Gauthier Ambard <gam...@chromium.org>
Gerrit-Reviewer: Chris Lu <thegre...@chromium.org>
Gerrit-Reviewer: Gauthier Ambard <gam...@chromium.org>
Gerrit-Reviewer: Radu Nitescu <radun...@google.com>
Gerrit-Reviewer: SLSA Policy Verification Service <devtools-gerritco...@google.com>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Gauthier Ambard <gam...@chromium.org>
Gerrit-Comment-Date: Wed, 08 Jul 2026 15:23:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages