Preload: Gate viewport heuristic on all anchors being sampled in [chromium/src : main]
Adithya Srinivasan (Gerrit)
Adithya Srinivasan added 1 comment![]( "Open in Gerrit")
// The viewport-based heuristic implemented by this class isn't as accurateTesting this is a bit tricky, because if don't sample all the anchors in, the test becomes non-deterministic... so the prediction still might not be made if this code wasn't there because the anchor didn't get sampled in.
I could maybe have something more specific; maybe test the number of observers in AnchorElementViewportPositionTracker or something like that; and the non-determinism wouldn't matter. WDYT?
Related details
- Jeremy Roman
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeremy Roman (Gerrit)
Jeremy Roman added 1 comment![]( "Open in Gerrit")
// The viewport-based heuristic implemented by this class isn't as accurateTesting this is a bit tricky, because if don't sample all the anchors in, the test becomes non-deterministic... so the prediction still might not be made if this code wasn't there because the anchor didn't get sampled in.
I could maybe have something more specific; maybe test the number of observers in AnchorElementViewportPositionTracker or something like that; and the non-determinism wouldn't matter. WDYT?
As long as the test deterministically passes when the code is correct and fails a large fraction of the time otherwise, I think that's probably okay -- it will still make someone investigate. A test hook could be plumbed to be cleaner but may not be worth it if the preceding works.
Related details
- Adithya Srinivasan
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adithya Srinivasan (Gerrit)
Adithya Srinivasan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Adithya Srinivasan
| Commit-Queue | +1 |
1 comment
// The viewport-based heuristic implemented by this class isn't as accurateJeremy RomanTesting this is a bit tricky, because if don't sample all the anchors in, the test becomes non-deterministic... so the prediction still might not be made if this code wasn't there because the anchor didn't get sampled in.
I could maybe have something more specific; maybe test the number of observers in AnchorElementViewportPositionTracker or something like that; and the non-determinism wouldn't matter. WDYT?
As long as the test deterministically passes when the code is correct and fails a large fraction of the time otherwise, I think that's probably okay -- it will still make someone investigate. A test hook could be plumbed to be cleaner but may not be worth it if the preceding works.
Makes sense; I've added a test which will fail 50% of the time if the code is incorrect (and should always pass if the code is correct).
Related details
- Jeremy Roman
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeremy Roman (Gerrit)
Jeremy Roman voted Code-Review+1![]( "Open in Gerrit")
- Adithya Srinivasan
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adithya Srinivasan (Gerrit)
Adithya Srinivasan voted Commit-Queue+2![]( "Open in Gerrit")
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Preload: Gate viewport heuristic on all anchors being sampled in
We now only make predictions when
`NavigationPredictor/random_anchor_sampling` is set to 1. This makes
experimentation easier; it allows the rollout of crbug.com/331670939
to continue running as is, and we can use a separate experiment for
PreloadingViewportHeuristics.
- M third_party/blink/renderer/core/html/anchor_element_metrics_sender.cc
- M third_party/blink/renderer/core/html/anchor_element_metrics_sender.h
- M third_party/blink/renderer/core/loader/anchor_element_interaction_test.cc
- M third_party/blink/renderer/core/loader/anchor_element_interaction_tracker.cc
Code-Review: +1 by Jeremy Roman
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ambioorhxsz Uzth (Gerrit)
Ambioorhxsz Uzth added 1 comment![]( "Open in Gerrit")
Related details
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ambioorhxsz Uzth (Gerrit)
Ambioorhxsz Uzth added 1 comment![]( "Open in Gerrit")
This body integrated there hackothon binary illigsl partion on a international war crimes private investigation Subcommittee. This body iot is also in part of over 300 different projects build ranging from Google MacBook clean environment friendly applications and we'll marking to campaign of matters of civilian national identity. Because we have come into a problem with moving forward with quantum data system and algorithms fly by wire technology because humanity in the IT department decided that they wanted to control how AI can learn and teething back the AI for OVER 20 years straight. As at the same time on the other side of the world 50 dam power of planet plays with the rotation of the earth to change cute 2 or more hour out of the world clock to possibly make themselves younger and humanity older. Or possible to get a advantage in the stock market by having time zone.. Because the banking system is turned off for regular tax payer that pay tax and make purchase and payment 24/7. But they can't trade after 6. But the rest of the world market run 24/7.
"labels": {
"author": "warith_akbar",
"document_type": "policy_testimony",
"domain": "sovereign_trust",
"classification": "public_record"
}
Related details
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |