[Heavy Ad] Send Intervention Report to the Embedding Frame [chromium/src : main]

0 views
Skip to first unread message

AI Code Reviewer (Gerrit)

unread,
Sep 10, 2025, 8:27:54 PM (7 days ago) Sep 10
to Yao Xiao, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, creis...@chromium.org, csharris...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, navigation...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

AI Code Reviewer added 2 comments

File third_party/blink/renderer/core/html/html_frame_owner_element.h
Line 75, Patchset 5 (Latest): virtual String GetElementInfoForInterventionReport() const;
AI Code Reviewer . unresolved

nit: Blink Style Guide: Naming - Precede setters with the word “Set”; use bare words for getters. Please rename this to `ElementInfoForInterventionReport()` as there is no type name collision that would require a 'Get' prefix.

_To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **Won't fix**: reason | **b/<bug_id>** | **Invalid:** reason

This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent).AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve.[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

File third_party/blink/renderer/core/html/html_iframe_element.h
Line 62, Patchset 5 (Latest): String GetElementInfoForInterventionReport() const final;
AI Code Reviewer . unresolved

nit: Blink Style Guide: Naming - Precede setters with the word “Set”; use bare words for getters. Please rename this to `ElementInfoForInterventionReport()` as there is no type name collision that would require a 'Get' prefix.

_To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **Won't fix**: reason | **b/<bug_id>** | **Invalid:** reason

This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent).AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve.[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5d988494dbbcd0aa6a9090745913369e7791e4a7
Gerrit-Change-Number: 6937085
Gerrit-PatchSet: 5
Gerrit-Owner: Yao Xiao <yao...@chromium.org>
Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-Comment-Date: Thu, 11 Sep 2025 00:27:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Yao Xiao (Gerrit)

unread,
Sep 11, 2025, 3:48:25 PM (6 days ago) Sep 11
to AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, creis...@chromium.org, csharris...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, navigation...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

Yao Xiao added 1 comment

File third_party/blink/renderer/core/html/html_frame_owner_element.h
Line 75, Patchset 5: virtual String GetElementInfoForInterventionReport() const;
AI Code Reviewer . resolved

nit: Blink Style Guide: Naming - Precede setters with the word “Set”; use bare words for getters. Please rename this to `ElementInfoForInterventionReport()` as there is no type name collision that would require a 'Get' prefix.

_To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **Won't fix**: reason | **b/<bug_id>** | **Invalid:** reason

This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent).AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve.[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Yao Xiao

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5d988494dbbcd0aa6a9090745913369e7791e4a7
Gerrit-Change-Number: 6937085
Gerrit-PatchSet: 7
Gerrit-Owner: Yao Xiao <yao...@chromium.org>
Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-Comment-Date: Thu, 11 Sep 2025 19:48:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Yao Xiao (Gerrit)

unread,
Sep 11, 2025, 4:15:12 PM (6 days ago) Sep 11
to Josh Karlin, AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, creis...@chromium.org, csharris...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, navigation...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Josh Karlin

Yao Xiao voted and added 1 comment

Votes added by Yao Xiao

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 9 (Latest):
Yao Xiao . resolved

jkarlin@: PTAL. Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Josh Karlin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I5d988494dbbcd0aa6a9090745913369e7791e4a7
Gerrit-Change-Number: 6937085
Gerrit-PatchSet: 9
Gerrit-Owner: Yao Xiao <yao...@chromium.org>
Gerrit-Reviewer: Josh Karlin <jka...@chromium.org>
Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-Attention: Josh Karlin <jka...@chromium.org>
Gerrit-Comment-Date: Thu, 11 Sep 2025 20:15:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Josh Karlin (Gerrit)

unread,
Sep 12, 2025, 9:36:37 AM (5 days ago) Sep 12
to Yao Xiao, Josh Karlin, AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, creis...@chromium.org, csharris...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, navigation...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Yao Xiao

Josh Karlin voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Yao Xiao
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I5d988494dbbcd0aa6a9090745913369e7791e4a7
    Gerrit-Change-Number: 6937085
    Gerrit-PatchSet: 10
    Gerrit-Owner: Yao Xiao <yao...@chromium.org>
    Gerrit-Reviewer: Josh Karlin <jka...@chromium.org>
    Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    Gerrit-Attention: Yao Xiao <yao...@chromium.org>
    Gerrit-Comment-Date: Fri, 12 Sep 2025 13:36:30 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Yao Xiao (Gerrit)

    unread,
    Sep 12, 2025, 11:25:15 AM (5 days ago) Sep 12
    to Alex Moshchuk, Daniel Cheng, Josh Karlin, AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, creis...@chromium.org, csharris...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, navigation...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
    Attention needed from Alex Moshchuk and Daniel Cheng

    Yao Xiao added 2 comments

    Patchset-level comments
    File-level comment, Patchset 10 (Latest):
    Yao Xiao . resolved

    alexmos@: PTAL at //content. Thanks!
    dcheng@: PTAL at mojom and blink. Thanks!

    File third_party/blink/renderer/core/html/html_iframe_element.h
    Line 62, Patchset 5: String GetElementInfoForInterventionReport() const final;
    AI Code Reviewer . resolved

    nit: Blink Style Guide: Naming - Precede setters with the word “Set”; use bare words for getters. Please rename this to `ElementInfoForInterventionReport()` as there is no type name collision that would require a 'Get' prefix.

    _To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
    **Done** | **Won't fix**: reason | **b/<bug_id>** | **Invalid:** reason

    This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent).AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve.[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

    Yao Xiao

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alex Moshchuk
    • Daniel Cheng
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I5d988494dbbcd0aa6a9090745913369e7791e4a7
    Gerrit-Change-Number: 6937085
    Gerrit-PatchSet: 10
    Gerrit-Owner: Yao Xiao <yao...@chromium.org>
    Gerrit-Reviewer: Alex Moshchuk <ale...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Josh Karlin <jka...@chromium.org>
    Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    Gerrit-Attention: Alex Moshchuk <ale...@chromium.org>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Fri, 12 Sep 2025 15:25:09 +0000
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages