Cleanup MemoryCacheChangeStrongReferencePruneDelay feature flag [chromium/src : main]

0 views
Skip to first unread message

Gabriel Charette (Gerrit)

unread,
Aug 19, 2026, 3:47:51 PM (20 hours ago) Aug 19
to Etienne Pierre-Doray, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, android-web...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Attention needed from Etienne Pierre-Doray

Gabriel Charette added 1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Gabriel Charette . resolved

PTaL and select owner if happy w/ cleanup

Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie9e2f2de1d96c2d4303776e665f27b0e9b526a8b
Gerrit-Change-Number: 8258057
Gerrit-PatchSet: 6
Gerrit-Owner: Gabriel Charette <g...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Gabriel Charette <g...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Comment-Date: Wed, 19 Aug 2026 19:47:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Etienne Pierre-Doray (Gerrit)

unread,
Aug 19, 2026, 4:03:48 PM (20 hours ago) Aug 19
to Gabriel Charette, Alex Attar, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, android-web...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Attention needed from Alex Attar and Gabriel Charette

Etienne Pierre-Doray added 1 comment

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Etienne Pierre-Doray . resolved

I think that's for +aattar@

Open in Gerrit

Related details

Attention is currently required from:
  • Alex Attar
  • Gabriel Charette
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie9e2f2de1d96c2d4303776e665f27b0e9b526a8b
Gerrit-Change-Number: 8258057
Gerrit-PatchSet: 7
Gerrit-Owner: Gabriel Charette <g...@chromium.org>
Gerrit-Reviewer: Alex Attar <aat...@google.com>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Gabriel Charette <g...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-Attention: Gabriel Charette <g...@chromium.org>
Gerrit-Attention: Alex Attar <aat...@google.com>
Gerrit-Comment-Date: Wed, 19 Aug 2026 20:03:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Alex Attar (Gerrit)

unread,
Aug 19, 2026, 5:01:42 PM (19 hours ago) Aug 19
to Gabriel Charette, Etienne Pierre-Doray, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, android-web...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Attention needed from Gabriel Charette

Alex Attar voted and added 2 comments

Votes added by Alex Attar

Code-Review+1

2 comments

Patchset-level comments
Alex Attar . resolved

lgtm

File third_party/blink/renderer/platform/loader/fetch/memory_cache.cc
Line 158, Patchset 7 (Parent): &kMemoryCacheChangeStrongReferencePruneDelay,
Alex Attar . unresolved

Just in case it was missed: we should probably remove `MemoryCacheChangeStrongReferencePruneDelay` from `testing/variations/fieldtrial_testing_config.json` too.

If you are planning to just remove the PerfCombined2025 altogether once it has all been cleaned up, just ignore this comment.

Open in Gerrit

Related details

Attention is currently required from:
  • Gabriel Charette
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie9e2f2de1d96c2d4303776e665f27b0e9b526a8b
    Gerrit-Change-Number: 8258057
    Gerrit-PatchSet: 7
    Gerrit-Owner: Gabriel Charette <g...@chromium.org>
    Gerrit-Reviewer: Alex Attar <aat...@google.com>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Gabriel Charette <g...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-Attention: Gabriel Charette <g...@chromium.org>
    Gerrit-Comment-Date: Wed, 19 Aug 2026 21:01:31 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages