[CodeCache] Assign high priority for PersistentCache fetch thread [chromium/src : main]
0 views
Skip to first unread message
Takashi Nakayama (Gerrit)
Jun 9, 2026, 11:18:37 PM (2 days ago) Jun 9
to Greg Thompson, Kouhei Ueno, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Takashi Nakayama added 3 comments![]( "Open in Gerrit")
Commit Message
Line 9, Patchset 2:
Blink now spawns an utility process for managing code cache when usingGreg Thompson . resolved
Takashi Nakayamanit: "a"
Done
Line 9, Patchset 2:
Blink now spawns an utility process for managing code cache when usingGreg Thompson . resolved
Takashi Nakayamais this true? is it not just bouncing to another thread that it will use to talk to the browser process?
That's right. Thanks for pointing it out, I rewrote this sentence a bit (process -> thread, and "managing" -> "communicate").
File third_party/blink/renderer/platform/loader/fetch/persistent_code_cache_host.cc
Line 41, Patchset 2:
base::TaskTraits GetTaskTraitsForCodeCacheProcess() {Greg Thompson . resolved
Takashi Nakayamanit: blank line after namespace open
Done
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Takashi Nakayama (Gerrit)
Jun 10, 2026, 3:18:57 AM (yesterday) Jun 10
to Greg Thompson, Kouhei Ueno, Chromium LUCI CQ, chromium...@chromium.org, Nate Chapin, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Takashi Nakayama voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 10, 2026, 3:41:29 AM (yesterday) Jun 10
to Takashi Nakayama, Greg Thompson, Kouhei Ueno, chromium...@chromium.org, Nate Chapin, blink-...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, loading-re...@chromium.org, loading...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/blink/renderer/platform/loader/fetch/persistent_code_cache_host.cc
Insertions: 1, Deletions: 0.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[CodeCache] Assign high priority for PersistentCache fetch thread
Blink now spawns a utility thread to communicate to the browser process
when using PersistentCache for code cache, thus InlineScriptCache fetch
operations, which is conducted during the HTML parser by blocking the
main thread, is stalled while the utility process is not scheduled.
Assigning the highest priority for the utility thread will speed up
cache fetch.
Bug: 488755561
Change-Id: If39b1743dd5bde5b098fbc832ff19c6794d06271
Reviewed-by: Greg Thompson <g...@chromium.org>
Commit-Queue: Takashi Nakayama <tn...@chromium.org>
Reviewed-by: Kouhei Ueno <kou...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1644491}
Files:
- M third_party/blink/renderer/platform/loader/fetch/persistent_code_cache_host.cc
Change size: S
Delta: 1 file changed, 21 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Greg Thompson, +1 by Kouhei Ueno
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages