[FedCM] Fix Set-Login same-site bypass in SXG cert fetches [chromium/src : main]
0 views
Skip to first unread message
Christian Biesinger (Gerrit)
Apr 28, 2026, 5:30:00 PM (23 hours ago) Apr 28
to Christian Biesinger, Nicolás Peña, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, headless...@chromium.org, loading...@chromium.org
Attention needed from Nicolás Peña
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Nicolás Peña
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicolás Peña (Gerrit)
10:48 AM (5 hours ago) 10:48 AM
to Christian Biesinger, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, headless...@chromium.org, loading...@chromium.org
Attention needed from Christian Biesinger
Nicolás Peña voted and added 2 comments![]( "Open in Gerrit")
Votes added by Nicolás Peña
| Code-Review | +1 |
2 comments
File content/common/webid/identity_url_loader_throttle.cc
Line 47, Patchset 4 (Latest):
void IdentityUrlLoaderThrottle::DetachFromCurrentSequence() {Nicolás Peña . unresolved
What is this method for? Its confusing. Can we add a comment?
File content/common/webid/identity_url_loader_throttle_unittest.cc
Line 44, Patchset 4 (Latest):
network::mojom::RequestDestination cb_destination_;Nicolás Peña . unresolved
It's better to initialize this member to a default value (e.g., `network::mojom::RequestDestination::kEmpty`) to avoid potential garbage reads if a test checks it before any callback is run.
Related details
Attention is currently required from:
- Christian Biesinger
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Christian Biesinger (Gerrit)
11:30 AM (5 hours ago) 11:30 AM
to Christian Biesinger, Nicolás Peña, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, headless...@chromium.org, loading...@chromium.org
Christian Biesinger added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Christian Biesinger . resolved
I made an alternative fix for this in https://chromium-review.googlesource.com/c/chromium/src/+/7803097... let me know which you prefer
(Will add that comment either way, although it's unrelated to this change)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Christian Biesinger (Gerrit)
12:58 PM (3 hours ago) 12:58 PM
to Christian Biesinger, Nicolás Peña, Chromium LUCI CQ, chromium...@chromium.org, Peter Beverloo, headless...@chromium.org, loading...@chromium.org
Christian Biesinger added 2 comments![]( "Open in Gerrit")
File content/common/webid/identity_url_loader_throttle.cc
Line 47, Patchset 4:
void IdentityUrlLoaderThrottle::DetachFromCurrentSequence() {Nicolás Peña . resolved
What is this method for? Its confusing. Can we add a comment?
Christian Biesinger
File content/common/webid/identity_url_loader_throttle_unittest.cc
It's better to initialize this member to a default value (e.g., `network::mojom::RequestDestination::kEmpty`) to avoid potential garbage reads if a test checks it before any callback is run.
Christian Biesinger
Done
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages