Remove fine-grained GWS page load metrics histograms. [chromium/src : main]

0 views
Skip to first unread message

Takashi Toyoshima (Gerrit)

unread,
2:20 AM (6 hours ago) 2:20 AM
to Shunya Shishido, AyeAye, speed-metr...@chromium.org, loading-rev...@chromium.org, csharris...@chromium.org, bmcquad...@chromium.org, speed-metrics...@chromium.org
Attention needed from Shunya Shishido

Takashi Toyoshima voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Shunya Shishido
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I62e313ca2e5ac74d8382d8608254261a61e00849
Gerrit-Change-Number: 7126838
Gerrit-PatchSet: 1
Gerrit-Owner: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-Attention: Shunya Shishido <sisid...@chromium.org>
Gerrit-Comment-Date: Thu, 06 Nov 2025 07:20:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Takashi Toyoshima (Gerrit)

unread,
3:02 AM (6 hours ago) 3:02 AM
to Chromium Metrics Reviews, Chromium LUCI CQ, Shunya Shishido, AyeAye, asvitkine...@chromium.org, speed-metr...@chromium.org, loading-rev...@chromium.org, csharris...@chromium.org, bmcquad...@chromium.org, speed-metrics...@chromium.org
Attention needed from Shunya Shishido

Takashi Toyoshima voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Shunya Shishido
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I62e313ca2e5ac74d8382d8608254261a61e00849
Gerrit-Change-Number: 7126838
Gerrit-PatchSet: 3
Gerrit-Owner: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Shunya Shishido <sisid...@chromium.org>
Gerrit-Comment-Date: Thu, 06 Nov 2025 08:02:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Shunya Shishido (Gerrit)

unread,
4:13 AM (4 hours ago) 4:13 AM
to Takashi Toyoshima, Chromium Metrics Reviews, Chromium LUCI CQ, AyeAye, asvitkine...@chromium.org, speed-metr...@chromium.org, loading-rev...@chromium.org, csharris...@chromium.org, bmcquad...@chromium.org, speed-metrics...@chromium.org
Attention needed from Takashi Toyoshima

Shunya Shishido added 3 comments

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Shunya Shishido . resolved

Could you update the CL description?

Commit Message
File-level comment, Patchset 3 (Latest):
Shunya Shishido . unresolved

Please fix this INFO reported by Metrics: The following histograms have been removed and obsoleted in this CL: PageLoad.Cl...

The following histograms have been removed and obsoleted in this CL: PageLoad.Clients.GoogleSearch.FineGrained.Prerender.ActivationToLargestContentfulPaint.Incognito, PageLoad.Clients.GoogleSearch.FineGrained.Prerender.ActivationToLargestContentfulPaint, PageLoad.Clients.GoogleSearch.FineGrained.PaintTiming.NavigationToLargestContentfulPaint.

File-level comment, Patchset 3 (Latest):
Shunya Shishido . unresolved

Please fix this INFO reported by Metrics: The following histograms were removed without an obsoletion message: PageLoad.Cl...

The following histograms were removed without an obsoletion message: PageLoad.Clients.GoogleSearch.FineGrained.PaintTiming.NavigationToLargestContentfulPaint, PageLoad.Clients.GoogleSearch.FineGrained.Prerender.ActivationToLargestContentfulPaint.Incognito, PageLoad.Clients.GoogleSearch.FineGrained.Prerender.ActivationToLargestContentfulPaint. It is preferred to add an obsoletion message when a histogram is removed: https://chromium.googlesource.com/chromium/src/tools/+/HEAD/metrics/histograms/README.md#add-an-obsoletion-message.

Open in Gerrit

Related details

Attention is currently required from:
  • Takashi Toyoshima
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I62e313ca2e5ac74d8382d8608254261a61e00849
    Gerrit-Change-Number: 7126838
    Gerrit-PatchSet: 3
    Gerrit-Owner: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
    Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
    Gerrit-Comment-Date: Thu, 06 Nov 2025 09:13:15 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Shunya Shishido (Gerrit)

    unread,
    4:13 AM (4 hours ago) 4:13 AM
    to Takashi Toyoshima, Chromium Metrics Reviews, Chromium LUCI CQ, AyeAye, asvitkine...@chromium.org, speed-metr...@chromium.org, loading-rev...@chromium.org, csharris...@chromium.org, bmcquad...@chromium.org, speed-metrics...@chromium.org
    Attention needed from Takashi Toyoshima

    Shunya Shishido voted and added 1 comment

    Votes added by Shunya Shishido

    Code-Review+1

    1 comment

    Patchset-level comments
    Shunya Shishido . resolved

    Otherwise LGTM.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Takashi Toyoshima
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I62e313ca2e5ac74d8382d8608254261a61e00849
      Gerrit-Change-Number: 7126838
      Gerrit-PatchSet: 3
      Gerrit-Owner: Takashi Toyoshima <toyo...@chromium.org>
      Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
      Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-Attention: Takashi Toyoshima <toyo...@chromium.org>
      Gerrit-Comment-Date: Thu, 06 Nov 2025 09:13:34 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Takashi Toyoshima (Gerrit)

      unread,
      5:11 AM (3 hours ago) 5:11 AM
      to Shunya Shishido, Chromium Metrics Reviews, Chromium LUCI CQ, AyeAye, asvitkine...@chromium.org, speed-metr...@chromium.org, loading-rev...@chromium.org, csharris...@chromium.org, bmcquad...@chromium.org, speed-metrics...@chromium.org

      Takashi Toyoshima voted and added 3 comments

      Votes added by Takashi Toyoshima

      Auto-Submit+1
      Commit-Queue+2

      3 comments

      Patchset-level comments
      File-level comment, Patchset 4 (Latest):
      Takashi Toyoshima . resolved

      orz...

      Commit Message
      File-level comment, Patchset 3:
      Shunya Shishido . resolved

      Please fix this INFO reported by Metrics: The following histograms have been removed and obsoleted in this CL: PageLoad.Cl...

      The following histograms have been removed and obsoleted in this CL: PageLoad.Clients.GoogleSearch.FineGrained.Prerender.ActivationToLargestContentfulPaint.Incognito, PageLoad.Clients.GoogleSearch.FineGrained.Prerender.ActivationToLargestContentfulPaint, PageLoad.Clients.GoogleSearch.FineGrained.PaintTiming.NavigationToLargestContentfulPaint.

      Takashi Toyoshima

      Done

      File-level comment, Patchset 3:
      Shunya Shishido . resolved

      Please fix this INFO reported by Metrics: The following histograms were removed without an obsoletion message: PageLoad.Cl...

      The following histograms were removed without an obsoletion message: PageLoad.Clients.GoogleSearch.FineGrained.PaintTiming.NavigationToLargestContentfulPaint, PageLoad.Clients.GoogleSearch.FineGrained.Prerender.ActivationToLargestContentfulPaint.Incognito, PageLoad.Clients.GoogleSearch.FineGrained.Prerender.ActivationToLargestContentfulPaint. It is preferred to add an obsoletion message when a histogram is removed: https://chromium.googlesource.com/chromium/src/tools/+/HEAD/metrics/histograms/README.md#add-an-obsoletion-message.

      Takashi Toyoshima

      Done

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I62e313ca2e5ac74d8382d8608254261a61e00849
        Gerrit-Change-Number: 7126838
        Gerrit-PatchSet: 4
        Gerrit-Owner: Takashi Toyoshima <toyo...@chromium.org>
        Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
        Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        Gerrit-Comment-Date: Thu, 06 Nov 2025 10:10:36 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        Comment-In-Reply-To: Shunya Shishido <sisid...@chromium.org>
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        5:13 AM (3 hours ago) 5:13 AM
        to Takashi Toyoshima, Shunya Shishido, Chromium Metrics Reviews, AyeAye, asvitkine...@chromium.org, speed-metr...@chromium.org, loading-rev...@chromium.org, csharris...@chromium.org, bmcquad...@chromium.org, speed-metrics...@chromium.org

        Chromium LUCI CQ submitted the change

        Unreviewed changes

        3 is the latest approved patch-set.
        No files were changed between the latest approved patch-set and the submitted one.

        Change information

        Commit message:
        Remove fine-grained GWS page load metrics histograms.

        This change removes the `PageLoad.Clients.GoogleSearch.FineGrained.*`
        histograms, including those for Largest Contentful Paint and Activation
        to Largest Contentful Paint.

        OBSOLETE_HISTOGRAMS=Removed as investigation was finished.
        Change-Id: I62e313ca2e5ac74d8382d8608254261a61e00849
        Reviewed-by: Shunya Shishido <sisid...@chromium.org>
        Commit-Queue: Takashi Toyoshima <toyo...@chromium.org>
        Auto-Submit: Takashi Toyoshima <toyo...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#1541112}
        Files:
        • M components/page_load_metrics/google/browser/gws_page_load_metrics_observer.cc
        • M components/page_load_metrics/google/browser/gws_page_load_metrics_observer.h
        • M tools/metrics/histograms/metadata/page/histograms.xml
        Change size: M
        Delta: 3 files changed, 32 insertions(+), 67 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Shunya Shishido
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I62e313ca2e5ac74d8382d8608254261a61e00849
        Gerrit-Change-Number: 7126838
        Gerrit-PatchSet: 5
        Gerrit-Owner: Takashi Toyoshima <toyo...@chromium.org>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
        Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        open
        diffy
        satisfied_requirement

        zamberi zahari (BERE88) (Gerrit)

        unread,
        5:18 AM (3 hours ago) 5:18 AM
        to Takashi Toyoshima, Chromium LUCI CQ, Shunya Shishido, Chromium Metrics Reviews, AyeAye, asvitkine...@chromium.org, speed-metr...@chromium.org, loading-rev...@chromium.org, csharris...@chromium.org, bmcquad...@chromium.org, speed-metrics...@chromium.org

        zamberi zahari (BERE88) added 1 comment

        Patchset-level comments
        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I62e313ca2e5ac74d8382d8608254261a61e00849
        Gerrit-Change-Number: 7126838
        Gerrit-PatchSet: 5
        Gerrit-Owner: Takashi Toyoshima <toyo...@chromium.org>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
        Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        Gerrit-CC: zamberi zahari (BERE88) <zamry...@gmail.com>
        Gerrit-Comment-Date: Thu, 06 Nov 2025 10:17:58 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        satisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages