Reduce includes of runtime_enabled_features.h [chromium/src : main]

0 views
Skip to first unread message

Kent Tamura (Gerrit)

unread,
Apr 28, 2026, 3:02:56 AM (yesterday) Apr 28
to Kent Tamura, Fredrik Söderquist, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Olga Gerchikov, Andrew Rayskiy, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Xida Chen, mac-r...@chromium.org, aleventh...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, core-timi...@chromium.org, dcheng+c...@chromium.org, devtools-re...@chromium.org, dmurph+wa...@chromium.org, dom+...@chromium.org, dominicc+...@chromium.org, drott+bl...@chromium.org, dtapuska+...@chromium.org, edgesto...@microsoft.com, emircan+watch...@chromium.org, enne...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, jbroma...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, kouhe...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, mcasas+med...@chromium.org, mfoltz+wa...@chromium.org, pdr+svgw...@chromium.org, scheduler-...@chromium.org, speed-metrics...@chromium.org, video-networking...@google.com, web-schedulin...@chromium.org, zol...@webkit.org
Attention needed from Fredrik Söderquist

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Kent Tamura . resolved

fs@, would you stamp this please?

Open in Gerrit

Related details

Attention is currently required from:
  • Fredrik Söderquist
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2f62f1ae534ff6a5dfb6babbdab4680dc4ff1aba
Gerrit-Change-Number: 7790429
Gerrit-PatchSet: 5
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Xida Chen <xida...@chromium.org>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Fredrik Söderquist <f...@opera.com>
Gerrit-Comment-Date: Tue, 28 Apr 2026 07:02:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Fredrik Söderquist (Gerrit)

unread,
Apr 28, 2026, 4:27:26 AM (yesterday) Apr 28
to Kent Tamura, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Olga Gerchikov, Andrew Rayskiy, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Xida Chen, mac-r...@chromium.org, aleventh...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, core-timi...@chromium.org, dcheng+c...@chromium.org, devtools-re...@chromium.org, dmurph+wa...@chromium.org, dom+...@chromium.org, dominicc+...@chromium.org, drott+bl...@chromium.org, dtapuska+...@chromium.org, edgesto...@microsoft.com, emircan+watch...@chromium.org, enne...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, jbroma...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, kouhe...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, mcasas+med...@chromium.org, mfoltz+wa...@chromium.org, pdr+svgw...@chromium.org, scheduler-...@chromium.org, speed-metrics...@chromium.org, video-networking...@google.com, web-schedulin...@chromium.org, zol...@webkit.org
Attention needed from Kent Tamura

Fredrik Söderquist voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Tue, 28 Apr 2026 08:27:08 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Apr 28, 2026, 4:35:26 AM (yesterday) Apr 28
    to Kent Tamura, Fredrik Söderquist, android-bu...@system.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Olga Gerchikov, Andrew Rayskiy, Kentaro Hara, Nate Chapin, Raphael Kubo da Costa, Stephen Chenney, Simon Hangl, srirama chandra sekhar, Xida Chen, mac-r...@chromium.org, aleventh...@chromium.org, apavlo...@chromium.org, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, core-timi...@chromium.org, dcheng+c...@chromium.org, devtools-re...@chromium.org, dmurph+wa...@chromium.org, dom+...@chromium.org, dominicc+...@chromium.org, drott+bl...@chromium.org, dtapuska+...@chromium.org, edgesto...@microsoft.com, emircan+watch...@chromium.org, enne...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gavinp...@chromium.org, hiroshig...@chromium.org, jbroma...@chromium.org, kinuko...@chromium.org, kouhei...@chromium.org, kouhe...@chromium.org, loading-re...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, mcasas+med...@chromium.org, mfoltz+wa...@chromium.org, pdr+svgw...@chromium.org, scheduler-...@chromium.org, speed-metrics...@chromium.org, video-networking...@google.com, web-schedulin...@chromium.org, zol...@webkit.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Reduce includes of runtime_enabled_features.h

    This change reduces unnecessary includes of runtime_enabled_features.h
    across Blink. This CL reduces the file read amount by 370MB during a
    clean build, contributing to improved build performance.
    Change-Id: I2f62f1ae534ff6a5dfb6babbdab4680dc4ff1aba
    Auto-Submit: Kent Tamura <tk...@chromium.org>
    Reviewed-by: Fredrik Söderquist <f...@opera.com>
    Commit-Queue: Fredrik Söderquist <f...@opera.com>
    Cr-Commit-Position: refs/heads/main@{#1621600}
    Files:
    • M third_party/blink/renderer/bindings/core/v8/callback_invoke_helper.cc
    • M third_party/blink/renderer/bindings/core/v8/module_request.cc
    • M third_party/blink/renderer/bindings/core/v8/profiler_trace_builder.cc
    • M third_party/blink/renderer/bindings/core/v8/script_custom_element_definition_builder.cc
    • M third_party/blink/renderer/bindings/modules/v8/serialization/v8_script_value_serializer_for_modules.cc
    • M third_party/blink/renderer/build/scripts/templates/element_type_helpers.h.tmpl
    • M third_party/blink/renderer/core/animation/keyframe_effect_model.cc
    • M third_party/blink/renderer/core/clipboard/data_transfer.cc
    • M third_party/blink/renderer/core/css/css_attr_type.cc
    • M third_party/blink/renderer/core/css/css_markup.cc
    • M third_party/blink/renderer/core/css/css_position_try_descriptors.h
    • M third_party/blink/renderer/core/css/css_style_rule.cc
    • M third_party/blink/renderer/core/css/css_syntax_string_parser.cc
    • M third_party/blink/renderer/core/css/css_variable_data.cc
    • M third_party/blink/renderer/core/css/native_paint_image_generator.h
    • M third_party/blink/renderer/core/css/page_rule_collector.cc
    • M third_party/blink/renderer/core/css/parser/container_query_parser.cc
    • M third_party/blink/renderer/core/css/resolver/cascade_expansion.cc
    • M third_party/blink/renderer/core/css/try_value_flips.cc
    • M third_party/blink/renderer/core/dom/document.h
    • M third_party/blink/renderer/core/dom/document_fragment.cc
    • M third_party/blink/renderer/core/dom/document_init.cc
    • M third_party/blink/renderer/core/dom/node.h
    • M third_party/blink/renderer/core/dom/node_cloning_data.h
    • M third_party/blink/renderer/core/dom/range.cc
    • M third_party/blink/renderer/core/editing/finder/text_finder.cc
    • M third_party/blink/renderer/core/editing/selection_adjuster.cc
    • M third_party/blink/renderer/core/editing/state_machines/state_machine_util.cc
    • M third_party/blink/renderer/core/editing/state_machines/state_machine_util.h
    • M third_party/blink/renderer/core/events/command_event.cc
    • M third_party/blink/renderer/core/events/interest_event.cc
    • M third_party/blink/renderer/core/frame/display_cutout_client_impl.cc
    • M third_party/blink/renderer/core/frame/use_counter_impl_test.cc
    • M third_party/blink/renderer/core/highlight/highlight_style_utils.cc
    • M third_party/blink/renderer/core/html/forms/base_temporal_input_type.cc
    • M third_party/blink/renderer/core/html/forms/date_time_local_input_type.cc
    • M third_party/blink/renderer/core/html/forms/html_form_control_element_with_state.cc
    • M third_party/blink/renderer/core/html/forms/html_input_element_test.cc
    • M third_party/blink/renderer/core/html/forms/image_input_type.cc
    • M third_party/blink/renderer/core/html/forms/type_ahead.cc
    • M third_party/blink/renderer/core/html/html_template_element.cc
    • M third_party/blink/renderer/core/html/link_rel_attribute.cc
    • M third_party/blink/renderer/core/html/media/media_video_visibility_tracker.cc
    • M third_party/blink/renderer/core/html/parser/atomic_html_token.h
    • M third_party/blink/renderer/core/html/parser/html_element_stack.cc
    • M third_party/blink/renderer/core/html/parser/html_element_stack.h
    • M third_party/blink/renderer/core/html/parser/html_token.h
    • M third_party/blink/renderer/core/html/parser/html_tokenizer.h
    • M third_party/blink/renderer/core/inspector/inspector_style_resolver.cc
    • M third_party/blink/renderer/core/layout/anchor_position_scroll_data.h
    • M third_party/blink/renderer/core/layout/block_node.cc
    • M third_party/blink/renderer/core/layout/layout_box_utils.cc
    • M third_party/blink/renderer/core/layout/layout_replaced.cc
    • M third_party/blink/renderer/core/layout/shapes/ellipse_shape.cc
    • M third_party/blink/renderer/core/loader/resource/link_dictionary_resource.cc
    • M third_party/blink/renderer/core/page/chrome_client_impl_test.cc
    • M third_party/blink/renderer/core/paint/marker_range_mapping_context.h
    • M third_party/blink/renderer/core/paint/timing/paint_timing.cc
    • M third_party/blink/renderer/core/paint/view_painter.cc
    • M third_party/blink/renderer/core/scheduler/dom_scheduler.cc
    • M third_party/blink/renderer/core/scheduler/dom_task.cc
    • M third_party/blink/renderer/core/scheduler/window_idle_tasks.cc
    • M third_party/blink/renderer/core/script/document_modulator_impl.cc
    • M third_party/blink/renderer/core/script/import_map.cc
    • M third_party/blink/renderer/core/scroll/scroll_into_view_util.cc
    • M third_party/blink/renderer/core/scroll/scroll_promise_resolver.h
    • M third_party/blink/renderer/core/style/computed_style_constants.h
    • M third_party/blink/renderer/core/svg/svg_animated_string.cc
    • M third_party/blink/renderer/core/svg/svg_transform_list.cc
    • M third_party/blink/renderer/core/timing/event_timing.cc
    • M third_party/blink/renderer/core/timing/performance_paint_timing.cc
    • M third_party/blink/renderer/core/url_pattern/url_pattern.cc
    • M third_party/blink/renderer/core/url_pattern/url_pattern_component.cc
    • M third_party/blink/renderer/core/view_transition/view_transition_utils.cc
    • M third_party/blink/renderer/core/xml/dom_parser.cc
    • M third_party/blink/renderer/modules/content_extraction/ai_page_content_agent_unittest.cc
    • M third_party/blink/renderer/modules/csspaint/nativepaint/clip_path_paint_definition.cc
    • M third_party/blink/renderer/modules/direct_sockets/udp_socket.cc
    • M third_party/blink/renderer/modules/indexeddb/idb_get_all_options_helper.cc
    • M third_party/blink/renderer/modules/media_capabilities/media_capabilities_test.cc
    • M third_party/blink/renderer/modules/mediarecorder/video_track_recorder.cc
    • M third_party/blink/renderer/modules/mediasource/media_source.cc
    • M third_party/blink/renderer/modules/mediasource/source_buffer.cc
    • M third_party/blink/renderer/modules/peerconnection/peer_connection_dependency_factory_test.cc
    • M third_party/blink/renderer/platform/bindings/exception_state.cc
    • M third_party/blink/renderer/platform/fonts/font.cc
    • M third_party/blink/renderer/platform/fonts/font_custom_platform_data.cc
    • M third_party/blink/renderer/platform/fonts/mac/font_cache_mac.mm
    • M third_party/blink/renderer/platform/fonts/script_run_iterator.cc
    • M third_party/blink/renderer/platform/fonts/shaping/frame_shape_cache.cc
    • M third_party/blink/renderer/platform/fonts/symbols_iterator.cc
    • M third_party/blink/renderer/platform/fonts/symbols_iterator_test.cc
    • M third_party/blink/renderer/platform/fonts/win/font_cache_skia_win.cc
    • M third_party/blink/renderer/platform/fonts/win/font_fallback_win.cc
    • M third_party/blink/renderer/platform/geometry/layout_unit.h
    • M third_party/blink/renderer/platform/graphics/compositor_filter_operations.cc
    • M third_party/blink/renderer/platform/graphics/gpu/shared_gpu_context.cc
    • M third_party/blink/renderer/platform/graphics/paint/cull_rect.cc
    • M third_party/blink/renderer/platform/graphics/paint/effect_paint_property_node.cc
    • M third_party/blink/renderer/platform/graphics/paint/property_tree_state.cc
    • M third_party/blink/renderer/platform/graphics/paint/raster_invalidator_test.cc
    • M third_party/blink/renderer/platform/json/json_values.cc
    • M third_party/blink/renderer/platform/loader/fetch/resource.cc
    • M third_party/blink/renderer/platform/loader/fetch/resource_request_utils.cc
    • M third_party/blink/renderer/platform/loader/fetch/resource_response.cc
    • M third_party/blink/renderer/platform/loader/subresource_integrity_test.cc
    • M third_party/blink/renderer/platform/scheduler/common/event_loop.cc
    • M third_party/blink/renderer/platform/text/text_break_iterator.cc
    • M third_party/blink/renderer/platform/widget/input/main_thread_event_queue.cc
    Change size: M
    Delta: 109 files changed, 16 insertions(+), 96 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Fredrik Söderquist
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2f62f1ae534ff6a5dfb6babbdab4680dc4ff1aba
    Gerrit-Change-Number: 7790429
    Gerrit-PatchSet: 6
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Fredrik Söderquist <f...@opera.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages