Mark blink::StringView::operator[] as UNSAFE_BUFFER_USAGE [chromium/src : main]

0 views
Skip to first unread message

Tom Sepez (Gerrit)

unread,
Apr 2, 2026, 4:01:47 PM (yesterday) Apr 2
to Kentaro Hara, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Nate Chapin, Rijubrata Bhaumik, Stephen Chenney, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, dcheng+c...@chromium.org, devtools-re...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, pdr+svgw...@chromium.org, speed-metrics...@chromium.org, zol...@webkit.org
Attention needed from Kentaro Hara

Tom Sepez added 1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Tom Sepez . resolved

+Kentaro for Owners Override.

Open in Gerrit

Related details

Attention is currently required from:
  • Kentaro Hara
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Icef0a2f3614b5ce74de2d8ce6d092622c845512c
Gerrit-Change-Number: 7722317
Gerrit-PatchSet: 6
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Kentaro Hara <har...@chromium.org>
Gerrit-Comment-Date: Thu, 02 Apr 2026 20:01:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kentaro Hara (Gerrit)

unread,
Apr 2, 2026, 7:57:06 PM (yesterday) Apr 2
to Tom Sepez, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Nate Chapin, Rijubrata Bhaumik, Stephen Chenney, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, dcheng+c...@chromium.org, devtools-re...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, pdr+svgw...@chromium.org, speed-metrics...@chromium.org, zol...@webkit.org
Attention needed from Tom Sepez

Kentaro Hara voted

Code-Review+1
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Tom Sepez
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Icef0a2f3614b5ce74de2d8ce6d092622c845512c
Gerrit-Change-Number: 7722317
Gerrit-PatchSet: 6
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Tom Sepez <tse...@chromium.org>
Gerrit-Comment-Date: Thu, 02 Apr 2026 23:56:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Tom Sepez (Gerrit)

unread,
Apr 2, 2026, 8:08:56 PM (yesterday) Apr 2
to Kentaro Hara, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Nate Chapin, Rijubrata Bhaumik, Stephen Chenney, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, dcheng+c...@chromium.org, devtools-re...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, pdr+svgw...@chromium.org, speed-metrics...@chromium.org, zol...@webkit.org

Tom Sepez voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Icef0a2f3614b5ce74de2d8ce6d092622c845512c
Gerrit-Change-Number: 7722317
Gerrit-PatchSet: 6
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Comment-Date: Fri, 03 Apr 2026 00:08:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Apr 2, 2026, 8:16:02 PM (yesterday) Apr 2
to Tom Sepez, Kentaro Hara, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Fredrik Söderquist, Nate Chapin, Rijubrata Bhaumik, Stephen Chenney, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-reviews-p...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, dcheng+c...@chromium.org, devtools-re...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, gavinp...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, pdr+svgw...@chromium.org, speed-metrics...@chromium.org, zol...@webkit.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Mark blink::StringView::operator[] as UNSAFE_BUFFER_USAGE

Then justify safety in callers, when easy to do so.

-- Simplify some cases to remove repeated access.
Change-Id: Icef0a2f3614b5ce74de2d8ce6d092622c845512c
Reviewed-by: Kentaro Hara <har...@chromium.org>
Owners-Override: Kentaro Hara <har...@chromium.org>
Commit-Queue: Tom Sepez <tse...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1609577}
Files:
  • M third_party/blink/renderer/core/clipboard/clipboard_utilities.cc
  • M third_party/blink/renderer/core/css/css_variable_data.cc
  • M third_party/blink/renderer/core/css/parser/css_parser_impl.cc
  • M third_party/blink/renderer/core/css/parser/css_property_parser.cc
  • M third_party/blink/renderer/core/css/parser/css_selector_parser.cc
  • M third_party/blink/renderer/core/css/parser/css_tokenizer.cc
  • M third_party/blink/renderer/core/css/parser/css_tokenizer_input_stream.h
  • M third_party/blink/renderer/core/css/parser/css_variable_parser.cc
  • M third_party/blink/renderer/core/css/properties/css_parsing_utils.h
  • M third_party/blink/renderer/core/css/selector_checker.cc
  • M third_party/blink/renderer/core/editing/commands/insert_incremental_text_command.cc
  • M third_party/blink/renderer/core/editing/editing_utilities.cc
  • M third_party/blink/renderer/core/html/forms/email_input_type.cc
  • M third_party/blink/renderer/core/html/forms/html_input_element.cc
  • M third_party/blink/renderer/core/html/html_view_source_document.cc
  • M third_party/blink/renderer/core/html/parser/css_preload_scanner.cc
  • M third_party/blink/renderer/core/html/parser/html_construction_site.cc
  • M third_party/blink/renderer/core/inspector/inspector_css_parser_observer.cc
  • M third_party/blink/renderer/core/inspector/inspector_style_sheet.cc
  • M third_party/blink/renderer/core/layout/inline/inline_cursor.cc
  • M third_party/blink/renderer/core/layout/inline/inline_items_builder.cc
  • M third_party/blink/renderer/core/layout/svg/svg_text_query.cc
  • M third_party/blink/renderer/core/page/page_popup_client.cc
  • M third_party/blink/renderer/core/timing/background_tracing_helper.cc
  • M third_party/blink/renderer/modules/nfc/ndef_record.cc
  • M third_party/blink/renderer/platform/fonts/plain_text_node.cc
  • M third_party/blink/renderer/platform/fonts/shaping/shape_result_bloberizer.cc
  • M third_party/blink/renderer/platform/json/json_values.cc
  • M third_party/blink/renderer/platform/loader/cors/cors_error_string.cc
  • M third_party/blink/renderer/platform/network/http_parsers.cc
  • M third_party/blink/renderer/platform/text/character_break_iterator.cc
  • M third_party/blink/renderer/platform/text/date_time_format.cc
  • M third_party/blink/renderer/platform/text/hyphenation.h
  • M third_party/blink/renderer/platform/text/hyphenation/hyphenation_minikin.cc
  • M third_party/blink/renderer/platform/text/text_run.h
  • M third_party/blink/renderer/platform/weborigin/kurl.cc
  • M third_party/blink/renderer/platform/weborigin/security_policy.cc
  • M third_party/blink/renderer/platform/wtf/text/strcat.cc
  • M third_party/blink/renderer/platform/wtf/text/string_impl.cc
  • M third_party/blink/renderer/platform/wtf/text/string_internal.h
  • M third_party/blink/renderer/platform/wtf/text/string_statics.cc
  • M third_party/blink/renderer/platform/wtf/text/string_view.cc
  • M third_party/blink/renderer/platform/wtf/text/string_view.h
  • M third_party/blink/renderer/platform/wtf/text/string_view_test.cc
Change size: L
Delta: 44 files changed, 246 insertions(+), 117 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Kentaro Hara
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Icef0a2f3614b5ce74de2d8ce6d092622c845512c
Gerrit-Change-Number: 7722317
Gerrit-PatchSet: 7
Gerrit-Owner: Tom Sepez <tse...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages