Eriko Kurimoto (Gerrit)

unread,

Mar 31, 2026, 4:52:16 AM (4 days ago) Mar 31

to Vasilii Sukhanov, Minoru Chikamune, Mirko Bonadei, Jerome Jiang, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, fgal...@chromium.org, devtools...@chromium.org, cblume...@chromium.org, chrome-intelligence-te...@google.com, penghuan...@chromium.org, chrome-intell...@chromium.org, jz...@chromium.org, mar...@chromium.org, feature-me...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, chromiumme...@microsoft.com, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

Attention needed from Minoru Chikamune and Vasilii Sukhanov

Eriko Kurimoto added 1 comment

Patchset-level comments

File-level comment, Patchset 13 (Latest):

Eriko Kurimoto . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:

Minoru Chikamune
Vasilii Sukhanov

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Minoru Chikamune (Gerrit)

unread,

Mar 31, 2026, 10:16:20 AM (3 days ago) Mar 31

to Eriko Kurimoto, Minoru Chikamune, Vasilii Sukhanov, Mirko Bonadei, Jerome Jiang, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, fgal...@chromium.org, devtools...@chromium.org, cblume...@chromium.org, chrome-intelligence-te...@google.com, penghuan...@chromium.org, chrome-intell...@chromium.org, jz...@chromium.org, mar...@chromium.org, feature-me...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, chromiumme...@microsoft.com, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

Attention needed from Eriko Kurimoto and Vasilii Sukhanov

Minoru Chikamune voted and added 2 comments

Votes added by Minoru Chikamune

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 13 (Latest):

Minoru Chikamune . resolved

LGTM

Commit Message

Line 24, Patchset 13 (Latest):

Minoru Chikamune . unresolved

Could you please add the bug id?
```
Bug: 477426026
```

Open in Gerrit

Related details

Attention is currently required from:

Eriko Kurimoto
Vasilii Sukhanov

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Eriko Kurimoto (Gerrit)

unread,

Mar 31, 2026, 8:43:11 PM (3 days ago) Mar 31

to Minoru Chikamune, Vasilii Sukhanov, Mirko Bonadei, Jerome Jiang, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, fgal...@chromium.org, devtools...@chromium.org, cblume...@chromium.org, chrome-intelligence-te...@google.com, penghuan...@chromium.org, chrome-intell...@chromium.org, jz...@chromium.org, mar...@chromium.org, feature-me...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, chromiumme...@microsoft.com, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

Attention needed from Vasilii Sukhanov

Eriko Kurimoto voted and added 1 comment

Votes added by Eriko Kurimoto

Auto-Submit

+1

1 comment

Commit Message

Line 24, Patchset 13:

Minoru Chikamune . resolved

Could you please add the bug id?
```
Bug: 477426026
```

Eriko Kurimoto

Done

Open in Gerrit

Related details

Attention is currently required from:

Vasilii Sukhanov

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Vasilii Sukhanov (Gerrit)

unread,

Apr 2, 2026, 7:56:18 AM (yesterday) Apr 2

to Eriko Kurimoto, Minoru Chikamune, Mirko Bonadei, Jerome Jiang, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, fgal...@chromium.org, devtools...@chromium.org, cblume...@chromium.org, chrome-intelligence-te...@google.com, penghuan...@chromium.org, chrome-intell...@chromium.org, jz...@chromium.org, mar...@chromium.org, feature-me...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, chromiumme...@microsoft.com, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

Attention needed from Eriko Kurimoto

Vasilii Sukhanov voted and added 1 comment

Votes added by Vasilii Sukhanov

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 14 (Latest):

Vasilii Sukhanov . resolved

chrome/browser/metrics/ukm_browsertest.cc LGTM

Open in Gerrit

Related details

Attention is currently required from:

Eriko Kurimoto

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Eriko Kurimoto (Gerrit)

unread,

1:06 AM (20 hours ago) 1:06 AM

to Vasilii Sukhanov, Minoru Chikamune, Mirko Bonadei, Jerome Jiang, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, fgal...@chromium.org, devtools...@chromium.org, cblume...@chromium.org, chrome-intelligence-te...@google.com, penghuan...@chromium.org, chrome-intell...@chromium.org, jz...@chromium.org, mar...@chromium.org, feature-me...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, chromiumme...@microsoft.com, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

Eriko Kurimoto voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

1:46 AM (19 hours ago) 1:46 AM

to Eriko Kurimoto, Vasilii Sukhanov, Minoru Chikamune, Mirko Bonadei, Jerome Jiang, AyeAye, chromium...@chromium.org, fgal...@chromium.org, devtools...@chromium.org, cblume...@chromium.org, chrome-intelligence-te...@google.com, penghuan...@chromium.org, chrome-intell...@chromium.org, jz...@chromium.org, mar...@chromium.org, feature-me...@chromium.org, asvitki...@chromium.org, bmcquad...@chromium.org, chromiumme...@microsoft.com, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

WaaP: Fix UKM and PageLoad metrics tests for InitialWebUI

When `features::kInitialWebUI` is enabled, Chrome spawns a background
WebContents (`chrome://new-tab-page`) during startup. This breaks tests
that strictly assert the total number of PageLoad UKM entries equals 1.

This CL centralizes UKM extraction logic in `MetricIntegrationTest`
and `PageLoadMetricsBrowserTestBase` to explicitly filter out entries
originating from `chrome://` or `chrome-untrusted://` schemes.

Fixed tests:
- InteractionToNextPaintTest.*
- SoftNavigationTest.*
- SmoothnessMetricTest.*
- PageLoadMetricsBrowserTest.*
- UkmBrowserTest.LogsTabId
- LayoutInstabilityTest.*

Bug: 477426026

Change-Id: I6467ae407b09987e986b30a68b08522d54c657db

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7707018

Auto-Submit: Eriko Kurimoto <elk...@chromium.org>

Reviewed-by: Minoru Chikamune <chik...@chromium.org>

Reviewed-by: Vasilii Sukhanov <vas...@chromium.org>

Commit-Queue: Eriko Kurimoto <elk...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1609674}

Files:

M chrome/browser/metrics/ukm_browsertest.cc
M chrome/browser/page_load_metrics/integration_tests/interaction_to_next_paint_browsertest.cc
M chrome/browser/page_load_metrics/integration_tests/metric_integration_test.cc
M chrome/browser/page_load_metrics/integration_tests/metric_integration_test.h
M chrome/browser/page_load_metrics/integration_tests/soft_navigation_metrics_browsertest.cc
M chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc

Change size: M

Delta: 6 files changed, 130 insertions(+), 71 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Vasilii Sukhanov, +1 by Minoru Chikamune

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

WaaP: Fix UKM and PageLoad metrics tests for InitialWebUI [chromium/src : main]

Eriko Kurimoto (Gerrit)

Eriko Kurimoto added 1 comment

Related details

Minoru Chikamune (Gerrit)

Minoru Chikamune voted and added 2 comments

Votes added by Minoru Chikamune

2 comments

Related details

Eriko Kurimoto (Gerrit)

Eriko Kurimoto voted and added 1 comment

Votes added by Eriko Kurimoto

1 comment

Related details

Vasilii Sukhanov (Gerrit)

Vasilii Sukhanov voted and added 1 comment

Votes added by Vasilii Sukhanov

1 comment

Related details

Eriko Kurimoto (Gerrit)

Eriko Kurimoto voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information